Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 02:58:53 +1000
From:   Nicholas Piggin <npiggin@gmail.com>
Subject: Re: [PATCH v2 0/3] Power10 basic energy management
To:     ego@linux.vnet.ibm.com
Cc:     benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org, mikey@neuling.org,
        mpe@ellerman.id.au, paulus@samba.org, pratik.r.sampat@gmail.com,
        Pratik Rajesh Sampat <psampat@linux.ibm.com>,
        ravi.bangoria@linux.ibm.com, svaidy@linux.ibm.com
References: <20200710052207.12003-1-psampat@linux.ibm.com>
        <1594617564.57k8bsyfd0.astroid@bobo.none>
        <20200713104837.GG24866@in.ibm.com>
In-Reply-To: <20200713104837.GG24866@in.ibm.com>
MIME-Version: 1.0
Message-Id: <1594659004.tvqngaepru.astroid@bobo.none>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Excerpts from Gautham R Shenoy's message of July 13, 2020 8:48 pm:
> On Mon, Jul 13, 2020 at 03:23:21PM +1000, Nicholas Piggin wrote:
>> Excerpts from Pratik Rajesh Sampat's message of July 10, 2020 3:22 pm:
>> > Changelog v1 --> v2:
>> > 1. Save-restore DAWR and DAWRX unconditionally as they are lost in
>> > shallow idle states too
>> > 2. Rename pnv_first_spr_loss_level to pnv_first_fullstate_loss_level t=
o
>> > correct naming terminology
>> >=20
>> > Pratik Rajesh Sampat (3):
>> >   powerpc/powernv/idle: Exclude mfspr on HID1,4,5 on P9 and above
>> >   powerpc/powernv/idle: save-restore DAWR0,DAWRX0 for P10
>> >   powerpc/powernv/idle: Rename pnv_first_spr_loss_level variable
>> >=20
>> >  arch/powerpc/platforms/powernv/idle.c | 34 +++++++++++++++++---------=
-
>> >  1 file changed, 22 insertions(+), 12 deletions(-)
>>=20
>> These look okay to me, but the CPU_FTR_ARCH_300 test for=20
>> pnv_power9_idle_init() is actually wrong, it should be a PVR test=20
>> because idle is not completely architected (not even shallow stop=20
>> states, unfortunately).
>>=20
>> It doesn't look like we support POWER10 idle correctly yet, and on older
>> kernels it wouldn't work even if we fixed newer, so ideally the PVR=20
>> check would be backported as a fix in the front of the series.
>>=20
>> Sadly, we have no OPAL idle driver yet. Hopefully we will before the
>> next processor shows up :P
>=20
> Abhishek posted a version recently :
> https://patchwork.ozlabs.org/project/skiboot/patch/20200706043533.76539-1=
-huntbag@linux.vnet.ibm.com/

Yep, I saw that. Still keen to get it working, just had other priorities=20
in the short term. We'll need to do this OPAL v4 thing for it.

Thanks,
Nick