Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC PATCH 1/4] dt-bindings:thermal:Add cold trip point type
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, rui.zhang@intel.com,
        robh+dt@kernel.org
Cc:     linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20200710135154.181454-1-thara.gopinath@linaro.org>
 <20200710135154.181454-2-thara.gopinath@linaro.org>
 <08503e0c-c8db-6d03-9692-5339dadf6c4f@linaro.org>
From:   Thara Gopinath <thara.gopinath@linaro.org>
Message-ID: <2b845792-41f0-7fb1-122e-a77aa70c9a3c@linaro.org>
Date:   Mon, 13 Jul 2020 13:01:02 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
MIME-Version: 1.0
In-Reply-To: <08503e0c-c8db-6d03-9692-5339dadf6c4f@linaro.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 7/13/20 11:05 AM, Daniel Lezcano wrote:
> On 10/07/2020 15:51, Thara Gopinath wrote:
>> Extend thermal trip point type property to include "cold" trip type
>> indicating point in the temperature domain below which a warming action
>> must be intiated.
>>
>> Signed-off-by: Thara Gopinath <thara.gopinath@linaro.org>
>> ---
>>   Documentation/devicetree/bindings/thermal/thermal.txt | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
>> index f78bec19ca35..1689d9ba1471 100644
>> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
>> @@ -87,6 +87,7 @@ Required properties:
>>   	"active":	A trip point to enable active cooling
>>   	"passive":	A trip point to enable passive cooling
>>   	"hot":		A trip point to notify emergency
>> +	"cold":		A trip point to enable warming
>>   	"critical":	Hardware not reliable.
>>     Type: string
> 
> 
> thermal.txt should have been removed. Perhaps, a patch is missing. The
> thermal.txt has been converted into 3 yaml schema.
> 
> The change should be in thermal-zones.yaml.

Hi Daniel..

Thanks for the review. My bad.. I will fix this in the next version.
I can send a patch removing thermal.txt as well


> 
> 

-- 
Warm Regards
Thara