Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1141291ybh; Mon, 13 Jul 2020 10:19:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAMM38N3D1Qia4vLYlDmGp5nlv40b72Tkk0SESt4h30kQatwrB04XRiLmOJzNR/JIvD8sp X-Received: by 2002:a50:d513:: with SMTP id u19mr391702edi.241.1594660758271; Mon, 13 Jul 2020 10:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594660758; cv=none; d=google.com; s=arc-20160816; b=KLEuLfYBaUOMy/hrrMkXyieRF7G8mnBBP3VX+DKwY/jA/Eo+o9hJT0IDXA2t9Rliwj wqJtvqErOg+8dBcSslXTl1DxlXurAAqwQvywR4A4lSTo+ATQjBTXiWsEqMrHhLhBqR5Z TJtMnO/88t8vHhuChXA7csCum8b8H8vuKAdpKujo+lGTsvOQQwrC73mG2/x+/MlZKHD7 Sf+Nru1dIaWe4WD+e5ZQsHzGukxsMs9IAl5EYiwSsNiV5m+tzSA3+o7DFVh9Saz5FmYy 9SKMj0Ob3LuiSHOM+Gs0X17pybJC/9eZROy4uYRyxmuSimqwo2jJRsBqNDWKJVC3oBUd ZAKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=zyBbRluQ5lYnUX7KFT5ZGZlRL0DFuI68QfOqM4RCzdA=; b=Q0nEACdmLs1HApOcuZT2TPAaTeLAk+15mSfR85r3SAqlTTuCo/iLYHl4OgzQW5iy2b 1CCdQGypAFs12LTFMBF2W2W5qw7plnGCaidi7strX52xTtjX0bOe1qiM9aiCg6T8gAte 5jiYdlWp8eT8d1ScipmVhU/a81gN59aC9nMxdb4SY8wO7LrdKLoZHhSFiHA+R0g9TgTa 2lm3xvpl2Cm9CT2nP7XwmM7iTiqIOL2VWCdtVThB8wZyAQl4a6WrwzoydxQhyVt39QbE f1K6fJRpzLqyC4Tx61KQ/Tn+ichdRed6OlwF0kCP5NqBdL9n6u2pA/1pWbn+as/z7Ing sTZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gFu1qFbD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k13si9056222ejb.579.2020.07.13.10.18.54; Mon, 13 Jul 2020 10:19:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=gFu1qFbD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730000AbgGMRQY (ORCPT + 99 others); Mon, 13 Jul 2020 13:16:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbgGMRQY (ORCPT ); Mon, 13 Jul 2020 13:16:24 -0400 Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CA8DC061755; Mon, 13 Jul 2020 10:16:24 -0700 (PDT) Received: by mail-ot1-x342.google.com with SMTP id a21so10075835otq.8; Mon, 13 Jul 2020 10:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zyBbRluQ5lYnUX7KFT5ZGZlRL0DFuI68QfOqM4RCzdA=; b=gFu1qFbDmtup0YSpFIfNaHM0a48eh0Ul1xSKNTnWGxWxCcBWiJ9n6R78PekE3f8A7p JtyBKwiVNIPBHsm1iLpcnuAI0d7JLvtXpcO2cPmP2Y/1z2LNW8bn0o3s7tgh3ZFU6b2s rYAWZryk+LgjPlE7o2+DXW7bCV12FqJAwCESb5liZr9Gxj0/Tl4/+tGlQjUz/iqYICFF R+RprQ6Xn5hWYnV3XgizYrw5LtuKlYa2H3jLOaZr2I4xgAgwckrkDkpSTcemOFp085ki yPBScHeFWTT5WT96kmmb5qlPZuhyRlVOk8bHWSEAQe+f2EQyzg9XgzSPG+7m3XzozbWW OJvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zyBbRluQ5lYnUX7KFT5ZGZlRL0DFuI68QfOqM4RCzdA=; b=c+D7xGPGxS3L5Lknb+0Xz6Kfz9L1JK9hhxvgMxkg6vHrsdamLMwiEUwNzwg3Zv2P8h XgK3tLlgDASQMgp55YHX4kS7CDjZ4/KFLRV8LQieaycZzq9OLwzjzABjcC5DlQWChrp6 llrXAENAzeqxw+4hyzemobUq5JHgtNj+yzt+PKviXFGZdUcqvR25TEk8fr/vRle8R/ol ge7Uiq78VQ9ug9k/J5rw/boQNKYpOexKnqF10ilXcCBwhvnFUKKGB81WeVe3/5VPcAe/ W7OqYtZSt+a4a7p7Wae4Rq47WJiAlm/U+D1Z6yqc00a09FAd/EyvNZxBX7v3h0oV99fj pjHA== X-Gm-Message-State: AOAM5328Cx84uwL0oUNjoPBMTCMeFMBk0RtF0qy4tBU3pRMpqV25oohP ONa9yOt+A4WNWPDk+hKGcx0yCn2c X-Received: by 2002:a9d:7a4c:: with SMTP id z12mr595958otm.126.1594660583279; Mon, 13 Jul 2020 10:16:23 -0700 (PDT) Received: from localhost.localdomain (cpe-24-31-245-230.kc.res.rr.com. [24.31.245.230]) by smtp.gmail.com with ESMTPSA id a16sm2824303oid.14.2020.07.13.10.16.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 10:16:22 -0700 (PDT) Subject: Re: [RFC PATCH 02/35] ssb: Change PCIBIOS_SUCCESSFUL to 0 To: "Saheed O. Bolarinwa" , helgaas@kernel.org, Michael Buesch Cc: bjorn@helgaas.com, skhan@linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org References: <20200713122247.10985-1-refactormyself@gmail.com> <20200713122247.10985-3-refactormyself@gmail.com> From: Larry Finger Message-ID: <70e57af0-6a8c-a893-67c9-0181af16ae2b@lwfinger.net> Date: Mon, 13 Jul 2020 12:16:21 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200713122247.10985-3-refactormyself@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/20 7:22 AM, Saheed O. Bolarinwa wrote: > In reference to the PCI spec (Chapter 2), PCIBIOS* is an x86 concept. > Their scope should be limited within arch/x86. > > Change all PCIBIOS_SUCCESSFUL to 0 > > Signed-off-by: "Saheed O. Bolarinwa" Could you please tell me what difference this makes? It looks like source churn rather than a substantive change. The symbol is defined in pci.h and is used in many architures. Certainly, PCIBIOS_SUCCESSFUL indicates success even more clearly than 0 does. Why is your name inside quotes in your s-o-b? Larry