Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: toR5kVyvDSeaPz16GNmjn+07qfTDjOYYC+IiceMsuH1Ar9qMnz4Njk3bbgQhO/5vr8DWUdLfRV
 MTY6B5FW3shA==
From:   SeongJae Park <sjpark@amazon.com>
To:     Mike Rapoport <rppt@kernel.org>
CC:     SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
        "SeongJae Park" <sjpark@amazon.de>, <Jonathan.Cameron@huawei.com>,
        <aarcange@redhat.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
        <benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
        <brendanhiggins@google.com>, <cai@lca.pw>,
        <colin.king@canonical.com>, <corbet@lwn.net>, <david@redhat.com>,
        <dwmw@amazon.com>, <foersleo@amazon.de>, <irogers@google.com>,
        <jolsa@redhat.com>, <kirill@shutemov.name>, <mark.rutland@arm.com>,
        <mgorman@suse.de>, <minchan@kernel.org>, <mingo@redhat.com>,
        <namhyung@kernel.org>, <peterz@infradead.org>,
        <rdunlap@infradead.org>, <riel@surriel.com>, <rientjes@google.com>,
        <rostedt@goodmis.org>, <sblbir@amazon.com>, <shakeelb@google.com>,
        <shuah@kernel.org>, <sj38.park@gmail.com>, <snu@amazon.de>,
        <vbabka@suse.cz>, <vdavydov.dev@gmail.com>,
        <yang.shi@linux.alibaba.com>, <ying.huang@intel.com>,
        <linux-damon@amazon.com>, <linux-mm@kvack.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: Re: [PATCH v18 01/14] mm/page_ext: Export lookup_page_ext() to GPL modules
Date:   Mon, 13 Jul 2020 19:38:05 +0200
Message-ID: <20200713173805.31923-1-sjpark@amazon.com>
In-Reply-To: <20200713171909.GD707159@kernel.org> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 13 Jul 2020 20:19:09 +0300 Mike Rapoport <rppt@kernel.org> wrote:

> On Mon, Jul 13, 2020 at 02:21:43PM +0200, SeongJae Park wrote:
> > On Mon, 13 Jul 2020 15:08:42 +0300 Mike Rapoport <rppt@kernel.org> wrote:
> > 
> > > Hi,
> > > 
> > > On Mon, Jul 13, 2020 at 10:41:31AM +0200, SeongJae Park wrote:
> > > > From: SeongJae Park <sjpark@amazon.de>
> > > > 
> > > > This commit exports 'lookup_page_ext()' to GPL modules.  It will be used
> > > > by DAMON in following commit for the implementation of the region based
> > > > sampling.
> > > 
> > > Maybe I'm missing something, but why is DAMON a module?
> > 
> > I made it loadable just for easier adoption from downstream kernels.  I could
> > drop the module build support if asked.
>  
> Well, exporting core mm symbols to modules should be considred very
> carefully. 

Agreed.  I will drop the module support from the next spin.

> 
> Why lookup_page_ext() is required for DAMON? It is not used anywhere in
> this patchset.

It's indirectly used.  In the 6th patch, DAMON uses 'set_page_young()' to not
interfere with other PTE Accessed bit users.  And, 'set_page_young()' uses
'lookup_page_ext()' if !CONFIG_64BIT.  That's why I exported it.


Thanks,
SeongJae Park