Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030252AbWECQzO (ORCPT ); Wed, 3 May 2006 12:55:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030253AbWECQzN (ORCPT ); Wed, 3 May 2006 12:55:13 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:8918 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S1030252AbWECQzM (ORCPT ); Wed, 3 May 2006 12:55:12 -0400 Date: Wed, 3 May 2006 17:55:02 +0100 From: Al Viro To: Stephen Smalley Cc: Ingo Molnar , Steve Grubb , Andrew Morton , James Morris , Jon Smirl , linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 11/14] Reworked patch for labels on user space messages Message-ID: <20060503165502.GF27946@ftp.linux.org.uk> References: <9e4733910605030711p2acab747g8f2ea7fdbb95f3c4@mail.gmail.com> <20060503142802.GD27946@ftp.linux.org.uk> <1146667956.27735.73.camel@moss-spartans.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1146667956.27735.73.camel@moss-spartans.epoch.ncsc.mil> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 35 On Wed, May 03, 2006 at 10:52:36AM -0400, Stephen Smalley wrote: > On Wed, 2006-05-03 at 15:28 +0100, Al Viro wrote: > > On Wed, May 03, 2006 at 10:11:52AM -0400, Jon Smirl wrote: > > > Something seems to be wrong in selinux_get_task_sid. I am getting > > > thousands of these and can't boot the kernel. > > > > It's actually in security/selinux/hooks.c::selinux_disable() and gets > > triggered if you have selinux enabled and explicitly disable afterwards. > > Stephen Smalley had done a fix yesterday, basically adding > > selinux_enabled = 0; > > after > > selinux_disabled = 1; > > in there. selinux_get_task_sid() happens to step on that in visible way > > and nobody had caught that while this stuff was sitting in -mm ;-/ > > > > The only question I have about that patch: what would happen if we do not > > have CONFIG_SECURITY_SELINUX_BOOTPARAM? In that case selinux_enabled is > > defined to 1, so... > > Good point. Ok, take two. > > [patch 1/1] selinux: Clear selinux_enabled flag upon runtime disable. > > Clear selinux_enabled flag upon runtime disable of SELinux by userspace, > and make sure it is defined even if selinux= boot parameter support is > not enabled in configuration. > > Signed-off-by: Stephen Smalley Acked-by: Al Viro - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/