Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1308872ybh; Mon, 13 Jul 2020 15:20:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxdXvf0UidReZoKJNwQbnnFBxpRC8Vxm0aALUBY4BvOND6wbRH6FdkVKpUEPNOUVHeU5I5w X-Received: by 2002:a50:c355:: with SMTP id q21mr1482693edb.121.1594678828696; Mon, 13 Jul 2020 15:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594678828; cv=none; d=google.com; s=arc-20160816; b=P3sTQEQwtZhT3Q2aEc9Lria5OJfOMRPaFLaQkjWUJ+6FWZaD50ZLt8Ot4z7AYBz8TS XCofNM7RA0zI2S1k7bWM1nUPIKMTZjGHJr6woW/5TzdzRrLW1zxWDz5oYVGniNlO6ClX PWhlJP1RoHexqCzwgUNw/IbkAMqBdtEUsh+TBlyX4vJs7ERroW7NtATuJgdGKT4FPB+W Bcta0pvyGt12xeUWL1srYGu4QhYETUfL2Jxc+wsuZtSkXnVto69PzMJCRNlz/NM8nJuU uanaF3uULl9L8ldi5YYEdUJpoiPWc+i0cC9xFU65uuum83abSRL+Tyw+O/Q1Tc0mCWih nfLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KyzzzEfQ3Uc/t+bUav/3x8lC62pgjGuDPMIXbn4bZbw=; b=qUlLWZZXwNganstS/ErEU3L578DJSd2FSSecOMLliVhp5Is07Mtn1AJmB0O8Pkf9Ax gHwvff7qz6xYumpuu3nXR6IxTty1x8QG6wZ4fiXfp6cWPq/2gznl01PktgMOebU+R/YY fzbohZQ28cLXho6f1+dM/DdqknF2h5RH9LU2vtClEYaHWBQAuGGk/Yd+CblKwhKgrYxp 56+ICJEu4WR5ISAThlZ1XKTlayuQM79LPyblGUPULr8o3mvtD0Ay+BNogdgWES4Z3cRj 7Av7mFNjk/pZD/mv/C9GL2lhjwG5K9j/jYMnBvy7BiDhwjLR9j2dtXuJQur0GBh04Ws8 5C7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="InUYU/sU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb1si9518291ejb.565.2020.07.13.15.20.03; Mon, 13 Jul 2020 15:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="InUYU/sU"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726630AbgGMWS7 (ORCPT + 99 others); Mon, 13 Jul 2020 18:18:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgGMWRs (ORCPT ); Mon, 13 Jul 2020 18:17:48 -0400 Received: from mail-vs1-xe41.google.com (mail-vs1-xe41.google.com [IPv6:2607:f8b0:4864:20::e41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9540CC08C5DF for ; Mon, 13 Jul 2020 15:17:34 -0700 (PDT) Received: by mail-vs1-xe41.google.com with SMTP id j186so7473950vsd.10 for ; Mon, 13 Jul 2020 15:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KyzzzEfQ3Uc/t+bUav/3x8lC62pgjGuDPMIXbn4bZbw=; b=InUYU/sUXni6t/s3Y0tEzsg6QRkbF8CdHi29QeizGklCp2wPj8fVd34LQ23a0P4iuU nDGgnyMb2+gOlkblxRAG3WGfZEczi+XzLqzr3/WSm+8/OTockDZ0K70oggBRR7nwiPQZ WlrLXTDfpeFBc2CMm04EkptdN+M89zgyRIiPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KyzzzEfQ3Uc/t+bUav/3x8lC62pgjGuDPMIXbn4bZbw=; b=LNCD7sDVg6RrmXtuQ6rWAbzzyIRdLpEK+4h8eZPYqYyLZxPmDjNYxH+Vd0TiQGxTMb bDM1sQhuFMIS2z5sSbi+9r7E722lpVwm2dyENXAq3LhWm1cF07Y4wxdTTdTxcIZW9M2q M3C0aaeOsJldauksEqw8+2y8+nTUe+zg1IyuHzR9+c7wLKz13P6+KLct8d2roBAYzlO+ /s/2GusBoX6ZljQ3E1T4BQes2Q+paJ98HmZB1MSMPpIjYsTVmZkaIWtLT/XJwDfTqI/j Ltjqx5ikt5XLJThEYJBIsZBdmsKTbCAQP8zfUQINWAJWv7Lu7/cEorQVz6Pc1IYxt0W+ RUog== X-Gm-Message-State: AOAM531Ws/9Su6yoZTI7B6eFxDyyVHKd9Bg9yCxpFHJ+qDxk4VlwdogU vYJHcYrO3szIUFt0Ry2TTtm0RkbnsnM= X-Received: by 2002:a67:ce08:: with SMTP id s8mr1241749vsl.103.1594678653618; Mon, 13 Jul 2020 15:17:33 -0700 (PDT) Received: from mail-vs1-f48.google.com (mail-vs1-f48.google.com. [209.85.217.48]) by smtp.gmail.com with ESMTPSA id t67sm2208040vkd.38.2020.07.13.15.17.31 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 15:17:32 -0700 (PDT) Received: by mail-vs1-f48.google.com with SMTP id j186so7473903vsd.10 for ; Mon, 13 Jul 2020 15:17:31 -0700 (PDT) X-Received: by 2002:a67:ec0f:: with SMTP id d15mr1113618vso.121.1594678651291; Mon, 13 Jul 2020 15:17:31 -0700 (PDT) MIME-Version: 1.0 References: <1592818308-23001-1-git-send-email-mkshah@codeaurora.org> <1592818308-23001-4-git-send-email-mkshah@codeaurora.org> In-Reply-To: <1592818308-23001-4-git-send-email-mkshah@codeaurora.org> From: Doug Anderson Date: Mon, 13 Jul 2020 15:17:20 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 3/5] pinctrl: qcom: Use return value from irq_set_wake call To: Maulik Shah Cc: Bjorn Andersson , Marc Zyngier , LinusW , Stephen Boyd , Evan Green , Matthias Kaehlcke , LKML , linux-arm-msm , "open list:GPIO SUBSYSTEM" , Andy Gross , Thomas Gleixner , Jason Cooper , Rajendra Nayak , Lina Iyer , Srinivas Rao L Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > msmgpio irqchip is not using return value of irq_set_wake call. > Start using it. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Maulik Shah > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) Seems right to me. Reviewed-by: Douglas Anderson