Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "M Tamseel Shams" <m.shams@samsung.com>
To:     "'Krzysztof Kozlowski'" <krzk@kernel.org>
Cc:     <kgene@kernel.org>, <gregkh@linuxfoundation.org>,
        <jslaby@suse.com>, <linux-arm-kernel@lists.infradead.org>,
        <linux-samsung-soc@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <alim.akhtar@samsung.com>
In-Reply-To: <20200706081307.GA13025@kozik-lap>
Subject: RE: [PATCH v3] serial: samsung: Re-factors UART IRQ resource for
 various Samsung SoC
Date:   Mon, 13 Jul 2020 19:33:42 +0530
Message-ID: <007301d6591e$74a4b2d0$5dee1870$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJ+HCpw/jCCJmkguxc6VRyn8Om3HQIWvFo9AbDj3oanl8co8A==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20200704142658epcas5p254ae909fedb07dda58cece5d6d5252b4@epcas5p2.samsung.com>
        <20200704140646.66528-1-m.shams@samsung.com>
        <20200706081307.GA13025@kozik-lap>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > In few older Samsung SoCs like s3c2410, s3c2412 and s3c2440, UART IP
> > is having 2 interrupt lines.
> > However, in other SoCs like s3c6400, s5pv210, exynos5433, and
> > exynos4210 UART is having only 1 interrupt line. Due to this,
> > =22platform_get_irq(platdev, 1)=22
> > call in the driver gives the following warning:
> > =22IRQ index 1 not found=22 on recent platforms.
> >
> > This patch re-factors the IRQ resources handling for each platform and
> > hence fixing the above warnings seen on some platforms.
> >
> > Signed-off-by: Tamseel Shams <m.shams=40samsung.com>
> > ---
> > Removed the logic of irq_cnt and directly using
> > s3c24xx_serial_has_interrupt_mask() to check for number of interrupt
> > lines.
> >
> >  drivers/tty/serial/samsung_tty.c =7C 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/tty/serial/samsung_tty.c
> > b/drivers/tty/serial/samsung_tty.c
> > index 6ef614d8648c..8a955f3d8975 100644
> > --- a/drivers/tty/serial/samsung_tty.c
> > +++ b/drivers/tty/serial/samsung_tty.c
> > =40=40 -1908,10 +1908,13 =40=40 static int s3c24xx_serial_init_port(str=
uct
> s3c24xx_uart_port *ourport,
> >  	else =7B
> >  		port->irq =3D ret;
> >  		ourport->rx_irq =3D ret;
> > -		ourport->tx_irq =3D ret + 1;
> > +		if (s3c24xx_serial_has_interrupt_mask(port))
> > +			ourport->tx_irq =3D ret;
>=20
> Hi,
>=20
> I don't understand: Why do you assign here the same interrupt as RX?
>=20
> Best regards,
> Krzysztof
>=20
Hi Krzysztof,
I was assigning the same interrupt to Tx and Rx for UART, which have one in=
terrupt line,=20
but ourport->tx_irq is never used for those UART's. So, leaving it as it wa=
s.
The change now is using platform_get_irq_optional () instead of platform_ge=
t_irq ()
to avoid false-positive error.

Thanks & Regards,
Tamseel