Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1454749ybh; Mon, 13 Jul 2020 20:38:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeHkj68kKzLHyZcTUSo4ufJQdeVToQXfzxHPADgYg5vD57K1PaMH172rSlrjgaOwPbLzWs X-Received: by 2002:a50:fe0c:: with SMTP id f12mr2416215edt.360.1594697935118; Mon, 13 Jul 2020 20:38:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594697935; cv=none; d=google.com; s=arc-20160816; b=nT33e4igrvDH3aqqcFtpmbIYdNpajHUIyv6rBGhZiaBUC1QMPFMSmJ4sCq1Fsz66y0 HldiZ7MEa+xY3aOYq7FYGV1qVFkPGwKj0+UwQ3L8XQZlEpUBN0L5MJ5LHftEYIhD7kuw Implhzdv6KZoEKdcOeg8k/onZ9xKSoWCnPJTUOzwGl/1js02AEalJ9k1/noQ49q5tzsE MBExYLE9Fv/IoW7G8V7V4OmVp+Y4LeVgMLraD9/jRkzkJagQbg3DuiwveAeaTOR5izEk eZXUs8VlFhJ+3zTCoVwW5ujBegTkpNPOfoCc1hA62FmSXRlBfFOxrAlSwC9iCiBE3bw5 XIZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=Zpl3uAk1cyPC0bXhe+o2OJ9Nd/1R0pm/+fLCm+9cuOI=; b=dt1hYh5eP2QmiNKsvjFBuPEzRTpstsGlDdVN6N90iohn/wv1gFcvjNWav7T+cPRfcV gr46+hlJSVo34MN0dPfmP9O9U9jezgKxBcFiI8b/f1qGu125bMM+SjU2puPLEi7XbES8 QFgnvtwnR20LEZ4HtROVnCjqz0fmnSjB2+e6fscYBG7LhqwUbR0S0N0FUmlEZOn5vZqr 8jbkWV5wgRnel7qKk+VKDa3FmeTt5AkkuS0Y3N9MmpWhDvmKHgRxxZSAOV5/Xzxq6rjP Ddo0+tF8hYv0AccTU+qaTEieGF3Cff8YlNp4QuJd4Oh1+/hL3o0ca02e0NnWhUAUpcZU LS9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y2si10976393edp.396.2020.07.13.20.38.30; Mon, 13 Jul 2020 20:38:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbgGNDiS (ORCPT + 99 others); Mon, 13 Jul 2020 23:38:18 -0400 Received: from mail-pj1-f66.google.com ([209.85.216.66]:38988 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726510AbgGNDiR (ORCPT ); Mon, 13 Jul 2020 23:38:17 -0400 Received: by mail-pj1-f66.google.com with SMTP id b92so877225pjc.4; Mon, 13 Jul 2020 20:38:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Zpl3uAk1cyPC0bXhe+o2OJ9Nd/1R0pm/+fLCm+9cuOI=; b=YWdzRfjQ8qR2Vq/ZmVkg9qdJJGm+0yj2zPaU/lTXFPuQS3fVwGAHPIJXgvDP79/N6y ODBmp6ADJKj2fdzWgTH87H1W+dmGNQgKTtHbBq1tngB6k9fjmTtedvZ5jAydF1OWhp0N Fi0T+On01+Zbzfmi0Lkvf6rK9YgaqZDy/5/J5/k4VxfQpR0+oIZB6PLj0GinwkHmv876 LGnNDc16HdGCYb9FhwjVM35Kj8pZiWe/wXruqgIWqmEOTxB/xulLKOj7O2cjBtU3LFyg +4+wAp8GIkHbRmTP+bSYpneDwdF58z3bolH9dSEU+2dRkzDt2kf5Oddp4lQOVcWBz3vf TiQw== X-Gm-Message-State: AOAM531Ve6xge6EjEbJfxmySV2pHhWYy/TO0tZGpNDOcd3795C9o9drv /LDKgGGqVVUCT/+WiHUAm4uxBGar X-Received: by 2002:a17:90a:3602:: with SMTP id s2mr2376991pjb.161.1594697896437; Mon, 13 Jul 2020 20:38:16 -0700 (PDT) Received: from [192.168.50.147] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id p12sm802196pjz.44.2020.07.13.20.38.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 20:38:15 -0700 (PDT) Subject: Re: [PATCH v2 1/4] scsi: ufs: Add checks before setting clk-gating states To: Can Guo , asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com Cc: Alim Akhtar , Avri Altman , "James E.J. Bottomley" , "Martin K. Petersen" , Stanley Chu , Bean Huo , open list References: <1594693693-22466-1-git-send-email-cang@codeaurora.org> <1594693693-22466-2-git-send-email-cang@codeaurora.org> From: Bart Van Assche Autocrypt: addr=bvanassche@acm.org; prefer-encrypt=mutual; keydata= mQENBFSOu4oBCADcRWxVUvkkvRmmwTwIjIJvZOu6wNm+dz5AF4z0FHW2KNZL3oheO3P8UZWr LQOrCfRcK8e/sIs2Y2D3Lg/SL7qqbMehGEYcJptu6mKkywBfoYbtBkVoJ/jQsi2H0vBiiCOy fmxMHIPcYxaJdXxrOG2UO4B60Y/BzE6OrPDT44w4cZA9DH5xialliWU447Bts8TJNa3lZKS1 AvW1ZklbvJfAJJAwzDih35LxU2fcWbmhPa7EO2DCv/LM1B10GBB/oQB5kvlq4aA2PSIWkqz4 3SI5kCPSsygD6wKnbRsvNn2mIACva6VHdm62A7xel5dJRfpQjXj2snd1F/YNoNc66UUTABEB AAG0JEJhcnQgVmFuIEFzc2NoZSA8YnZhbmFzc2NoZUBhY20ub3JnPokBOQQTAQIAIwUCVI67 igIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEHFcPTXFzhAJ8QkH/1AdXblKL65M Y1Zk1bYKnkAb4a98LxCPm/pJBilvci6boefwlBDZ2NZuuYWYgyrehMB5H+q+Kq4P0IBbTqTa jTPAANn62A6jwJ0FnCn6YaM9TZQjM1F7LoDX3v+oAkaoXuq0dQ4hnxQNu792bi6QyVdZUvKc macVFVgfK9n04mL7RzjO3f+X4midKt/s+G+IPr4DGlrq+WH27eDbpUR3aYRk8EgbgGKvQFdD CEBFJi+5ZKOArmJVBSk21RHDpqyz6Vit3rjep7c1SN8s7NhVi9cjkKmMDM7KYhXkWc10lKx2 RTkFI30rkDm4U+JpdAd2+tP3tjGf9AyGGinpzE2XY1K5AQ0EVI67igEIAKiSyd0nECrgz+H5 PcFDGYQpGDMTl8MOPCKw/F3diXPuj2eql4xSbAdbUCJzk2ETif5s3twT2ER8cUTEVOaCEUY3 eOiaFgQ+nGLx4BXqqGewikPJCe+UBjFnH1m2/IFn4T9jPZkV8xlkKmDUqMK5EV9n3eQLkn5g lco+FepTtmbkSCCjd91EfThVbNYpVQ5ZjdBCXN66CKyJDMJ85HVr5rmXG/nqriTh6cv1l1Js T7AFvvPjUPknS6d+BETMhTkbGzoyS+sywEsQAgA+BMCxBH4LvUmHYhpS+W6CiZ3ZMxjO8Hgc ++w1mLeRUvda3i4/U8wDT3SWuHcB3DWlcppECLkAEQEAAYkBHwQYAQIACQUCVI67igIbDAAK CRBxXD01xc4QCZ4dB/0QrnEasxjM0PGeXK5hcZMT9Eo998alUfn5XU0RQDYdwp6/kMEXMdmT oH0F0xB3SQ8WVSXA9rrc4EBvZruWQ+5/zjVrhhfUAx12CzL4oQ9Ro2k45daYaonKTANYG22y //x8dLe2Fv1By4SKGhmzwH87uXxbTJAUxiWIi1np0z3/RDnoVyfmfbbL1DY7zf2hYXLLzsJR mSsED/1nlJ9Oq5fALdNEPgDyPUerqHxcmIub+pF0AzJoYHK5punqpqfGmqPbjxrJLPJfHVKy goMj5DlBMoYqEgpbwdUYkH6QdizJJCur4icy8GUNbisFYABeoJ91pnD4IGei3MTdvINSZI5e Message-ID: <31ef233b-2562-2f61-d899-587092b5c033@acm.org> Date: Mon, 13 Jul 2020 20:38:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <1594693693-22466-2-git-send-email-cang@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-13 19:28, Can Guo wrote: > @@ -2538,7 +2540,8 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) > err = SCSI_MLQUEUE_HOST_BUSY; > goto out; > } > - WARN_ON(hba->clk_gating.state != CLKS_ON); > + if (ufshcd_is_clkgating_allowed(hba)) > + WARN_ON(hba->clk_gating.state != CLKS_ON); A minor comment: has it been considered to change this into the following? WARN_ON(ufshcd_is_clkgating_allowed(hba) && hba->clk_gating.state != CLKS_ON); Thanks, Bart.