Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6IKo3vnKIbd4dde/+ZQw0l4ZpIrPJUlVJN1yOTWoOhN8jC5/l9X8N/fHMAGp3ipBp079nMsCKG
 l7ZhvLPU5IkA==
IronPort-SDR: 3q0YHQnxsGP2UJIF2mejmJWN0IYuu5eZtpSM4v9rhMJzcLqSwQlVVypGc4efSwSsshzkvYZvkL
 msI6dyceyvqg==
Reply-To: vadivel.muruganx.ramuthevar@linux.intel.com
Subject: Re: [PATCH v5 1/2] dt-bindings: phy: Add USB PHY support for Intel
 LGM SoC
To:     Rob Herring <robh@kernel.org>
Cc:     kishon@ti.com, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, p.zabel@pengutronix.de,
        gregkh@linuxfoundation.org, andriy.shevchenko@intel.com,
        balbi@kernel.org, cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        yin1.li@intel.com
References: <20200713085453.7353-1-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200713085453.7353-2-vadivel.muruganx.ramuthevar@linux.intel.com>
 <20200713150818.GB184301@bogus>
From:   "Ramuthevar, Vadivel MuruganX" 
        <vadivel.muruganx.ramuthevar@linux.intel.com>
Message-ID: <46bd1140-bf8f-757f-399a-4ed05e93d867@linux.intel.com>
Date:   Tue, 14 Jul 2020 11:53:06 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200713150818.GB184301@bogus>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rob,

On 13/7/2020 11:08 pm, Rob Herring wrote:
> On Mon, Jul 13, 2020 at 04:54:52PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>
>> Add the dt-schema to support USB PHY on Intel LGM SoC
>>
>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>>   .../devicetree/bindings/phy/intel,lgm-usb-phy.yaml | 53 ++++++++++++++++++++++
>>   1 file changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml b/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>> new file mode 100644
>> index 000000000000..0fc76cd23774
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/intel,lgm-usb-phy.yaml
>> @@ -0,0 +1,53 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/usb/intel,lgm-usb-phy.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel LGM USB PHY Device Tree Bindings
>> +
>> +maintainers:
>> +  - Vadivel Murugan Ramuthevar <vadivel.muruganx.ramuthevar@linux.intel.com>
>> +
>> +properties:
>> +  compatible:
>> +    const: intel,lgm-usb-phy
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  resets:
>> +    items:
>> +      - description: USB PHY and Host controller reset
>> +      - description: APB BUS reset
>> +      - description: General Hardware reset
>> +
>> +  reset-names:
>> +    items:
>> +      - const: phy
>> +      - const: apb
>> +      - const: phy31
>> +
>> +required:
>> +  - compatible
>> +  - clocks
>> +  - reg
>> +  - resets
>> +  - reset-names
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    usb_phy: usb_phy@e7e00000 {
> 
> usb-phy@...
Noted, will updated.
Thanks!
> 
>> +        compatible = "intel,lgm-usb-phy";
>> +        reg = <0xe7e00000 0x10000>;
>> +        clocks = <&cgu0 153>;
>> +        resets = <&rcu 0x70 0x24>,
>> +                 <&rcu 0x70 0x26>,
>> +                 <&rcu 0x70 0x28>;
>> +        reset-names = "phy", "apb", "phy31";
>> +    };
>> -- 
>> 2.11.0
>>