Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 12:13:23 +0530
From:   Suraj Upadhyay <usuraj35@gmail.com>
To:     Benjamin Poirier <benjamin.poirier@gmail.com>,
        maarten.lankhorst@linux.intel.com, mripard@kernel.org,
        tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch
Cc:     linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.
Message-ID: <20200714064323.GB12651@blackclown>
References: <cover.1594642213.git.usuraj35@gmail.com>
 <1bb472c5595d832221fd142dddb68907feeeecbe.1594642213.git.usuraj35@gmail.com>
 <20200714054137.GA49448@f3>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="PmA2V3Z32TCmWXqI"
Content-Disposition: inline
In-Reply-To: <20200714054137.GA49448@f3>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--PmA2V3Z32TCmWXqI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 14, 2020 at 02:41:37PM +0900, Benjamin Poirier wrote:
> On 2020-07-13 17:50 +0530, Suraj Upadhyay wrote:
> > Simplify while loops into more readable and simple for loops.
> >=20
> > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> > ---
> [...]
> > @@ -1824,7 +1821,7 @@ static struct sk_buff *ql_build_rx_skb(struct ql_=
adapter *qdev,
> >  			sbq_desc->p.skb =3D NULL;
> >  			skb_reserve(skb, NET_IP_ALIGN);
> >  		}
> > -		do {
> > +		for (; length > 0; length -=3D size, i++) {
> >  			lbq_desc =3D ql_get_curr_lchunk(qdev, rx_ring);
> >  			size =3D min(length, qdev->lbq_buf_size);
> > =20
> > @@ -1839,7 +1836,7 @@ static struct sk_buff *ql_build_rx_skb(struct ql_=
adapter *qdev,
> >  			skb->truesize +=3D size;
> >  			length -=3D size;
> >  			i++;
> > -		} while (length > 0);
> > +		}
>=20
> Looks like length and i modification should be removed from here. But in
> this instance, maybe the original was better anyways.
=20
Thanks for pointing that out. It nearly slipped.

> Agreed with Dan. At least some of those loops can be converted to "count
> up" loops for a more familiar appearance.

I mostly tried to convert the do-while loops, which I think are't that
obvious than while and for loops.

Thanks,

Suraj Upadhyay.


--PmA2V3Z32TCmWXqI
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE7AbCa0kOsMJ4cx0j+gRsbIfe744FAl8NVAoACgkQ+gRsbIfe
747gZhAAqmjqDCHmzSP1HenEF63cKPYyve1oHdtZQYylYRaN2L9DFakZyAKZOAzG
BuQss5guy5Na3tvPENwNQa/WUcBNkBsmoYdbdiaMfdCIIiCCaS738NCe3zX+iJDn
XYjNutWTL1bPWgGUpODUfMbEB64FwZQO+fF2tXIF2EE+XbFHu9UXg4yvAmVOAuZ4
9TO+NYxOJZ4er23xW2QHw9Q2KN9L72h13BLRObkMqw/c0cVI1Q/Rs54/RpqnYC/H
UYRgNOu5Y+H5B//QoWYdzRPJRyp0z/ITjWwSqcJ20nbN3oBP20QK4iyAjrl2PMaD
ht6z5JjIAsS1hgLaMIKxEtnR23SzHrzWQyH6l6wbMIKLoWTxByZ4eZfivTtZCIqW
1fDv8jzsVfTY+RF18LaLcAAllncRYTwiEMA0wfdYQnDO7UcpoikOfTIyrZuizoDu
AHX5UEza5v4T9yJKa1GnpAQlrXtN3Vle+/otwU3jAchin7OaAPa/J0AbWxRqjBZY
35jZ3nYFEj/uT3EDgOCHtHKuiAKbIDgTGHdMs/fmaeaQ9b7QcayRs7p97a3m/68f
PTFfDce+NHxdpVS++epyhdCUdYY+RluazeTZTwOHHcMj5EgUkYcB9KXl/QBJLvR4
gcwAKr1h+FAzBq23aC+psURXYpznTvTG2u/vuTwjpuQrB8nPBS4=
=St0d
-----END PGP SIGNATURE-----

--PmA2V3Z32TCmWXqI--