Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1533696ybh; Mon, 13 Jul 2020 23:45:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxr0F/rFUfb3wB+WehSxsGsgsee4MFoArAwwsQ28cfi3/Rhha4+EOCEezR0ngQGWfgAA+3i X-Received: by 2002:a17:906:1491:: with SMTP id x17mr3277401ejc.416.1594709137887; Mon, 13 Jul 2020 23:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594709137; cv=none; d=google.com; s=arc-20160816; b=pb5932SaUMdaI7KfyZtK1s4pvZnvuChXD5hdm/HemzHp0JXnzyUAnzAJc0IAQ5KOBU AJOGvlvRkYrEDsIRj7BkOcDXZKbb+29u/RFJc3lUsjJQ0bxnqE9vekHFFChGSG3AxWmN 8Y2l2RhzP9A0zEkYGZ9F6m6rRtVC1lfCYzf5H3js6UCZ/QNSv2+sdqSQlJxn3W8jXfKI lJ8MGQVqh4YxAZ0vZ88j6yONiUfKQK9gF6FGVWguDNMlmx5j/8tCYHq24Zohy7zhkIzK j1UiKfKntDTDBLJNC4W4HwhLt8txKXMUMaBK/MopC7FF/LCdSFZecsto8mDuxCqE91Wi n9qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature; bh=pTlCj4W93luqw8r/dkTErk3GwatPkrRGGOYE/RnXtI0=; b=EeVi8WZ6NR/u8eqxekYLAORfp+dTX9rmmLhnYqQ9nZwUxynrEGs6ViURiztBMQX1/C fqAPObIjT7FLVmu0tP1huvXrEl72xxdiRy9bdoWAgIOuXk/pp8sknIG5Mi8pf+vwGn/+ WMiVwhXkNOlCoE9izsgJ5tqGk1CKpkzJG0gQg6yJsTxd6Qo6H/DZbqapbQY4xaMJepP5 bpLvsgd2J/vCSPz96PWWkXgi3Yl0wobEbBZ/ASYcM1jXA3qJrtxkH0RLHW+Vj5SAwYzX FIidNT85heTLU3o46TerqOXFk7P3l7ubgJw5LGsbWwtP/zZelMMSGP4bduUp/BD8Bzj+ Ir0g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=bN8EsUsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t1si9640440ejd.639.2020.07.13.23.45.14; Mon, 13 Jul 2020 23:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=bN8EsUsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726624AbgGNGpK (ORCPT + 99 others); Tue, 14 Jul 2020 02:45:10 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:59597 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725945AbgGNGpJ (ORCPT ); Tue, 14 Jul 2020 02:45:09 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4B5WGp4HPBz9s1x; Tue, 14 Jul 2020 16:45:06 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1594709107; bh=ClduEeAgs47lVi4Z75/vHJ8zjThpPjpSsYlX2EXPZ7E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bN8EsUsxELG1u7TALvBxLWL2r85/raNsB6NeSDJwP8CbQy/fxXZlXQdvSTYv2KxbH fmFDt0FmRdU/4vwViuqWGpJCib+mE9RWE3u7CnjwUm570RQiIlpPML2K2emLWNE3JI XkV2SN50Xwvh62h1qLywY8UKFr6Ot6S+SUAIs5IwBYCbV98Kg5QufuGrvfGgyjgZRD 5DZIBtAa+HjwgA8IJYzALpbyljS3wWqmBb+ZBtsx7BE5jfxT0NvPHSR/ZtSexNs3JF dONbgqHyBkoyQLoyrS1BuMAUJRkh+t2n2mId3vEXVonwcZeOz1TzXdYhjRMt+6BUuG hJw8U06OUu7rQ== Date: Tue, 14 Jul 2020 16:45:04 +1000 From: Stephen Rothwell To: dillon.minfei@gmail.com Cc: bcousson@baylibre.com, tony@atomide.com, robh+dt@kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] Fix dcan driver probe failed on am437x platform Message-ID: <20200714164504.10b23697@canb.auug.org.au> In-Reply-To: <1594708507-6794-2-git-send-email-dillon.minfei@gmail.com> References: <1594708507-6794-1-git-send-email-dillon.minfei@gmail.com> <1594708507-6794-2-git-send-email-dillon.minfei@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/+.0IClS8DjJjchbmw_qi_zA"; protocol="application/pgp-signature"; micalg=pgp-sha256 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/+.0IClS8DjJjchbmw_qi_zA Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Dillon, > Hi Stephen, >=20 > This changes correct commit messages based on your reviewing. > make Fixes tags to oneline. > make all commit message tags at the end of commit message > make Fixes tags before Signed-off-by line. > add probe failed log to commit message. Thanks for persisting. It looks good to me, now. --=20 Cheers, Stephen Rothwell --Sig_/+.0IClS8DjJjchbmw_qi_zA Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAl8NVHAACgkQAVBC80lX 0GyuHAgAmwBoMVZJJ41XqErZe0fvVMe9O7xJmHSy+4TlJlzE9R+Aiw3fgWsmzA82 UoVQZo708iuMwvsbnFl56rq8jJipnsgVl4Ajy4qPbtFLZ5eW8aa3ZmiA3DMhmVzi WXY18QLsb+vdvIi0+CjGu88dOR3+nweWGcsAEN3PQroHFf7Y3VQPCNqEdCd/wf2H xGt4wyz1YpWOeAEYq89wm45WgnnfjxJ2aUEpTABGlp1NaGoJViMIBFdNgzbCf8li FDhLuj6Pjgzw7X9Pn9OduA+prLrTCd0Y2lf89moTfFLgWbCY3RSdJeDGEx8AyCzj TcBnhcCOVlGMSmO6AqTpvNfHxhHmhw== =mxjk -----END PGP SIGNATURE----- --Sig_/+.0IClS8DjJjchbmw_qi_zA--