Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1535329ybh; Mon, 13 Jul 2020 23:49:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnk6PXtL0tzXWdoxT7sWfRgGQQloqsPy4l66ZAEBCbgYpHpl+lYurAfth40/Y/N6TDLVQX X-Received: by 2002:a50:931e:: with SMTP id m30mr3090561eda.341.1594709379082; Mon, 13 Jul 2020 23:49:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594709379; cv=none; d=google.com; s=arc-20160816; b=kut4wmMSn8rN0aLRUOJwQSUuMIfB4wU5QHWxnsyoqp57v+NHZt+Tg6qCYpOnt+xibA U9axCTuIpFREUAgr1Jas86j2kdpX9HPbPXxlmWyZz2iyEzpcgVfDugQ4YlZOt50RgwSD QNXPYR+y9ycvDk4n56NagB0sUhM+Lf7XgrvXaLwPhtnencJg9AJegN7IYOh9e6sWa7Y7 ENrQCVKkEgZL75fI4i8SQmmdiudtSiOpMjde0DeQCuuBowKD3cgCQBiy17JvfLwDefo4 FAnMt1WJBlY/TwHr4hT9ZWcmS3ZVUUFZXP/84UROQj8pE3mBtCyC0owBSeP7WnHL7dk8 DZ4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=UUJVTXz/56oT2q3pLXpuWbAhAgG22wQrNgm2aVWNAg4=; b=guQqHsT/As8Uh33NMKqhFCSaDUJIpf0R9eQiuS0BLw33eZlmPCtwWrNCJnY0X3Ua15 m3uynmwkaoXGbRoy+iqf2MBDE/ij9Y6K/snoyw9axpWe/GPx3koCKitCt0pe7pY2WTGj VYa1IsZsN8Js/3lrK+VJEvBdEV6NzhjCvWthgfQxwE9CsFkXkViv2Dd37/6MCPZX18L1 oO0BR7SJGUPdu9GxWOsN1e8myb1Y9nuWy8PjVRRpwGAKpOQCTmSVwnBDwyNN/aUYImUp 0jqvrZoF8iHmaJndFK+ik1ODMvpe5T7+UCUaWr40tZmpGU8cYioxfgSBC1P1XrppE/+7 3g5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Wbwc3mji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a24si9886685ejk.208.2020.07.13.23.49.16; Mon, 13 Jul 2020 23:49:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Wbwc3mji; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726836AbgGNGsl (ORCPT + 99 others); Tue, 14 Jul 2020 02:48:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgGNGsl (ORCPT ); Tue, 14 Jul 2020 02:48:41 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF07C061755; Mon, 13 Jul 2020 23:48:41 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id gc9so1122530pjb.2; Mon, 13 Jul 2020 23:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UUJVTXz/56oT2q3pLXpuWbAhAgG22wQrNgm2aVWNAg4=; b=Wbwc3mji7S8mK4kfW4JXLLCGBodiz1Ue6tVZp7/uQoDXN8dE7bR0+Xb2k/Hnzm2wjX owT/8cOGXoKZMHUlftNK5L3ioFR5HSWyQUEM6nfaw8D8i+y2TEN6oTnMFGrhi6vi4oxO rolKYBJREAMNfXqwAsW4iQLrnO68s+zXyKtacmq5M4WW+224+PL1qgdnkQ3iYPmeJjw9 p094r6RCrMTblhZgXjp19gkv59mIv4fOJNRk9hUs7JoKGVLI/LhgWceqQMcfHFz21fCh APx9U+JH1fsXJ5uSyuHj4ZqGS8/pJY6+oX/T4/OMS5vOeOUjbsv3vT3vU/qUwKJfsXMA +AfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=UUJVTXz/56oT2q3pLXpuWbAhAgG22wQrNgm2aVWNAg4=; b=AzfkhjiExhKQV9XEsIBXWM6IyhJ6dUVyXIUHsQvmMEOuy9Z0cBKUFqhmTUHzyvJWeR NjpcADiMOYkDC6BE+rQuoIoEDN0KQZUfH6P8dz4IiP74XSAmFomTKBbiuMu7UIHs+45V dALGtHcHm1ZZH132wj5xuqWpRBoU/Bi65DDCDPUNLSerYJVnNBoBbhbbw/YYqwaM2m4N J0V/8tJ9g5e8izGT48Ndi7T2GESwj6h7bfZN4J6tEAyIBRh/hiz5X1gMcq2eVUUR5euy VQr+KgexQKnZzd3rXLVQ8liNAqjYqeH4mZdZEAp5/LMWn6ZJVaQpgUJ0LUxXOjv/Gncy kCEQ== X-Gm-Message-State: AOAM5313JCHeQB4DrI9j202QgNMX0Zq8n6wH97TqrxEduGj3xxnVO++X xv2BDdzWooIKSai2hXernkGGby5b2NI= X-Received: by 2002:a17:902:8c84:: with SMTP id t4mr2658000plo.315.1594709320384; Mon, 13 Jul 2020 23:48:40 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m1sm1416971pjy.0.2020.07.13.23.48.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 23:48:39 -0700 (PDT) Subject: Re: [PATCH 1/2] usb: typec: Comment correction for typec_partner_register_altmode To: Kyle Tso , heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200714033453.4044482-1-kyletso@google.com> <20200714033453.4044482-2-kyletso@google.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: <2e840825-f73c-87b7-33d2-9f103a507a80@roeck-us.net> Date: Mon, 13 Jul 2020 23:48:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200714033453.4044482-2-kyletso@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/20 8:34 PM, Kyle Tso wrote: > typec_register_altmode returns ERR_PTR on failure. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/class.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c > index c9234748537a..02655694f200 100644 > --- a/drivers/usb/typec/class.c > +++ b/drivers/usb/typec/class.c > @@ -580,7 +580,7 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity); > * SVID listed in response to Discover Modes command need to be listed in an > * array in @desc. > * > - * Returns handle to the alternate mode on success or NULL on failure. > + * Returns handle to the alternate mode on success or ERR_PTR on failure. > */ > struct typec_altmode * > typec_partner_register_altmode(struct typec_partner *partner, >