Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1535789ybh; Mon, 13 Jul 2020 23:50:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzisdykjTKt0zy+0/EzU+X0QJNeemUHjeOFiFUQUcDA1x0c2pzL5O3roAL31R0dXvxnAfIt X-Received: by 2002:a50:fa07:: with SMTP id b7mr2954659edq.298.1594709448083; Mon, 13 Jul 2020 23:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594709448; cv=none; d=google.com; s=arc-20160816; b=JanmuhirkwyHyU7OX0hgFFz3hsDI7IETo+QmZ+H5LAp45x/NRLOs0DRI8LTVxvjScv WVH6iT80NP3ZqDWhCipLgOpQVFfY7Zn4lac2p9bECsBQq7Wo59uetNsSUYMT++tKQXFu 6oSEGS+H7UyDWav/51QuZqYpGl0ebwGUr6Q97DCr9Mi4y4TFHmG2MhXC5C1PxAOe5JRG zPH8Xnz+TJf53fVUGxSK7khIRlObxUBsIiMLZqkPc3BztpLCqy2VFTp6AULLsImHQJC+ Z7bcklAZk0EIMPNlwn++sJVjXOv3uWT4TaAiYqMuuESP+ggxlNHBj6F1VygBRLESt9gA Cy2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=B4HVZHNcjx6g1V3CdNcyIWl1DLOBHNUUw7H1my3bsuY=; b=TOB9PrlTWdrfegUE6PLM0f6xADoqkjANS7cuJRSuVpJk09Vj226g8P13nm4g54P5zY 7gWmo5jk+pHgQVR53aZbUxThVvqRiF09R5cZD8eQ59jpdkl1TXgojTYVT9bR6Nyjeov8 8FBDy3Me5TFFfCZ5Mxkjzn3u0HiQzShrM3HJfso15LNtK5Ue7y7k2Ly1gmU7zWeScEJg OiBoqcDUaxTjTUBrAPRwjWLls+s9hx/pGELgVKTVHgociyMA8AP8nGZyRLZ3rdrS/tC9 LhYhl7SpiR9jrDyLi6vA1H+y4sWxZC1wBXNmpone/XHZxyrV9/TogSOuGzZjjyDk95Pd MXOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NUH3Yv4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s7si9980544edr.284.2020.07.13.23.50.25; Mon, 13 Jul 2020 23:50:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=NUH3Yv4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbgGNGtK (ORCPT + 99 others); Tue, 14 Jul 2020 02:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbgGNGtJ (ORCPT ); Tue, 14 Jul 2020 02:49:09 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46071C061755; Mon, 13 Jul 2020 23:49:09 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id j19so7164040pgm.11; Mon, 13 Jul 2020 23:49:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=B4HVZHNcjx6g1V3CdNcyIWl1DLOBHNUUw7H1my3bsuY=; b=NUH3Yv4LrYUBQGDKUdaXJ5f190dIR21S5yTkmhNKULG4fMtWnUFt2258Rk8L7SxBFh kv4ZWKkSDrPm7xGiBraLBql0Z1cjBEHGDLaVPbGeCEbMqfIQst7Yhmg/SjpXzWwURG/j 8oBlVh4C9FvwC/8LuzPogButXVEVieSS03MFrMzxWygP7fWhD+zbmIhOHLlsk06/h9Ux s/MC/3XCfr4GJZk2n1e5VidQr8qKnZsqkbnE4k7Qf4w37oeTEyutl95S8kJcLPExILRW xFzQBAejJcVGc7e0QhS0uNgx9Qsd59cLFTpRPOpNIWZJxrPfpfv+q9WkvDMQ/HeJFkgP g0Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=B4HVZHNcjx6g1V3CdNcyIWl1DLOBHNUUw7H1my3bsuY=; b=QHtl5jI0hb3CUpv3h2MDrOffw2tmyus5Bgr5cleaVeey3CeIFgNql8JambZ+vD1Ulh YLRSNki5ZCRZRsQDa0GwxcI9pfgjmd7y059m9KOXQIvAFIpPYczQ9GgSlU7c3PXUjVh8 vkoNofukqDNNLdHZZZuszGlkeVwmmu6TxluRpfrHfF0NnmCi1k9ZR0mGtQ8lBgWK1O0m fXBAhy2fmVoDWO7cWaxmuyLZDVmwfwVbAnGqp2xQTcUxriJc2JB2nO0PdWRlOmkVWHZG lCvLI2o78KqAm0+MJGlOD/HzeIvCVZU/8o73PuxagMRcWBIC7BShQ1RIvomuCMtNGrGp wFHg== X-Gm-Message-State: AOAM533Yc+u2t3Mf7u4a/HoRdFLw85llPaptwLjfLNKRw100WjqwDkd4 2O3aAlOOjV8ahHYXA3eTeoHzFQ9kNOA= X-Received: by 2002:a65:5502:: with SMTP id f2mr2206767pgr.375.1594709347831; Mon, 13 Jul 2020 23:49:07 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id f2sm16677135pfb.184.2020.07.13.23.49.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2020 23:49:07 -0700 (PDT) Subject: Re: [PATCH 2/2] usb: typec: tcpm: Error handling for tcpm_register_partner_altmodes To: Kyle Tso , heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: badhri@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200714033453.4044482-1-kyletso@google.com> <20200714033453.4044482-3-kyletso@google.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Mon, 13 Jul 2020 23:49:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200714033453.4044482-3-kyletso@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/13/20 8:34 PM, Kyle Tso wrote: > typec_partner_register_altmode returns ERR_PTR. Reset the pointer > altmode to NULL on failure. > > Signed-off-by: Kyle Tso Reviewed-by: Guenter Roeck > --- > drivers/usb/typec/tcpm/tcpm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c > index 82b19ebd7838..a6d4b03ec250 100644 > --- a/drivers/usb/typec/tcpm/tcpm.c > +++ b/drivers/usb/typec/tcpm/tcpm.c > @@ -1061,9 +1061,11 @@ static void tcpm_register_partner_altmodes(struct tcpm_port *port) > for (i = 0; i < modep->altmodes; i++) { > altmode = typec_partner_register_altmode(port->partner, > &modep->altmode_desc[i]); > - if (!altmode) > + if (IS_ERR(altmode)) { > tcpm_log(port, "Failed to register partner SVID 0x%04x", > modep->altmode_desc[i].svid); > + altmode = NULL; > + } > port->partner_altmode[i] = altmode; > } > } >