Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1541947ybh; Tue, 14 Jul 2020 00:04:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3dTWobNhV6Wxtv4b/HUxbOSaTlLhnVjm8Kx4jPmYX/wS1OU5f6umNp43xSc6NTs9/z9tV X-Received: by 2002:a17:906:6959:: with SMTP id c25mr3106970ejs.375.1594710276199; Tue, 14 Jul 2020 00:04:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594710276; cv=none; d=google.com; s=arc-20160816; b=I+KcHS0VYuGGn1KqddesK+l0ZF+eunll8H22tEiwBhplCTOqIHzx7e6rbUhRJqV3mv VgChkd639IdvV2Wpa6EpCNIo/fM7EUrwRd6vVWZkLrVROMTrCqx9jDh1HM9+5IAckqFh XBvtCuhkUOIoJjeC8l+rp7PhcRwKR/vYhgQBVlHwbf3OmO9PKx52U60iZ6yFxm82OwDz sZggHCcfk4ZEKqnifutV7a4u2UXKmE0u5eV9RehDWhxHkDng2ruF/ZgKlaoec5RUljKr WxqKOrzL7kOmmX60OdEvBVee7PxUNuxOXzjXDnHBBNURHFO/0OHxe8XfM6wFHj99L1Mx /njQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MT7cYYrcM99DVBuXFRqZwFieQfngoQCFo5QcPTP5JIU=; b=oc7zXG6W6sAwz3AchQZWX8wgqgwNvp0/UYNuarPJelRN9sYm55dvZLklrCYl0eVNSV LqJJhPpXpYcApFtxRUof6uREkN2xPwopQctEC/2j0N8tHTinEtLyQFiXAwAuY863Lx4r /cHbxj4qLXq//13ixkN6YphkLb9NyP0FUszQ790GJwA5PETIQjaoXjKw0NLyXbS0QVxV nRMjpgIiGm29NG6qSB5T/ityZuXBVpsnIfwm2y7fa/ZlOvMifPhjxPp2oRMWM8QI3706 IHdVnhOvUrl73H+OAY89URJoDrJ/0HPdPICsU2P1Cj4WZHAXvY/SgbFi06ejxkdHIBHh HEnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UuwneiRc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q23si11833957edg.348.2020.07.14.00.04.13; Tue, 14 Jul 2020 00:04:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UuwneiRc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726698AbgGNHD0 (ORCPT + 99 others); Tue, 14 Jul 2020 03:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725788AbgGNHD0 (ORCPT ); Tue, 14 Jul 2020 03:03:26 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D47CCC061755; Tue, 14 Jul 2020 00:03:25 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id v6so16225665iob.4; Tue, 14 Jul 2020 00:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MT7cYYrcM99DVBuXFRqZwFieQfngoQCFo5QcPTP5JIU=; b=UuwneiRc0rQ4ddykmcV5x4aFSBSVHiADlOmVLt+KR1OpoPshajKUwgnvFAcpGSrxl5 3pGRlh9s4/86E31cbcNuVMogV6sdDS0rQj9+cA323xxXwYQ2hwNUSV5bssL2w7/SprQh LfMbP5OsgkMYdGRiIZ9q852VoxNxtbKbnzYYVH3B0n6NEnmzVC0nq3KggJDS3YpBUD/D uSvQAEGqc+9ZQzGfzNnvPhpcUtDYw46nzAPxSh+QM/jD8uclpmT76WFgIZJpYQH6XNvq 3kwsabONEMBcGjzDzWzgUtPlslAtkKMXs9vFaVg91F6Cfbc077ix/IxSewKrczxN4Yj5 9WRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MT7cYYrcM99DVBuXFRqZwFieQfngoQCFo5QcPTP5JIU=; b=f/ch9BlkP3qJNsq2T8fHqnaHjm2tJll2qLzZqYx594cYJ+wAaDjSwO+f1biTQoGzPY fgoQ9epWjnCkbdiCbGropF/oYCuK1djvG6bqoCkbiNQSpCOTpo76iw7d/TeYf9zwDU7E xi/O9BOUZWAyByRRD/5YMBvsx9aBr3p4crfbWZRu5kUdmfE1JwzYfTmga8RziIR12PCK t3JJIu3oPzet8iuaLjj97Ag3gTcfNzOPrUtjBpBY4vTO8F+7azIKj5oNW27aNNZpcjoN Ngu2Bi1APVv/DFX/i0nlbBJ4TAZ75d9kVhmvqtx2GHnIRMAC4tOaeiskNEvFVJAtvjWO lvjw== X-Gm-Message-State: AOAM532ZbrIGPU7SPgxx6agSuaTb69ZyigFiEJgdzUCdkJT9l3ASalod DvYcRLtzzZpU4XYpbcCOy5MutxWJKUd9qbfSppo= X-Received: by 2002:a05:6638:601:: with SMTP id g1mr4378444jar.137.1594710205319; Tue, 14 Jul 2020 00:03:25 -0700 (PDT) MIME-Version: 1.0 References: <1594708507-6794-1-git-send-email-dillon.minfei@gmail.com> <1594708507-6794-2-git-send-email-dillon.minfei@gmail.com> <20200714164504.10b23697@canb.auug.org.au> In-Reply-To: <20200714164504.10b23697@canb.auug.org.au> From: dillon min Date: Tue, 14 Jul 2020 15:02:49 +0800 Message-ID: Subject: Re: [PATCH v4] Fix dcan driver probe failed on am437x platform To: Stephen Rothwell Cc: Benoit Cousson , tony@atomide.com, Rob Herring , linux-omap@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, Thanks for your patience, step by step help on my patch reviewing. Dillon, On Tue, Jul 14, 2020 at 2:45 PM Stephen Rothwell wrote: > > Hi Dillon, > > > Hi Stephen, > > > > This changes correct commit messages based on your reviewing. > > make Fixes tags to oneline. > > make all commit message tags at the end of commit message > > make Fixes tags before Signed-off-by line. > > add probe failed log to commit message. > > Thanks for persisting. It looks good to me, now. > > -- > Cheers, > Stephen Rothwell