Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 09:37:11 +0200
From:   Greg KH <gregkh@linuxfoundation.org>
To:     ivan <yanziily@gmail.com>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, jiangfei1@xiaomi.com,
        Qiwu Huang <huangqiwu@xiaomi.com>
Subject: Re: [PATCH v2 1/5] power: supply: core: add quick charge type
 property
Message-ID: <20200714073711.GA689066@kroah.com>
References: <cover.1594612572.git.huangqiwu@xiaomi.com>
 <38b7b1dc10cf608faceae923374791a52a450919.1594612572.git.huangqiwu@xiaomi.com>
 <20200713084113.GC215949@kroah.com>
 <CAPtXDt2ALhYRTTn7m6Jb3k+339VC84YUDC7V=Yb7-a+DpvuVtg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAPtXDt2ALhYRTTn7m6Jb3k+339VC84YUDC7V=Yb7-a+DpvuVtg@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Tue, Jul 14, 2020 at 03:31:52PM +0800, ivan wrote:
> I think we should add an enumederated for this

What is "this"?

> 
> for example
> 
> abi document
> 
> What: /sys/class/power_supply/<supply_name>/quick_charge_type
> Date: Jul 2020
> Contact: Fei Jiang <jiangfei1@xiaomi.com>
> Description:
> Reports the kind of quick charge type based on different adapter power.
> Different quick charge type represent different charging power.
> QUICK_CHARGE_NORMAL : Charging Power <= 10W
> QUICK_CHARGE_FAST : 10W < Charging Power <= 20W
> QUICK_CHARGE_FLASH : 20W < Charging Power <= 30W
> QUICK_CHARGE_TURBE : 30W < Charging Power <= 50W
> QUICK_CHARGE_SUPER : Charging Power > 50W
> 
> Access: Read-Only
> Valid values:
> 0: QUICK_CHARGE_NORMAL,
> 1: QUICK_CHARGE_FAST,
> 2: QUICK_CHARGE_FLASH,
> 3: QUICK_CHARGE_TURBE,
> 4: QUICK_CHARGE_SUPER.
> 
> 
> power_supply.h
> 
> enum power_supply_quick_charge_type {
> QUICK_CHARGE_NORMAL = 0,
> QUICK_CHARGE_FAST,
> QUICK_CHARGE_FLASH,
> QUICK_CHARGE_TURBE,
> QUICK_CHARGE_SUPER,
> QUICK_CHARGE_MAX,
> };

That seems like a good change, why not do this?  :)

thanks,

greg k-h