Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Clark Wang <xiaoning.wang@nxp.com>
To:     broonie@kernel.org
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] spi: lpspi: add NULL check when probe device
Date:   Tue, 14 Jul 2020 15:52:48 +0800
Message-Id: <20200714075251.12777-3-xiaoning.wang@nxp.com>
In-Reply-To: <20200714075251.12777-1-xiaoning.wang@nxp.com>
References: <20200714075251.12777-1-xiaoning.wang@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (119.31.174.71) by SG2PR0401CA0013.apcprd04.prod.outlook.com (2603:1096:3:1::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 07:52:45 +0000
X-Mailer: git-send-email 2.17.1
X-Originating-IP: [119.31.174.71]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 7c9585c8-6d54-4d61-06d0-08d827cae5fc
X-MS-TrafficTypeDiagnostic: AM5PR04MB3139:
X-Microsoft-Antispam-PRVS: <AM5PR04MB31395BBFF10CFA75C1A83BFEF3610@AM5PR04MB3139.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:3173;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: J4i1ikjLABxL7DIu8lDD+2ZJvhGQBGD+U4VmWsJClH4Mp4b1Hb+MSAiIJmUjPl7d4bLvbtl9p2q7b0WfYuNsmDhe9Jv2ydq3ilLtPu9gpRCVKq4mr8DhERRuqaNSOP1QumnlJoDYPtkwLcfLtY/UsJXYuSXo1sYfLIfWtN1lrMI7iIgw/HgafA7oyTUkH2KVmSRgBouiQi3Qx2J6Wk2jrpAEzm6VoHR8PJBMZMgVWKUAtOvda0J20PEdZZJJbKNnx2zIIReNd0KBA35Ij6ISKRNPY/zak4KuXSobFT6mWyMcOpHIECdPhjDYY0+bN0eKhKJSJdi2DkOtRmXmg8I9Opg3OCA6lgfu5tP0N1B2/XO7/AupqVp5uG/DEtSUYDT4
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5623.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39860400002)(136003)(366004)(346002)(376002)(6506007)(6486002)(6512007)(52116002)(8936002)(2906002)(16526019)(36756003)(26005)(5660300002)(6916009)(86362001)(478600001)(186003)(316002)(66556008)(66476007)(8676002)(4744005)(2616005)(956004)(4326008)(66946007)(1076003)(69590400007);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: IX0Sy0L6Cs9LJRfJqUNegi48OUEjuSTRx6KFn95sbTJ9uHtHHXJaucU8pTH9qHGUSCU/hfNzKjgyd8UXlGxC0NpqRtNX+kKVMxxn64BdmCHWnEFQ3oq9c2vHp+LuYYAUZbUglYvFBMukCPH3xZGP0ARE8UsH6Ibqe/tB9MnaiE2CAyxY36Bw4dOgeFBb9Go7Ch7SSpy1wO6g1R2QeZab68HqeZ69/7A9pd6oQ52ayX1PmTXclzSNSa93Sp091c18ZyQdYlV9QBpHppj7aZ6aL2e44R9wS9xvFBcMhA9719FXu6BLOl5hcTTvRWX+WRYYWcrId9fK8Db8unQPpkWZkLvCT2ItIyJSLjecr0stpKRT/5crTNTjwvyt02o2pFoaZELncSkn6MYnWH0x/oN8CW746CsNBqCdiitnxKf29EPidSAG98Tw4L2CX1m4UqXaVRJM7EiK2/21wT7J+3j1mLMzbHOIrJZEGUjjmM8kH3I=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7c9585c8-6d54-4d61-06d0-08d827cae5fc
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5623.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2020 07:52:47.2369
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7QrWjy6cuS0PeSRQFyQL3U+nr7NtIMZEuU9tZxaLijKPA3SWqW8w+xjcx3Hq6YOVjSQPke1sudDbN57o19lSOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB3139
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Add a NULL check for device node and lpspi_platform_info when lpspi
device probe.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
---
 drivers/spi/spi-fsl-lpspi.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/spi/spi-fsl-lpspi.c b/drivers/spi/spi-fsl-lpspi.c
index a1555bbc5e5a..ca43d93adf30 100644
--- a/drivers/spi/spi-fsl-lpspi.c
+++ b/drivers/spi/spi-fsl-lpspi.c
@@ -841,6 +841,11 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
 	u32 temp;
 	bool is_slave;
 
+	if (!np && !lpspi_platform_info) {
+		dev_err(&pdev->dev, "can't get the platform data\n");
+		return -EINVAL;
+	}
+
 	is_slave = of_property_read_bool((&pdev->dev)->of_node, "spi-slave");
 	if (is_slave)
 		controller = spi_alloc_slave(&pdev->dev,
-- 
2.17.1