Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Frederic Weisbecker <frederic@kernel.org>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Frederic Weisbecker <frederic@kernel.org>,
        Anna-Maria Gleixner <anna-maria@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH 2/9] timer: Add comments about calc_index() ceiling work
In-Reply-To: <20200707013253.26770-3-frederic@kernel.org>
References: <20200707013253.26770-1-frederic@kernel.org> <20200707013253.26770-3-frederic@kernel.org>
Date:   Tue, 14 Jul 2020 11:13:26 +0200
Message-ID: <87tuyav4qx.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Frederic Weisbecker <frederic@kernel.org> writes:
>  static inline unsigned calc_index(unsigned expires, unsigned lvl)
>  {
> +	/*
> +	 * Time may have past since the clock last reached an index of
> +	 * this @lvl. And that time, below LVL_GRAN(@lvl), is going to
> +	 * be substracted from the delta until we reach @expires. To
> +	 * fix that we must add one level granularity unit to make sure
> +	 * we rather expire late than early. Prefer ceil over floor.

This comment confuses the hell out of me.

        /*
         * The timer wheel has to guarantee that a timer does not fire
         * early. Early expiry can happen due to:
         * - Timer is armed at the edge of a tick
         * - Truncation of the expiry time in the outer wheel levels
         *
         * Round up with level granularity to prevent this.
         */

Hmm?

Thanks,

        tglx