Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1618867ybh; Tue, 14 Jul 2020 02:44:59 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJq5I5bGjRpoOb8MR2urjZ5vfB9BPkILrRLZsW7oP50MtAPXalbGZNvPaPpKhX17b2MmJF X-Received: by 2002:a17:906:1356:: with SMTP id x22mr3800780ejb.429.1594719899293; Tue, 14 Jul 2020 02:44:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594719899; cv=none; d=google.com; s=arc-20160816; b=c9pQNbsatppZdi1A8CGUw+ujlJeW0JbDkH3vigLkJiu/MebPviVallicGgs1gGcz64 YL+bBIRqwqJkWr+P24kKGmzOLiGCpx1r0gvnBaIP3AkWBkYcCfMRw7zyT4WIqh7gqymf xflxkl5gVwRlC3h9fKumbL0fzLT2h7TnF5kDDedsEfGU+dB9bGplCCWoxdxm38hJwpJi rp5Scxhvd63Qm3y/K9iOWKCmYH99p3+rjfLdR6IbUeRr9K8LjVAnvlLhJOxImPMtMKzF Jca3RLxTcfDYhjBCFqgg92Fx4CW/lNIJvcAg1lsWBkIprNqQJfwhPX8m4IdiAwB22axu Jb0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gRsu8F8CZwTAksyiWlKTvBWWeAta3mVCF6pvT1MV0hk=; b=AfNVej6MDl9iOHpv0a5jhNNzv+1LnsMzZ7UUB/J2xqYOUSWY1pUtEom5Qpji1px2kw z/URF+5GMO9SOfkxO2yV+DGkeQzte3Rt9cTtGG/eX/swSfqLdh09dDSShjBNjZy6Gqzu l/EGVo3EPidI+9m9w02VDPmNhVK3GuaIPt5LxvXqivHRwaJZ9w/H6qLNErQX6SsYwzH2 3IrQvpd6Bb8BurGmCq+3Ts+JDdaWrDQUq9xCDPqAK3gE4+t6jvxKpR/mt2CTDcVlOHbf ywW9w1ibeIp3IlihGR5BWZgR43qunMkoZBUxH1BJK/wmtqq/7Tb789TpeTNuCPgrDvKA usrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cg7mYIXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d18si10801522edy.194.2020.07.14.02.44.36; Tue, 14 Jul 2020 02:44:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Cg7mYIXA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726720AbgGNJoW (ORCPT + 99 others); Tue, 14 Jul 2020 05:44:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:35392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725816AbgGNJoW (ORCPT ); Tue, 14 Jul 2020 05:44:22 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 376F421D7A; Tue, 14 Jul 2020 09:44:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594719860; bh=WIzzL2vxmexuuKMhffrG8LZui4Dea/ANs5K0xx4zolE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Cg7mYIXAqtB0Frw9eTLIzy3AqMaN8uzdBgVihAY/uCka7Fn7d6nvxK4PoCWN3i8lf R4jgxKw1+mE/hX2r0+VcjCG9NrEsln/oLoqK8QNSiDdAlRckCgOVMzb/YvTEAOoJo2 dtajleBa1Jm7t1eqcoWxZWHkmoDc8iwHhxXjQb5Y= Date: Tue, 14 Jul 2020 10:44:06 +0100 From: Mark Brown To: Qing Zhang Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , Tiezhu Yang Subject: Re: [PATCH] spi: Use clk_prepare_enable and clk_disable_unprepare Message-ID: <20200714094406.GA4900@sirena.org.uk> References: <1594717754-25428-1-git-send-email-zhangqing@loongson.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bg08WKrSYDhXBjb5" Content-Disposition: inline In-Reply-To: <1594717754-25428-1-git-send-email-zhangqing@loongson.cn> X-Cookie: Your password is pitifully obvious. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --bg08WKrSYDhXBjb5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 14, 2020 at 05:09:14PM +0800, Qing Zhang wrote: > Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare > calls as required by common clock framework. >=20 > Signed-off-by: Qing Zhang > --- > drivers/spi/spi-coldfire-qspi.c | 4 ++-- Are you sure that ColdFire uses the common clock framework? > drivers/spi/spi-omap-uwire.c | 4 ++-- It makes life easier if you send per-driver patches, that makes it easier for driver maintainers to review things and means that issues with a change in one driver won't hold up another. --bg08WKrSYDhXBjb5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8NfmMACgkQJNaLcl1U h9BIbAf/R2GkeQj9D8dfvZvUp0id4vPtJwbTq/q26CQepJMwZC34jt2JA0XnTtnf 58YhpL1GG9S1rcA8KGict63K+v9IsC+YoQwtfDWQpwRUCJ7dCSpZJCAxDSMbsUrl TAg1bFo37gqb4zzeNBOohrp40QhAL/XV+Y8N4Eih6Sf3lBmeEPKqdLuLMumBPriR ZCoOEiArZMhAbSvLsCzNVRI7j0Bc3jqqQxTHDu8VxQI/4OETK/cM63UQdfKeFETv 013BOyx+E4Ig7es5SfB1KNKIAWM44q3M4/R/MAGQs8iZZBL15pvio9QcZNyaorU/ 3RnU7uo0TMOq5QORtscA1JRNVpIvOA== =TPc/ -----END PGP SIGNATURE----- --bg08WKrSYDhXBjb5--