Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1669915ybh; Tue, 14 Jul 2020 04:19:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvV1uty0SNo3tFAAAh+Z4p4cdMEx5sCe7KHx6zmiZMTYHMbcmK8DdOnN8/CPHsM0oa6Fby X-Received: by 2002:a17:906:7c54:: with SMTP id g20mr4065440ejp.460.1594725582427; Tue, 14 Jul 2020 04:19:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594725582; cv=none; d=google.com; s=arc-20160816; b=yWpySsabgwRTIUcAjsyuM44ODVih6r7TOndxPtO5qUwe2FZ5fJuMObxC49cR7ehJym SX8YiXFaQBYRDquNVG+iaanf76cblw4mjET68eVKzhwrqGc5S/UR842WlcRh7APxJxO0 JuywepCYXQtD1R9sseU9RCLWVJoyMzeluzihWMRU9tWeEGEEl44pKBi6NfDQ6v5ec6ms lf2aw4xht1KJq7lFmXVBFBkK8VApdRAyTTlKcJvAKLo55PaovIRAvzoqSgYRDe5QqLG+ HNd/5F28OJWwAjqHhedvKCR5AwPLACIhNxo1Fhx2KCfGQMhzaaYLEUOCBPSkh81+gnvP 8b/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=cRru+QVNWPcXwrS+5AggUBJuMNToXP2MN3BSd0llBroCiAUjitclPZCXt/QA17inMX ZFFLHL0rpdW5NHXAU+23LPFrSapkMtbUnZM+uwrlT3zLIu7MHDt/GRlSN6VsfYZGx3Bz +6vJz9pxxnAzjz0+78/Tuwn+qHwUGxwPQ1RNIi57E1Hdrj7VVXInnFPsSIRW/QUOOMAT I+0E+A3lKwFw4XxkNo8xbzIQGPEMe2IfDo5Auh+uB3NfiQ/gx1Jvc3CR51Zx4s7UW43S jFKL+YzbAlVPCC7PP+L1YrpKDrHB6Wxenlw3CiIe8Hpma4Ve/o0cD72T/0DFenEXp+2O 9Fdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pHR0K+KI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p4si11156723eju.447.2020.07.14.04.19.19; Tue, 14 Jul 2020 04:19:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=pHR0K+KI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727115AbgGNLTF (ORCPT + 99 others); Tue, 14 Jul 2020 07:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727924AbgGNLQr (ORCPT ); Tue, 14 Jul 2020 07:16:47 -0400 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C909C08C5F9 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) Received: by mail-wr1-x444.google.com with SMTP id f2so20825773wrp.7 for ; Tue, 14 Jul 2020 04:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=pHR0K+KIKxD5EhQKwXJRi/S4mxtDdDxisRS89L6rsYWjar6xsf8yjwNVsm+/g1upct IjWqNYsequpP4EokGC40Vu6cXEx/yZuCdZaq0N3/OFVgliYwoxdDkSpoT0u76/HuKY6U MUbzo7YLYjjS7/pll5iVgV7Q58ymHgPYlsRuP2liz2R5WxN22Oi1Kk4KwrQO9/oZusKt OQkwybdZ3gHPd3FOQszTItGnFNRuTo22n7TnlJGNSowr7quZ7wNDgooiGSqS4dtCo1t5 8Tcq5cilV0VQoGtWhZTw8JfUhrmhODcrz7h4EDAXTRcu12wQcylbZ4ozZzb2AmspBtFl XHAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=AREbkFQeq62jMhEbsCGiKpcIyUmzmEoBeESlFrgp8DE=; b=q61eR26RYvm7TN8SC2jynVSElJRZNvINzTCcTd5IWHovsJw2eOt1oAEhz4YMVa06+G 1qCkXNZtnlVuVERyrmXj0A9p1Y7DOPQTbJoYeN4/TBy8stqQUdqv9/MwbeYMYZcqgsvW n64fHV1LxVa0PkkT9OYDGg2bFTsy5lSGUTeMrfwILUnoOQ21zTNI5aXkUalHmHr9YMJ5 edxr2T+hqUshaV46QVwKkjX1SvEQgfgv8lCpuPK7MzXbtQ2dvnZtwWMIj2KJIXsYQvRO R12EKKVWslSzNrkPSAmruyLXjljT9EZh4wbZbx3U6c+KFTrLO1OpMdtZbI0j0igWFZ/s dA/A== X-Gm-Message-State: AOAM533EPSfTLJ50Wm3/3sdtlbU+s3767rM1HvXhUwCVScXaxz68jHEp bnJeF0AisU7rTzzWjvu5BaQVigz/Eio= X-Received: by 2002:a5d:420b:: with SMTP id n11mr4591674wrq.91.1594725359812; Tue, 14 Jul 2020 04:15:59 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.15.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:15:59 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Maxime Ripard , Chen-Yu Tsai , =?UTF-8?q?Emilio=20L=C3=B3pez?= Subject: [PATCH 09/17] dma: sun4i-dma: Demote obvious misuse of kerneldoc to standard comment blocks Date: Tue, 14 Jul 2020 12:15:38 +0100 Message-Id: <20200714111546.1755231-10-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'priv' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:321: warning: Function parameter or member 'vchan' not described in '__execute_vchan_pending' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'chan' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'src' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'dest' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'len' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'sconfig' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:435: warning: Function parameter or member 'direction' not described in 'generate_ndma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'chan' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'src' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'dest' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'len' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:501: warning: Function parameter or member 'sconfig' not described in 'generate_ddma_promise' drivers/dma/sun4i-dma.c:577: warning: Function parameter or member 'contract' not described in 'get_next_cyclic_promise' drivers/dma/sun4i-dma.c:596: warning: Function parameter or member 'vd' not described in 'sun4i_dma_free_contract' Cc: Maxime Ripard Cc: Chen-Yu Tsai Cc: "Emilio López" Signed-off-by: Lee Jones --- drivers/dma/sun4i-dma.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/dma/sun4i-dma.c b/drivers/dma/sun4i-dma.c index e7ff09a5031db..e8b6633ae6612 100644 --- a/drivers/dma/sun4i-dma.c +++ b/drivers/dma/sun4i-dma.c @@ -307,7 +307,7 @@ static void set_pchan_interrupt(struct sun4i_dma_dev *priv, spin_unlock_irqrestore(&priv->lock, flags); } -/** +/* * Execute pending operations on a vchan * * When given a vchan, this function will try to acquire a suitable @@ -419,7 +419,7 @@ static int sanitize_config(struct dma_slave_config *sconfig, return 0; } -/** +/* * Generate a promise, to be used in a normal DMA contract. * * A NDMA promise contains all the information required to program the @@ -486,7 +486,7 @@ generate_ndma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a promise, to be used in a dedicated DMA contract. * * A DDMA promise contains all the information required to program the @@ -543,7 +543,7 @@ generate_ddma_promise(struct dma_chan *chan, dma_addr_t src, dma_addr_t dest, return NULL; } -/** +/* * Generate a contract * * Contracts function as DMA descriptors. As our hardware does not support @@ -565,7 +565,7 @@ static struct sun4i_dma_contract *generate_dma_contract(void) return contract; } -/** +/* * Get next promise on a cyclic transfer * * Cyclic contracts contain a series of promises which are executed on a @@ -589,7 +589,7 @@ get_next_cyclic_promise(struct sun4i_dma_contract *contract) return promise; } -/** +/* * Free a contract and all its associated promises */ static void sun4i_dma_free_contract(struct virt_dma_desc *vd) -- 2.25.1