Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1671110ybh; Tue, 14 Jul 2020 04:21:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxZS3RTWQUtQoibqJExR2CbZDeFogC3ysJla2QNTo2cQ6vj3GEkWOS6E9/z9/kI1amSI1Sv X-Received: by 2002:a05:6402:1d14:: with SMTP id dg20mr4051930edb.23.1594725704241; Tue, 14 Jul 2020 04:21:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594725704; cv=none; d=google.com; s=arc-20160816; b=JrInrOn16f8O+z3lK5b7qtCmL3CvSXozdbh86m7stIQg0dip/VAI5ftnUx+uAwiEGX 7MC9yBBDitJrTX8J2TnPGEhs5e8fuZftQg9cPmpbyGc3myARPCZI4W3cni0z6/fUvH51 7viBqtxBw1U7pQ+zyZbKc8/+8JYMbrXe1o+mOqZ5dvv80EHx19N3uXVnCz+hskwsNq7/ yn4NVFHEcbYMup9rOvrFD15hdMuJlFmqUjRlw41inXBtWcIv6ghNXfJBq4UmBI1iPD3W NDlHoNHkbzQTOuY36SjAK5Kc2wwlAlZJhvh9lK6iXL1stf/GhCIGWykeH+/rvgQqsGrv DNEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=UhubpHBScRSKK9Go94jqLDopito3mNtB0w+AeKUhItW8JD2BtLCk7MSRHcqkj6qrdN yXpnBAwjc8USbioqJYdAu1rl8AokPSZ4N1tkaWHAwmDHoL20wyVO7qOhNBXuVw3fwi3K XZiJv50K4Wy1OcLUZfPhQlJFIgaV57xOcqClnHWPI6Bs3PwOqQDAkzEizayjrSqKxx5E whZn2eCS+HA8kvvw7DUcuA3jkd2LlnwmBOPc5PHEp/kEjgScgfPxZHGnPzPo7mspaM1R aL1O2//3kvaPnbU1PD+lbL92aC3Ou7wayGLxjUBs7eCocu2wcFQkOILlD117/rWJ+afv 2E/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=olMroX2n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ni2si10563984ejb.480.2020.07.14.04.21.21; Tue, 14 Jul 2020 04:21:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=olMroX2n; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727863AbgGNLUg (ORCPT + 99 others); Tue, 14 Jul 2020 07:20:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728003AbgGNLSr (ORCPT ); Tue, 14 Jul 2020 07:18:47 -0400 Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B91E7C08E8AC for ; Tue, 14 Jul 2020 04:16:11 -0700 (PDT) Received: by mail-wm1-x344.google.com with SMTP id g75so4774334wme.5 for ; Tue, 14 Jul 2020 04:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=olMroX2nvIY5Lf+mJdh7YdFYN9DJVM3DML7ddb9rOUmNTds3C+m2JdC3mqOc4y2yki oCjN/ROWc7AHqc9tDEJzhS48Ft6N8WDIfr4nT2lTE5jdLWQGIWrolpNjO+lPcicdCRRM 2fCsqXPM7bJUnvwrgFNVo7ICmUoZdIFs0+zJzOFi3XIgI9grTk89B6Pv4TQQAvkhtRye 9sjSmijV4C2Z3rQ8tSb74WzoWGcSTqF9z7JoxwTfy5DhX28xoARq2ihF4ykZe7GW8r58 nDxZdTjaN05xW+eeHH3pFOqwpav7WW2J+QyIHz+GahF3UcEzGl7obV8i3hDK+YXlBs7R Pf0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+6/z2bmjZMbhtqS1hEM9SRMyZids/5Sm1LJ5PQCQzW4=; b=qfm47azfmCw6qBpdMNPumMlyNn/skmcpW86n1x7rskCUent4x8dgwnXapIfYHl9tXQ A7ns7s/47rj/JWoaQ6vCiRP1/hUPqLzKiUsXdPjEgUfHHCi2yJEjrTSEzG4/OUnmtMOb QLaORKw2si8QZDQl2eyJ+HYC34Nfza2XjVFPcQK2bnkSlf+IVFqzGxElpIIl/5lvnQCe cUEE6BgqxBcqrz0l++iqIh0ecjorPbVQPjMJkdhA3ivwe0VcE4wavJHnS2FAg6J8Xwog D4uNewJRtAPV7t0qtAHSWEJyRlrns6WmAwp9uq/Zv6I4DOR+lq+yLQvwG4Eae5eHzM8n 1EJQ== X-Gm-Message-State: AOAM530UNeSbeSRZTe1pRPCT7olZKT0V5OLyorbNJcva/cx9251nwZoy 2XscY/FaJ1lvm6yq9/Fe2WblZw== X-Received: by 2002:a1c:7209:: with SMTP id n9mr3892120wmc.150.1594725369516; Tue, 14 Jul 2020 04:16:09 -0700 (PDT) Received: from localhost.localdomain ([2.31.163.61]) by smtp.gmail.com with ESMTPSA id l8sm28566052wrq.15.2020.07.14.04.16.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 04:16:08 -0700 (PDT) From: Lee Jones To: dan.j.williams@intel.com, vkoul@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Lee Jones , Dave Jiang , Leonid Ravich Subject: [PATCH 17/17] dma: ioat: dma: Fix some parameter misspelling and provide description for phys_complete Date: Tue, 14 Jul 2020 12:15:46 +0100 Message-Id: <20200714111546.1755231-18-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200714111546.1755231-1-lee.jones@linaro.org> References: <20200714111546.1755231-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/dma/ioat/dma.c:202: warning: Function parameter or member 'ioat_chan' not described in 'ioat_update_pending' drivers/dma/ioat/dma.c:202: warning: Excess function parameter 'ioat' description in 'ioat_update_pending' drivers/dma/ioat/dma.c:465: warning: Function parameter or member 'ioat_chan' not described in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:465: warning: Excess function parameter 'ioat' description in 'ioat_check_space_lock' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'ioat_chan' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Function parameter or member 'phys_complete' not described in '__cleanup' drivers/dma/ioat/dma.c:591: warning: Excess function parameter 'ioat' description in '__cleanup' Cc: Dave Jiang Cc: Leonid Ravich Signed-off-by: Lee Jones --- drivers/dma/ioat/dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index fd782aee02d92..a814b200299bf 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -193,7 +193,7 @@ void ioat_issue_pending(struct dma_chan *c) /** * ioat_update_pending - log pending descriptors - * @ioat: ioat+ channel + * @ioat_chan: ioat+ channel * * Check if the number of unsubmitted descriptors has exceeded the * watermark. Called with prep_lock held @@ -457,7 +457,7 @@ ioat_alloc_ring(struct dma_chan *c, int order, gfp_t flags) /** * ioat_check_space_lock - verify space and grab ring producer lock - * @ioat: ioat,3 channel (ring) to operate on + * @ioat_chan: ioat,3 channel (ring) to operate on * @num_descs: allocation length */ int ioat_check_space_lock(struct ioatdma_chan *ioat_chan, int num_descs) @@ -585,7 +585,8 @@ desc_get_errstat(struct ioatdma_chan *ioat_chan, struct ioat_ring_ent *desc) /** * __cleanup - reclaim used descriptors - * @ioat: channel (ring) to clean + * @ioat_chan: channel (ring) to clean + * @phys_complete: zeroed (or not) completion address (from status) */ static void __cleanup(struct ioatdma_chan *ioat_chan, dma_addr_t phys_complete) { -- 2.25.1