Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1671641ybh; Tue, 14 Jul 2020 04:22:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyobRkbxC16u5kJ/h79KycoGIuzwSIf6eP2URb1djH7puQqHqbR0oBezRtIUgN+QR8BhMCi X-Received: by 2002:a17:907:9c6:: with SMTP id bx6mr3979532ejc.43.1594725768486; Tue, 14 Jul 2020 04:22:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594725768; cv=none; d=google.com; s=arc-20160816; b=psqkgUNgKotF6xzmBWeeMlxdgfB0HDmDngr171FZ4QC1gWdEwImIng2t5pcIzmGv6k SwKd0+I+4eN7SJ6w07B4Uv/QRdCk9wAnfSNOXQgu3cQ21fmDGiNtY85C1zGW+86Oc0Jr ukHVMevvSDJ1fajPsfhTuQgC7fdb+YZ1nlQfdZGSU8J4ql1z0gl7KHFefj40A3GoPU5O IGY81Uy+q/LfiqutxWu6uFqcqBoxnhu4dSkauuapMjj+TZRdVYHT7ggDrTluCe+xe/nP Ohtst71pFW5zrxk56BKRh0nsEcFttIGhbTObiUfrAEymSTXfXHHw6f6kI5kYIc3ri5Tc c0Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cHX0sAdeacAnbt2TSgzSCZgyVa6eOVopFOU+MfTQIFQ=; b=cl6W5/kev5kvcnuLV9eL+unWnmJ3AFtwefOZSm228Etdbcnd4ZyoXqLRqZLRsgT6uy 1XJuN2c99riZWjtwoLTN8P0G+WwvxRneRIUWdpxB5mh3SGk5xCKvvHbWalKsvFeVfCm3 xTpS0rrinTt4OnT8qxRpMqC2Xks80LnSHEsQIxoci33frxcWqjFa64WA8piGVNNVZtJ9 u3LBT/7D6Pk6UZSduKfzvxMksHb11Kl+m950+4m/+ZK/d8x9RHAsQ4QArjLr357mi1HW ih5lsWV2YlgOfx3RGTjO/IjqGLKZftELSbDGwwv2FffDz0DgCXBSM9woqjgLvYsfxZmy Yz6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v6si11918014edy.149.2020.07.14.04.22.26; Tue, 14 Jul 2020 04:22:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727121AbgGNLTu (ORCPT + 99 others); Tue, 14 Jul 2020 07:19:50 -0400 Received: from verein.lst.de ([213.95.11.211]:53949 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728129AbgGNLRs (ORCPT ); Tue, 14 Jul 2020 07:17:48 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 6BE1368CFE; Tue, 14 Jul 2020 13:17:46 +0200 (CEST) Date: Tue, 14 Jul 2020 13:17:46 +0200 From: Christoph Hellwig To: Baolin Wang Cc: kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, baolin.wang7@gmail.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: Remove redundant validation in nvme_start_ctrl() Message-ID: <20200714111746.GA17883@lst.de> References: <710eb90d9c1c125bdb37aae31ddc41a0f9782fa6.1594621435.git.baolin.wang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <710eb90d9c1c125bdb37aae31ddc41a0f9782fa6.1594621435.git.baolin.wang@linux.alibaba.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 02:25:21PM +0800, Baolin Wang wrote: > We've already validated the 'kato' in nvme_start_keep_alive(), thus no > need to validate it again in nvme_start_ctrl(). Remove it. Thanks, applied to nvme-5.9.