Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1721629ybh;
        Tue, 14 Jul 2020 05:47:38 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJyeEOufqeMLub2tM6HHVoOpSOAfnlAggGnOioXMJ0ngV8AZOA5tgq5I4DT36igFcroyCf17
X-Received: by 2002:a17:906:c04d:: with SMTP id bm13mr4197116ejb.321.1594730858414;
        Tue, 14 Jul 2020 05:47:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594730858; cv=none;
        d=google.com; s=arc-20160816;
        b=hdxRpISykGZtu3qxq7hGHCWSvQOkxQdLJQJgXmat7BgB9/OQGeUECyC+W4oqmwnpeh
         pTXozOMiE53WOXcWCNhD50Wy3NAJEhO9m+yCcWJl/uVfOEEaps1WhFnxWNIo73dDwE7S
         FDFO+rHpj7RTWcFKfPrMZk4pm2+HqL9GdYOH0WLq6iyf3YApDEk9+Y6lWoz/RF9N6ieX
         JVIKZuOfkonvzWL9zH7dXM1htS8Hoo8TUp1Rtw/R6s8bppbkktH8NGtvJUVFgA3Dw8sC
         7oDp4GHC1BLoaxJJ0qqrQcuE6p4ZydMzuZXn4Hm9mXkpuNZmkoCXusNauvn7k445cJpX
         +KzQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=Y1I0HAegT4r/446CzgZG+DkAzDcM+MzQfjx73vwQdRM=;
        b=aBKf1421CrH/cD6wm6pIusZDwCpn95XBZtjr+6HDfpP2ifZZJpwjRfWW9RBbE/zXQj
         Q9Z7bbWyVp0F5pFVT9jVF3vYmy9D4xj13vm5b6fKg2XHr1O06PV1Zvfn1MMS+noGq76b
         tLH0nX6/CGrHM1dqhIKaUn19QepXEtKNPqDx4LnMHnDlCHXvGMBVhbA/V6apRrZu9xcx
         u0p/RCfaxwOoysb3A2fi+oGVLEnY8nxxY28dDIhs5u8NDWdzq5Hc4ObLWlp5nXx05BgR
         u4EWBAxY/sWMyizuI9ZZnIydro2P0S9X0cpbFGzbchO4NVpxUn6Fir/RE8cRvbbl5XnI
         tIew==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=CQJLmeA+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id mc7si10957345ejb.371.2020.07.14.05.47.15;
        Tue, 14 Jul 2020 05:47:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=CQJLmeA+;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727886AbgGNMpJ (ORCPT <rfc822;radocaj.bane@gmail.com>
        + 99 others); Tue, 14 Jul 2020 08:45:09 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37928 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726823AbgGNMpH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Jul 2020 08:45:07 -0400
Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E683AC061755
        for <linux-kernel@vger.kernel.org>; Tue, 14 Jul 2020 05:45:06 -0700 (PDT)
Received: by mail-ej1-x643.google.com with SMTP id y10so21634531eje.1
        for <linux-kernel@vger.kernel.org>; Tue, 14 Jul 2020 05:45:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=szeredi.hu; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=Y1I0HAegT4r/446CzgZG+DkAzDcM+MzQfjx73vwQdRM=;
        b=CQJLmeA+xaZZtJF5b0Wo0lD5+aCoZG1R80srNwsCUjS76gLGuxfUW4TWyhqjgQ7ver
         SPR896yyEgiAOZBSYYcMMtrRuMKty152p9lVN1GuCkKIwX1fLqDjELomw5gPGQcHjxJL
         /QQLP2+0F4wJo1q8ejn97Hzff4QxDGsVczbuw=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=Y1I0HAegT4r/446CzgZG+DkAzDcM+MzQfjx73vwQdRM=;
        b=SsZzP0uEj6oFEf2cwExeupUNim1pmCulDGnZaQZmNBr60HG4rzkXnE2Ax3o1fVCViM
         e9sq4iOjRT/7k8KfXERKW7iuPQTB6KMo8YpfUDEbPFEfjOi6chwaBUeVBFGgzAJGxLwu
         oNXRjMBEuRkNYx87ON1B+26TaBdenhwGih1k4fsljNScTvXIXX04vK6mYJFTuhaJT20w
         ypxuGpj1RTz71t7Euaozls7Guh3wzrTA0ISHemKyHD82Z3c4LO8uyyshbNuXfHfqf9QU
         /TDjjaIgLz8KYhM7kT1fYE8BcJc0Zd+MQw0ZjY2tevMiHDiE4sdN5eDqXku+i/jHsJsb
         izhw==
X-Gm-Message-State: AOAM530Jmscj+gtAlaWja2jsOr3J8HzwgHU2RIkG125PfC9gExxB0tjY
        gVf57no4S4x3V/aMzhnb0mlv+ltbqisIQkIo30DioQ==
X-Received: by 2002:a17:906:1c05:: with SMTP id k5mr4174938ejg.320.1594730705729;
 Tue, 14 Jul 2020 05:45:05 -0700 (PDT)
MIME-Version: 1.0
References: <2733b41a-b4c6-be94-0118-a1a8d6f26eec@virtuozzo.com> <be5341bf-6631-d039-7377-2c0c77fd8be3@virtuozzo.com>
In-Reply-To: <be5341bf-6631-d039-7377-2c0c77fd8be3@virtuozzo.com>
From:   Miklos Szeredi <miklos@szeredi.hu>
Date:   Tue, 14 Jul 2020 14:44:54 +0200
Message-ID: <CAJfpegtHkZPky_rvBhtgpWrSZdzhWNw0YLiH4C_GHm9TdChs=w@mail.gmail.com>
Subject: Re: [PATCH] fuse_writepages ignores errors from fuse_writepages_fill
To:     Vasily Averin <vvs@virtuozzo.com>
Cc:     linux-fsdevel@vger.kernel.org, Maxim Patlasov <maximvp@gmail.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 25, 2020 at 11:39 AM Vasily Averin <vvs@virtuozzo.com> wrote:
>
> fuse_writepages() ignores some errors taken from fuse_writepages_fill()
> I believe it is a bug: if .writepages is called with WB_SYNC_ALL
> it should either guarantee that all data was successfully saved
> or return error.
>
> Fixes: 26d614df1da9 ("fuse: Implement writepages callback")
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>

Applied.  Thanks.

Miklos