Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 15:12:39 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     Andy Whitcroft <apw@canonical.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings
Message-ID: <20200714131239.GA162337@ulmo>
References: <20200714094141.147418-1-thierry.reding@gmail.com>
 <cd892c33922c477622ede83d80592e71098c4dc2.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="lrZ03NoBR/3+SXJZ"
Content-Disposition: inline
In-Reply-To: <cd892c33922c477622ede83d80592e71098c4dc2.camel@perches.com>
User-Agent: Mutt/1.14.4 (2020-06-18)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--lrZ03NoBR/3+SXJZ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 14, 2020 at 04:14:36AM -0700, Joe Perches wrote:
> On Tue, 2020-07-14 at 11:41 +0200, Thierry Reding wrote:
> > From: Thierry Reding <treding@nvidia.com>
> >=20
> > The current checks will interpret a '+' character as special because
> > they use regular expression matching. Escape the '+' character if it
> > appears in a compatible string.
> >=20
> > Signed-off-by: Thierry Reding <treding@nvidia.com>
>=20
> Thanks
>=20
> > ---
> >  scripts/checkpatch.pl | 1 +
> >  1 file changed, 1 insertion(+)
> >=20
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 4c820607540b..8104d0736e7f 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -3145,6 +3145,7 @@ sub process {
> >  			my $vp_file =3D $dt_path . "vendor-prefixes.yaml";
> > =20
> >  			foreach my $compat (@compats) {
> > +				$compat =3D~ s/\+/\\+/;
>=20
> This changes the @compats array for each line

I'm not overly familiar with the internals of Perl. I was assuming that
$compat would be a copy of each of the strings in @compats. From what
you're saying it sounds like it's more like a pointer to them instead.

Irrespective, does that do any harm, though? I suppose we could add an
extra local variable like we do for compat2 and compat3 and modify that
instead. That way the contents would perhaps remain unmodified.

Is that what you were suggesting?

Thierry

--lrZ03NoBR/3+SXJZ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl8Nr0UACgkQ3SOs138+
s6FAsA/9GTh6tcM2IIBSctHuCvmXckubRzVGzlV+AqitZCSRGkpjSVyKMr9V/KoD
TSA4yynwNxxUfUOZycXW5oTNygkwo+cl9gkGDrRRXcfg0qg9ek+q5pfBZnNluPPg
BB0tMwp7dKbl8XYPJSk//XiImrnTzrVvMPO/wcq4PS/hYXWOzC0HlR2s44Asw1xP
Pxlk0n0XDCKvd1OzFQ93gziYvDtMFGt4YeYrTYEGapHeP71o6p9XZf/H9VE4EIRv
v6iOiJp06aXNLo/Wll4Oi8WV8k2s0blvpQoXgclmpasZ8deGw/qSZWsV8QIK7X6m
7nMUcIRk509O1AgBnJ2tCkpBOC78pixbAJWYAxb3khDWSGVhEQiX1R8V1qGZW6kJ
rMM0M5t1KIib7xyz8hDC+cSOVb7HNKk1Eb1t5vQHvjIZZSe9NvDq4idXiv4gpVce
nmcSRTvyLHn9NF8GU+ZYiO24okxKWocjMHlLTvLTpnjifs+SzlGcnWICsKupeMhz
Y4D66EBu0wAvs8mwILWesE5rXeImVKWMkcde/z3W4gB0IPaKep8wu497YC4qxqmr
NQGfcfJ8e1pHaNEhVN2Xzt/0M6EoR5d/KcvWnUL7X2Qzk5HnnisOafCxBuxkqTaJ
WxbLGoao0uiTQxxTIx6dkeZtuEqi4+6NeOXOLjhNS8XlUUMym5U=
=HDxT
-----END PGP SIGNATURE-----

--lrZ03NoBR/3+SXJZ--