Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1758895ybh; Tue, 14 Jul 2020 06:40:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/F7t5jK5LSrPog5KxmBHmTGgNoijLRZbyzV3E06699QZTyxNNw/PrSd/SLabBmrlwWg6W X-Received: by 2002:a17:906:e2ca:: with SMTP id gr10mr4404235ejb.81.1594734018142; Tue, 14 Jul 2020 06:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594734018; cv=none; d=google.com; s=arc-20160816; b=YzXbybShLIx3JKEoX7mP0iSYJDDDOohUOPm4WlN5wbkIJLlp7qkRq2CeQT/PSmFf7i lTEJa9FjgcTsibriV4DlbY9xJDmW9oOhdgfvTk6Un0uxsf+8jPQ93KxP4z8TecBe3YX9 b1Fv5pipOYFiDrj2WNfch8zP0iU99EAkyShqZLBH1kXx6667NopRwDyWj5+qboizA0ds NzOVfVc0aYoeUqUOhe9UoXfbw+HcnS51qrp7McPvXjslCtRDbJfh9x9Qcjp3IGGU4Zr0 VAMV15BaQvu9y9EwA7LMDpdQg2bJv4w5ZTkGDCmamB/JT1VKMKDtSb1pcgdQA7G6t0o5 IRaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=Z/1qHWMgdqttXlMwolTGgautgriii1HuIReVhIxjW6Q=; b=fIjElfnXum/uHbqws6ies/+t+bpphPmKJIFcOuoBlYqUIngjYGc9UQ3Q9F5kCNwg/w BHwyhrdUCaU/YWu8HiR0DylXAXTuB+o0k0QvjAWJj75uIQMw2GvI/JbBxS0YXj3MJHKM AM9g/zlUU6eJExnaRfu/4R9Uz3yKAGh+cXnlzyk9zeyZYvnV8uZQjRxYMHyh6Uhgx/QY BeGKzgexBOX3StYgzeG7F1GifHUXljpCWeCcLlu3Sxp8Xjo30zs8HvwESQ6XUyG3qY+r P23wKAKkpNXaXPfvjGPjn2R4euTWV4gS73AG9kmdwWDB6SXYS2ez0iW1eo+RAt74+gYc 7anQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j13si10090405ejc.314.2020.07.14.06.39.52; Tue, 14 Jul 2020 06:40:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726456AbgGNNha (ORCPT + 99 others); Tue, 14 Jul 2020 09:37:30 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:52875 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbgGNNh3 (ORCPT ); Tue, 14 Jul 2020 09:37:29 -0400 Received: from fsav301.sakura.ne.jp (fsav301.sakura.ne.jp [153.120.85.132]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 06EDbQxS094750; Tue, 14 Jul 2020 22:37:26 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav301.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav301.sakura.ne.jp); Tue, 14 Jul 2020 22:37:26 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav301.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 06EDbQm9094743 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 14 Jul 2020 22:37:26 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [PATCH] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins. From: Tetsuo Handa To: Bartlomiej Zolnierkiewicz Cc: Greg Kroah-Hartman , Jiri Slaby , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, Dmitry Vyukov , linux-kernel@vger.kernel.org, George Kennedy , Dan Carpenter References: <189fc902-db7c-9886-cc31-c0348435303a@i-love.sakura.ne.jp> <20200712111013.11881-1-penguin-kernel@I-love.SAKURA.ne.jp> <20200712111013.11881-2-penguin-kernel@I-love.SAKURA.ne.jp> Message-ID: Date: Tue, 14 Jul 2020 22:37:27 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/07/14 19:27, Tetsuo Handa wrote: > On 2020/07/14 16:22, Bartlomiej Zolnierkiewicz wrote: >> How does this patch relate to: >> >> https://marc.info/?l=linux-fbdev&m=159415024816722&w=2 >> >> ? >> >> It seems to address the same issue, I've added George and Dan to Cc:. > > George Kennedy's patch does not help for my case. > OK. You can add Reported-and-tested-by: syzbot to my patch. By the way, if /* bitfill_aligned() assumes that it's at least 8x8 */ is true, don't we need to also check that the rect to fill is at least 8x8 in bit_clear_margins() ? (Well, I feel did it mean multiple of 8x8 ? Then, what is bitfill_unaligned() for ?)