Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1774111ybh; Tue, 14 Jul 2020 07:04:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxSkgkChxLgkw8ZSse2YUCyPzjgX0jKap5KzjfXFpyv99uzDWHarG5UQt+YHnCjixVMwPjw X-Received: by 2002:a50:9f8c:: with SMTP id c12mr4616302edf.149.1594735467023; Tue, 14 Jul 2020 07:04:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594735467; cv=none; d=google.com; s=arc-20160816; b=Fuu1GgY1uHoOj5Nq+C2RKj9m0hP7N5Z3bn17RuqSRLGLm/xz3mMY+3rikqaE8lPQ6w 6uqIHhBJPchl8t/QFEjUjIjdmR49HUBvwWF1b0KUdc1efhPALnRXxn8z8r9+kETpV2x4 +LX3VCmL8bT+cgmy9T9GG+MXx5o2BQxJz8pz8eK55SPUY8BAIKHbVRI1DJxtMAOChSYu ZHmJ1BXW+7lkAEXEsrv7vZLvR2t/12f2YfrgOXkZN0xZeQvApPZnqtkXRtPpPY44ww2A nq1rr3NF7avHN6r62HTtApgbRzN6Gtgj9M1/RrTeU/MlEQJWczha4bpY48IxoOr6eWIZ T/aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=LAPLL1Etr4X6H0p32fkloMK+YWS04CQtf0+/cOQk1mU=; b=ywEjWSQL3XB7f2Lkd+WHqHC5Ls8cJaj3MwpDdVsQk03w+uh2Jcl451H01ORooypuYW +Uk5ZZ5Q4pmGBsgYHGYJSXghiHHA6zW5OSDo9JuORp2gYgdtJIEcNBSzSY+iII3Vs0tI 270+eGdxQY4FP742Y0PcmAhVfXh8LnbhXEmOUCHCSsDLPPlnXLaYAayqhFyj+t6+rgaC wQD+nzEIczEG0mC9etUZYTw1dcGIM1xS2co2J+rxChpiA+xRRL0THKnRmXuVW5ovV6UK rqRJeHYPXlyC9yF1UzIS4/MCyLa6ZL0ofDJlATn5LdxU4SUDiYkYhe9PQ7X6lryodUAg rPOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vIHVGT1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x29si11809801edi.61.2020.07.14.07.04.01; Tue, 14 Jul 2020 07:04:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vIHVGT1T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726458AbgGNOBi (ORCPT + 99 others); Tue, 14 Jul 2020 10:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgGNOBh (ORCPT ); Tue, 14 Jul 2020 10:01:37 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8E3CC061755; Tue, 14 Jul 2020 07:01:37 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id ch3so1627393pjb.5; Tue, 14 Jul 2020 07:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LAPLL1Etr4X6H0p32fkloMK+YWS04CQtf0+/cOQk1mU=; b=vIHVGT1TrhoXOkx/9fjfQklH4Vibz4aOwc7msNBTqgYuyrUoEbrtPTb+buKDcFefSe xLWZb5yAeh+KF3XqMZQLWQBtP6NfQlBv+Ks06h66w3KePqP3ovJvU+S80nHVbIfDgkXv F6Ib03hpr0HqEVzvg3+jJATQ4ishv6kxNkCaughd+Uqtmmf0kHb/G7amcAGEtkSuxC/b kpNvR9gbXeAUmg78gOR04CivoC8JL8525d5hMKTtEb4q17L5GE3DXwBxeT28arAQs93D NpC0lYnxTZr2Kb2COqq9IndTR2GcTkjuqZ8az96FjFWKao/uHjgSfHLXLRUij2qg0M+o u6wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LAPLL1Etr4X6H0p32fkloMK+YWS04CQtf0+/cOQk1mU=; b=koNTeqqJllfd/OqORR7GlpWnsQ+rhsDHKVN679v4HxuOkI8dx2xk42OqFDCR+Zyc3b g3yzFsrtHcn7MFH4TCfMjcYMXV/74hPRouhQ6LEjPIBDv95wzzUwccWlw5kzgAIpPncp xpFQObc6hyiUqC0WchiHJQCMCZmcl+EzNeNcwpi6nNj4xVrINHrqzj7e8v8UjOw6cpcz u8ecBbR9opjeQoarPb8jTcU6tb8idiDqiFbgYJ3Xt4IBv/fRr4JDDNgvGp3pT8a1Pz6+ zkKdxVkRHfdQe1KUHwwDClyShFeV7A0VL58jrHpp7KOWZMjVLXHG5YPADlFX3LSBKrrP /9QA== X-Gm-Message-State: AOAM530Ms/Xwyh1UXLajtIGtRZmQX0Lo5dlyvskngixM8eZ1cPsKPley 9V97qEBoIQNJUzonMy66ZMc= X-Received: by 2002:a17:90a:319:: with SMTP id 25mr4957393pje.77.1594735296983; Tue, 14 Jul 2020 07:01:36 -0700 (PDT) Received: from hoboy (c-73-241-114-122.hsd1.ca.comcast.net. [73.241.114.122]) by smtp.gmail.com with ESMTPSA id v8sm2786556pjf.46.2020.07.14.07.01.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 07:01:36 -0700 (PDT) Date: Tue, 14 Jul 2020 07:01:34 -0700 From: Richard Cochran To: Sergey Organov Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fugang Duan , "David S. Miller" , Jakub Kicinski , Vladimir Oltean Subject: Re: [PATCH v2 net] net: fec: fix hardware time stamping by external devices Message-ID: <20200714140134.GA19806@hoboy> References: <20200706142616.25192-1-sorganov@gmail.com> <20200711120842.2631-1-sorganov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200711120842.2631-1-sorganov@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2020 at 03:08:42PM +0300, Sergey Organov wrote: > Fix support for external PTP-aware devices such as DSA or PTP PHY: > > Make sure we never time stamp tx packets when hardware time stamping > is disabled. > > Check for PTP PHY being in use and then pass ioctls related to time > stamping of Ethernet packets to the PTP PHY rather than handle them > ourselves. In addition, disable our own hardware time stamping in this > case. > > Fixes: 6605b73 ("FEC: Add time stamping code and a PTP hardware clock") > Signed-off-by: Sergey Organov > --- > > v2: > - Extracted from larger patch series > - Description/comments updated according to discussions > - Added Fixes: tag Acked-by: Richard Cochran