Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 15:23:24 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     "Martin K. Petersen" <martin.petersen@oracle.com>
Cc:     jejb@linux.ibm.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH v2 05/29] scsi: fcoe: fcoe_ctlr: Fix a myriad of
 documentation issues
Message-ID: <20200714142324.GC1398296@dell>
References: <20200713074645.126138-1-lee.jones@linaro.org>
 <20200713074645.126138-6-lee.jones@linaro.org>
 <yq1lfjmqji1.fsf@ca-mkp.ca.oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <yq1lfjmqji1.fsf@ca-mkp.ca.oracle.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 14 Jul 2020, Martin K. Petersen wrote:

> 
> Lee,

Ah, you are alive.  I was beginning to worry. :)

I have more fixes for you, but didn't want to send them until these
have been merged.

> > @@ -3015,9 +3016,8 @@ static void fcoe_ctlr_disc_recv(struct fc_lport *lport, struct fc_frame *fp)
> >  	fc_frame_free(fp);
> >  }
> >  
> > -/**
> > +/*
> >   * fcoe_ctlr_disc_recv - start discovery for VN2VN mode.
> > - * @fip: The FCoE controller
> >   *
> >   * This sets a flag indicating that remote ports should be created
> >   * and started for the peers we discover.  We use the disc_callback
> 
> s/fcoe_ctlr_disc_recv/fcoe_ctlr_disc_start/ ?

Yes, I spotted it.  Hence my earlier comment to Hannes:

 "Look at the function below it (in your local copy). ;)"

Do you want me to fix that up here as well?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog