Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Pri9Y1iY5evbDoMtzIg4VpqYfB50nykbhW1/Sw4ZbiZod+q1geuWjO86uTFbqNk1NyUHg1oliD
 gWsImO8/6R2A==
IronPort-SDR: HppNEoFOk/fvoZ7X8Y/KMpOxkpML023p/3aVl0pDj6XGRtanwEjVplVXlo1DD9KrUh8qUUeKCT
 Br7I6Ubkl9Rw==
From:   "Ooi, Joyce" <joyce.ooi@intel.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Thor Thayer <thor.thayer@linux.intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Dalon Westergreen" <dalon.westergreen@linux.intel.com>,
        "Tan, Ley Foon" <ley.foon.tan@intel.com>,
        "See, Chin Liang" <chin.liang.see@intel.com>,
        "Nguyen, Dinh" <dinh.nguyen@intel.com>,
        "Westergreen, Dalon" <dalon.westergreen@intel.com>
Subject: RE: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
Thread-Topic: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
Thread-Index: AQHWVPkVfRS7e+4eCk6tElo6txFdaaj+OToAgAj0JEA=
Date:   Tue, 14 Jul 2020 14:35:16 +0000
Message-ID: <CY4PR11MB12537DA07C73574B82A239BDF2610@CY4PR11MB1253.namprd11.prod.outlook.com>
References: <20200708072401.169150-1-joyce.ooi@intel.com>
        <20200708072401.169150-10-joyce.ooi@intel.com>
 <20200708144900.058a8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20200708144900.058a8b25@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.2.0.6
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: ea084ed9-d205-46a6-d87f-08d82803209e
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2020 14:35:16.8599
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ofra6ByhKqI9BqVFpUj7OxqH9klBY2CBZP6O6+iH9fJSzkR1yauIT6Hk2Ex8UjdA+azPXl9Qz+qEC5V3MjaeUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB2040
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, July 9, 2020 5:49 AM
> To: Ooi, Joyce <joyce.ooi@intel.com>
> Cc: Thor Thayer <thor.thayer@linux.intel.com>; David S . Miller
> <davem@davemloft.net>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; Dalon Westergreen
> <dalon.westergreen@linux.intel.com>; Tan, Ley Foon
> <ley.foon.tan@intel.com>; See, Chin Liang <chin.liang.see@intel.com>;
> Nguyen, Dinh <dinh.nguyen@intel.com>; Westergreen, Dalon
> <dalon.westergreen@intel.com>
> Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
>=20
> On Wed,  8 Jul 2020 15:24:00 +0800 Ooi, Joyce wrote:
> > +		/* get prefetcher rx poll frequency from device tree */
> > +		if (of_property_read_u32(pdev->dev.of_node, "rx-poll-
> freq",
> > +					 &priv->rx_poll_freq)) {
> > +			dev_info(&pdev->dev, "Defaulting RX Poll Frequency
> to 128\n");
> > +			priv->rx_poll_freq =3D 128;
> > +		}
> > +
> > +		/* get prefetcher rx poll frequency from device tree */
> > +		if (of_property_read_u32(pdev->dev.of_node, "tx-poll-
> freq",
> > +					 &priv->tx_poll_freq)) {
> > +			dev_info(&pdev->dev, "Defaulting TX Poll Frequency
> to 128\n");
> > +			priv->tx_poll_freq =3D 128;
> > +		}
>=20
> I'm no device tree expert but these look like config options rather than =
HW
> description. They also don't appear to be documented in the next patch.

The poll_freq are part of the msgdma prefetcher IP, whereby it specifies th=
e frequency of descriptor polling operation.
I can add the poll_freq description in the next patch.