Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 23:58:54 +0900
From:   Masami Hiramatsu <mhiramat@kernel.org>
To:     Wei Yongjun <weiyongjun1@huawei.com>
Cc:     Hulk Robot <hulkci@huawei.com>,
        "Steven Rostedt (VMware)" <rostedt@goodmis.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>,
        Arvind Sankar <nivedita@alum.mit.edu>,
        Dominik Brodowski <linux@dominikbrodowski.net>,
        Vlastimil Babka <vbabka@suse.cz>,
        "glider@google.com" <glider@google.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] bootconfig: Make symbol 'xbc_namebuf' static
Message-Id: <20200714235854.e93f1365ca84613887306f62@kernel.org>
In-Reply-To: <20200714142504.34803-1-weiyongjun1@huawei.com>
References: <20200714142504.34803-1-weiyongjun1@huawei.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 14 Jul 2020 22:25:04 +0800
Wei Yongjun <weiyongjun1@huawei.com> wrote:

> Fix sparse build warning:
> 
> init/main.c:305:6: warning:
>  symbol 'xbc_namebuf' was not declared. Should it be static?

Good catch!

Acked-by: Masami Hiramatsu <mhiramat@kernel.org>

Thank you,

> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  init/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 9127b240fd26..6a24981c727f 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -302,7 +302,7 @@ static void * __init get_boot_config_from_initrd(u32 *_size, u32 *_csum)
>  
>  #ifdef CONFIG_BOOT_CONFIG
>  
> -char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
> +static char xbc_namebuf[XBC_KEYLEN_MAX] __initdata;
>  
>  #define rest(dst, end) ((end) > (dst) ? (end) - (dst) : 0)
>  
> 


-- 
Masami Hiramatsu <mhiramat@kernel.org>