Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
In-Reply-To: <20200713050839.GS34333@vkoul-mobl>
Date:   Tue, 14 Jul 2020 12:28:34 -0400
Subject: Re: [PATCH v1 1/1] phy: tusb1210: use bitmasks to set
 VENDOR_SPECIFIC2
From:   "Liam Beguin" <liambeguin@gmail.com>
To:     "Vinod Koul" <vkoul@kernel.org>
Cc:     <kishon@ti.com>, <linux-kernel@vger.kernel.org>
Message-Id: <C46HLW9JFSYI.2YB0NSAHXDI3A@atris>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Vinod,

On Mon Jul 13, 2020 at 10:38 AM Vinod Koul wrote:
> On 01-07-20, 21:06, Liam Beguin wrote:
> > From: Liam Beguin <lvb@xiphos.com>
> >=20
> > Start by reading the content of the VENDOR_SPECIFIC2 register and updat=
e
> > each bit field based on device properties when defined.
> >=20
> > The use of bit masks prevents fields from overriding each other and
> > enables users to clear bits which are set by default, like datapolarity
> > in this instance.
> >=20
> > Signed-off-by: Liam Beguin <lvb@xiphos.com>
> > ---
> >  drivers/phy/ti/phy-tusb1210.c | 29 ++++++++++++++++-------------
> >  1 file changed, 16 insertions(+), 13 deletions(-)
> >=20
> > diff --git a/drivers/phy/ti/phy-tusb1210.c b/drivers/phy/ti/phy-tusb121=
0.c
> > index d8d0cc11d187..a957655ebd36 100644
> > --- a/drivers/phy/ti/phy-tusb1210.c
> > +++ b/drivers/phy/ti/phy-tusb1210.c
> > @@ -13,9 +13,9 @@
> >  #include <linux/phy/ulpi_phy.h>
> > =20
> >  #define TUSB1210_VENDOR_SPECIFIC2		0x80
> > -#define TUSB1210_VENDOR_SPECIFIC2_IHSTX_SHIFT	0
> > -#define TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_SHIFT	4
> > -#define TUSB1210_VENDOR_SPECIFIC2_DP_SHIFT	6
> > +#define TUSB1210_VENDOR_SPECIFIC2_IHSTX_MASK	0x0f
> > +#define TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_MASK	0x30
>=20
> Why not be better and use GENMASK(3, 0) and GENMASK(5, 4) for these
>=20

Will update, I didn't know about GENMASK.

> > +#define TUSB1210_VENDOR_SPECIFIC2_DP_MASK	BIT(6)
> > =20
> >  struct tusb1210 {
> >  	struct ulpi *ulpi;
> > @@ -118,22 +118,25 @@ static int tusb1210_probe(struct ulpi *ulpi)
> >  	 * diagram optimization and DP/DM swap.
> >  	 */
> > =20
> > +	reg =3D ulpi_read(ulpi, TUSB1210_VENDOR_SPECIFIC2);
> > +
> >  	/* High speed output drive strength configuration */
> > -	device_property_read_u8(&ulpi->dev, "ihstx", &val);
> > -	reg =3D val << TUSB1210_VENDOR_SPECIFIC2_IHSTX_SHIFT;
> > +	if (!device_property_read_u8(&ulpi->dev, "ihstx", &val))
> > +		reg =3D (reg & ~TUSB1210_VENDOR_SPECIFIC2_IHSTX_MASK) |
> > +			(val & TUSB1210_VENDOR_SPECIFIC2_IHSTX_MASK);
>=20
> It would be better to use a helper to do this
>=20

I found set_mask_bits(), will use that instead.

> > =20
> >  	/* High speed output impedance configuration */
> > -	device_property_read_u8(&ulpi->dev, "zhsdrv", &val);
> > -	reg |=3D val << TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_SHIFT;
> > +	if (!device_property_read_u8(&ulpi->dev, "zhsdrv", &val))
> > +		reg =3D (reg & ~TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_MASK) |
> > +			(val & TUSB1210_VENDOR_SPECIFIC2_ZHSDRV_MASK);
> > =20
> >  	/* DP/DM swap control */
> > -	device_property_read_u8(&ulpi->dev, "datapolarity", &val);
> > -	reg |=3D val << TUSB1210_VENDOR_SPECIFIC2_DP_SHIFT;
> > +	if (!device_property_read_u8(&ulpi->dev, "datapolarity", &val))
> > +		reg =3D (reg & ~TUSB1210_VENDOR_SPECIFIC2_DP_MASK) |
> > +			(val & TUSB1210_VENDOR_SPECIFIC2_DP_MASK);
> > =20
> > -	if (reg) {
> > -		ulpi_write(ulpi, TUSB1210_VENDOR_SPECIFIC2, reg);
> > -		tusb->vendor_specific2 =3D reg;
> > -	}
> > +	ulpi_write(ulpi, TUSB1210_VENDOR_SPECIFIC2, reg);
> > +	tusb->vendor_specific2 =3D reg;
> > =20
> >  	tusb->phy =3D ulpi_phy_create(ulpi, &phy_ops);
> >  	if (IS_ERR(tusb->phy))
> >=20
> > base-commit: cd77006e01b3198c75fb7819b3d0ff89709539bb
>=20
> fatal: bad object cd77006e01b3198c75fb7819b3d0ff89709539bb in
> linux-phy.git
>=20

Sorry about that, I'll rebase on the latest linux-phy.git

Thanks for your time,
Liam

> --=20
> ~Vinod