Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1892527ybh; Tue, 14 Jul 2020 09:58:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRvHyW29lTt5FsfnsoZ6CYH3oE6pGut4LgjdpsvLXX7786+9Crm8APKMCBwElH663Wzz1h X-Received: by 2002:a50:e883:: with SMTP id f3mr5601660edn.220.1594745937655; Tue, 14 Jul 2020 09:58:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594745937; cv=none; d=google.com; s=arc-20160816; b=sVgLAKRtTt0Ya4qRMs8U5qpdcB6fsme+NBKV0ZDHSYyWGXepuQBNpKA8uUX4huH541 g7QTv29xFqO5D6HqLPFPtznj4nhwjVvZ7u1iGyFmAsCGo430dbNqPJQ4hSYslwLMRT8N 3n9uAJGVU2XTv/frD3axB36jtrybxXboLN9LVoZCnZRYra76WOEFrM87YKe9Q28qHyVP hWW1xYjgg05nidnNwGbB9v2UoaIcWalaGKqQPQv+T56qWpjOj1XjHm9jGtKtFhlW76KT AfElkEXsXBRFKn0zBARmUSR+VhUZVYQzBzzCtB4TyEjl1EE2utRTIXWqM6dMmAgqQajX jwKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XyYLnc+06Gm9dGG/15z3YOVVpur6VHuhn4YtUH4KUP4=; b=pr8r4gCWhF0gzuHYQQjteYFbJW9B3FahLK8WyoGG5lLaMskKzHpswZ2PfEI3ahDQpC wZczot+kLLl/nT5H7pdTFHM30nwz1BxOcDu3LOHKfyGmLy5Fk/txZCSdW2A1gzB2hibx EKFCavkd1qXfAciJbRdn/Shz7u5qUIRPd4S2Fu8ZlP0lSwTTpS9vbhM4xpoAlR6DV//9 DvhCt8gQZb9+To80gBZLrmj2kthC/uKNSNmJ757U3fGenXENkfly/0BWvDIcBw18Kq9J 3bldqwGcXYjR02M/z+muvgT1sYkMJnr6LXyGGL8koK7mE/SBt8ESFgx+CJFw89POaPl7 c/kg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=PJ+wCLEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g15si11677231edy.200.2020.07.14.09.58.31; Tue, 14 Jul 2020 09:58:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=PJ+wCLEC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728170AbgGNQ6F (ORCPT + 99 others); Tue, 14 Jul 2020 12:58:05 -0400 Received: from mail.skyhub.de ([5.9.137.197]:40118 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbgGNQ6F (ORCPT ); Tue, 14 Jul 2020 12:58:05 -0400 Received: from nazgul.tnic (77-85-108-148.ip.btc-net.bg [77.85.108.148]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DF3D81EC0316; Tue, 14 Jul 2020 18:58:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1594745884; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=XyYLnc+06Gm9dGG/15z3YOVVpur6VHuhn4YtUH4KUP4=; b=PJ+wCLEClDd+fP0J4ENiKVXVITYPzB7XKq8JPpkktzi8OAdAmkkxkQfx9d7LfiaSu22rbj oDue+UJO3x9dKHuBYqUiPzvIVC1xz5eQyYI74Vh5LTo0zeCqOkBJWYcPvcPajuVgeZGpQD mz0KM3lwKfmbSDbdgxK/FiRsDvMMXH0= Date: Tue, 14 Jul 2020 18:58:13 +0200 From: Borislav Petkov To: "Luck, Tony" Cc: Chris Down , linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, torvalds@linux-foundation.org, x86@kernel.org, kernel-team@fb.com, Matthew Garrett Subject: Re: [PATCH -v2.1] x86/msr: Filter MSR writes Message-ID: <20200714165813.GB3622@nazgul.tnic> References: <20200615063837.GA14668@zn.tnic> <20200714121955.GA2080@chrisdown.name> <20200714154728.GA3101@nazgul.tnic> <20200714160448.GC2080@chrisdown.name> <20200714164612.GA28474@agluck-desk2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200714164612.GA28474@agluck-desk2.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 09:46:12AM -0700, Luck, Tony wrote: > Maybe we just need smarter filtering of warnings. It doesn't > seem at all useful to warn for the same MSR 1000's of times. > Maybe keep a count of warnings for each MSR and just stop > all reports when reach a threshold? No, not stop - just make them more rare. And this is where the bikeshedding starts about how rare. /me runs away to the beach and lets the others fight it out. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette