Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1928726ybh; Tue, 14 Jul 2020 10:54:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbMPNqgxvldCzH5ANsAcBmbF+Iw6TyDF3pzsN0m3VYkuXGI1kvq/gcBNCzASFN8d6SaMfx X-Received: by 2002:aa7:da06:: with SMTP id r6mr5827540eds.189.1594749285149; Tue, 14 Jul 2020 10:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594749285; cv=none; d=google.com; s=arc-20160816; b=il3xVsAmHvVR9vAfp37kt4kdPqbjchHpf44EWGvuIg9DoXi3Lsn5r01EgtJkbNGuct gl6RZNoBUH72LXpT0jOAoMQHIknYr2xKhe52JIUvQLFi5OpKLKJqIbD6klAkl9E2Wu0P qnTuuz6HaaP+23h3j8cVGxQ7KbNenBZ+BJoZ91uzTwTuLX2TdoBvENgAocA8rDGU1mTw Rz4+gm5edhjUPY28AKgPCpQN+Qxlmr92EUqV3Q5YILaTYpAgCR1hbzS+iThwKPVBCdil Dsy0MBMdqTXllO/teRVeCCWJkHpdtteZLWzJDJKq71CPneIM/GUL3hVFGC6tPXqS+2G4 xm/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=L1XYMeZq8mr3PCvQ6HmM+i0YLB7CkoBZ5IiOpY3WDpg=; b=QA2gOU9PmHGC/W6fqVYLsBD0q/GX7tgWMXB6Pkr7dxv4nznzKP3MEDDVN+vQna3+Lc W8SNASO55W9M4BU34gg3CtdgCBCIkf4zQNyoQhMzkeDIgrS3H6e/bzG7t1dbatnYOE6J rdP8oWpXuGnxP0bXdbEECYxAv8yb12V9iI/7+a8u+pJ0Iu/1baLse/FA9yleLHwlNa1i FoP2HtVcBE78FnFkkVhpGkJoOn/GGjqfFMNLk4qiP9yrGQ5ukaKwR0J+8q9t8ur0XoW2 jh5WNVkt+5HxFa+4ciG7pj4Acpi5W+Rwbv/6O/DmUf5Ya5AoKpCpQmBsMjBfUdSbQiIT O18g== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=lgcb42CL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o21si10364461ejg.550.2020.07.14.10.54.22; Tue, 14 Jul 2020 10:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=lgcb42CL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728999AbgGNRyI (ORCPT + 99 others); Tue, 14 Jul 2020 13:54:08 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:34910 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725951AbgGNRyI (ORCPT ); Tue, 14 Jul 2020 13:54:08 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594749247; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=L1XYMeZq8mr3PCvQ6HmM+i0YLB7CkoBZ5IiOpY3WDpg=; b=lgcb42CL7nF6wkDFrF53h/IGcwlvWp+A6l+d7lRFVlE4tmsYffTPkPWwh4BXWW+uhxfZXlht 5g2IhT0J+KNwmJQGiQFbqz700dqQVAfaQSHAUbwXSWR1o1B/O4qsAbKEdTOa/BHbAvGH6Wma sxZciUpzlhalAMOnWSFWLZDYz2k= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n17.prod.us-east-1.postgun.com with SMTP id 5f0df12a03c8596cdbb3773c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 14 Jul 2020 17:53:46 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E4B7BC4339C; Tue, 14 Jul 2020 17:53:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 04878C433CB; Tue, 14 Jul 2020 17:53:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 04878C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] wilc1000: let wilc_mac_xmit() return NETDEV_TX_OK From: Kalle Valo In-Reply-To: <20200629104009.84077-1-luc.vanoostenryck@gmail.com> References: <20200629104009.84077-1-luc.vanoostenryck@gmail.com> To: Luc Van Oostenryck Cc: Nicolas Ferre , Adham Abozaeid , Ajay Singh , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Luc Van Oostenryck User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200714175344.E4B7BC4339C@smtp.codeaurora.org> Date: Tue, 14 Jul 2020 17:53:44 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Luc Van Oostenryck wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type defining 'NETDEV_TX_OK' but this > driver returns '0' instead of 'NETDEV_TX_OK'. > > Fix this by returning 'NETDEV_TX_OK' instead of '0'. > > Signed-off-by: Luc Van Oostenryck Patch applied to wireless-drivers-next.git, thanks. cce0e08301fe wilc1000: let wilc_mac_xmit() return NETDEV_TX_OK -- https://patchwork.kernel.org/patch/11632291/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches