Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1942458ybh; Tue, 14 Jul 2020 11:12:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy5hnhsWJdYtx/t9YVcFb4gEB+7DforCYJhxAxUjSFGYHpa8xU8BKA1rT85aEej8rbiNciZ X-Received: by 2002:a05:6402:2c5:: with SMTP id b5mr5585768edx.316.1594750378776; Tue, 14 Jul 2020 11:12:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594750378; cv=none; d=google.com; s=arc-20160816; b=HlzbrLu2tF+CdrxBx4hWyqjX2Yxz1OVHOGc7U6/SRUKf01toPd6go7qELobEvXI+cc V7R/aBcQkUIsfArT086/6zAcge/RmNcslPx6Oejdy4fyQVp15z+RdFY96NWLOR4Ln1tf pNcPZF7e2v3IIuguOGXlT2BqlIBM1P5pNnmnQtPmWkeLdBntm/geexCBPCDnbVFpgrBn 4ncYvxK2IFdohRht+K+8K5g6dfJJUpeHlb9i+RXWIiuIbu48DZpzQ1m2ay7MrXw1RqzU pYPgTCgFetXe0drQlYuzqGMibeTnpI6KKT7VHtRxzJ6RCH5CyLzuY9Ir1TRMay74lqkC 33xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=+018opWU1n69mTuUimpwA6LroZay1PBIuxMxVGCW+rs=; b=fcTpEwC4a9hQxd5E1SkUnR7pvVfQ0bKfSM4KZi8sDj0I3H6EFKdQ7sLaJ6MPHlmeKV zoE8JuuQ10NtihcAEohcnL3wC6D3AQj6osuwB+mqnYF2Y3V2IoAWP4BoD2is+k29s5XA 4tS3620UUy3Xj8pxe5GGX3H8fZgzr4IAiSTWOmChXmgEpNol1Tqeuvsg5qQs0dGBI2ec MZHNsEzARAwmXiBbvaOIAfNT5V2GegOvBoyzaqbEuk+0hOlNYbKNiUOZZidYmjVl8IH3 g4YwtZvOQFXOD9mLJsq8lOIGqUOED9T8ec/KDcsXBdMDv6JrztlNyUQwXHTAQ8qYwLmV SWVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=mtBjjCAz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z4si10934700ejw.122.2020.07.14.11.12.33; Tue, 14 Jul 2020 11:12:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=mtBjjCAz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729025AbgGNSMV (ORCPT + 99 others); Tue, 14 Jul 2020 14:12:21 -0400 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:16305 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728117AbgGNSMU (ORCPT ); Tue, 14 Jul 2020 14:12:20 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 14 Jul 2020 11:11:22 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 14 Jul 2020 11:12:20 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 14 Jul 2020 11:12:20 -0700 Received: from [10.26.72.103] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 Jul 2020 18:12:19 +0000 Subject: Re: [PATCH 0/5] firmware: tegra: Add support for in-band debug To: Thierry Reding CC: , References: <20200712100118.13343-1-jonathanh@nvidia.com> <20200714161809.GE251696@ulmo> From: Jon Hunter Message-ID: Date: Tue, 14 Jul 2020 19:12:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200714161809.GE251696@ulmo> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1594750282; bh=+018opWU1n69mTuUimpwA6LroZay1PBIuxMxVGCW+rs=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=mtBjjCAzABAGJHN4xvkUsy/3DRK+Y8oy5GvLCaujWARHCSMmz+c0ix+3SbOWYRjo1 EUvhSM8cL3OIBjnHLk7Wt5+0kA9ho4MxupqYaz1crl8fMk061hmZn4MPxKamxfgdZ6 0kRsnMldg/rF3SvlJYxDoUzvRAVZmkHct1JQwWuZojHrsPgagkDjIxnbVV+ctsMcTh MlPyoO5+Fa1Yrp5wHWVFDV1C5CzJRJy86nB93Y4ZYwF1PMVyakPXZPupBKe/bDiEF4 rANTpaRu3ces4TVXPFO3TDZatAz6/SiEaYXaswBrd9ZBHWsSL2f98jBtI0Aq6RkzMK tjnD7SaIo20VQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/07/2020 17:18, Thierry Reding wrote: > On Sun, Jul 12, 2020 at 11:01:13AM +0100, Jon Hunter wrote: >> This series adds support for in-band debug messaging for the BPMP and >> updates the BPMP ABI to align with the latest version. >> >> Jon Hunter (4): >> firmware: tegra: Use consistent return variable name >> firmware: tegra: Prepare for supporting in-band debugfs >> firmware: tegra: Add support for in-band debug >> firmware: tegra: Update BPMP ABI >> >> Timo Alho (1): >> firmware: tegra: add return code checks and increase debugfs size >> >> drivers/firmware/tegra/bpmp-debugfs.c | 436 ++++++++++-- >> drivers/firmware/tegra/bpmp.c | 6 +- >> include/soc/tegra/bpmp-abi.h | 913 ++++++++++++++++++-------- >> 3 files changed, 1038 insertions(+), 317 deletions(-) > > All applied, thanks. I had to tweak a couple of things to make > checkpatch happy, though. checkpatch also wasn't happy with the ABI > header update, but I left it as-is to make it easier to update in the > future. Thanks. Yes I noticed that as well with the ABI update. I wonder if we should get them to fix that. Jon -- nvpublic