Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] fuse_writepages_fill: simplified "if-else if" constuction
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     linux-fsdevel@vger.kernel.org, Maxim Patlasov <maximvp@gmail.com>,
        Kirill Tkhai <ktkhai@virtuozzo.com>,
        LKML <linux-kernel@vger.kernel.org>
References: <2733b41a-b4c6-be94-0118-a1a8d6f26eec@virtuozzo.com>
 <446f0df5-798d-ab3a-e773-39d9f202c092@virtuozzo.com>
 <CAJfpegv_7nvWoigY-eCX0ny+phWYOz3kEZvYsuGb=u65yMLGHg@mail.gmail.com>
From:   Vasily Averin <vvs@virtuozzo.com>
Message-ID: <0bf36680-d659-9466-9634-92328d1be082@virtuozzo.com>
Date:   Tue, 14 Jul 2020 21:53:18 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.0
In-Reply-To: <CAJfpegv_7nvWoigY-eCX0ny+phWYOz3kEZvYsuGb=u65yMLGHg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [172.16.24.21] (185.231.240.5) by AM0PR04CA0123.eurprd04.prod.outlook.com (2603:10a6:208:55::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3174.21 via Frontend Transport; Tue, 14 Jul 2020 18:53:20 +0000
X-Originating-IP: [185.231.240.5]
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 2fe27f93-bfc3-4d12-d248-08d828272d90
X-MS-TrafficTypeDiagnostic: AM5PR0801MB1940:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <AM5PR0801MB1940139347BB896890AFB09EAA610@AM5PR0801MB1940.eurprd08.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2887;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: BaPnh4j1U4UVsnSe50t0WXlujH2nkePa6HjEaGr7qBGQLDwWsaJkD8jDidUaIlRR3IPyBXgoq80rie+bmsfN1POAQ0ENfk1RDMxh3f19m8QGH0TxT9LN9ibu7AMC52rLSdmFS0o/vNWQSqrhJitSKnTLa6QF3XKg7JfXTq9JI3GzcBfVHHXlmbtz7Tq/ubaZiarj8AhVwDX8ekBq7zIAJSAmq1cKDDVRHnU/2agkCLqXzIAic05nTq8ucQVyi5llNNleCbr1VUi6O1zeERw92r/M1cq6Mkr54ryI6Vw9/eWncMsk8E036IwOkykAVunogxf6xqd0OD3UgdPu9mEHhENJjXbUKeCDO+pebHwiM9OSP23cW/S/tZ+fYwUXDcXB
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR08MB5141.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(396003)(39830400003)(366004)(376002)(346002)(136003)(86362001)(54906003)(8676002)(31696002)(16576012)(66476007)(2906002)(4326008)(52116002)(53546011)(316002)(6486002)(66946007)(66556008)(6916009)(186003)(16526019)(4744005)(26005)(2616005)(956004)(36756003)(478600001)(8936002)(5660300002)(31686004)(43740500002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: oO1s0hfhkfSuk8335UoSQ3XHWSDk/kYs1CoBMztPz6/mJ/6A2S/1prLLjWQuKWF8SqZynKBSU5ywZEII0krYped77s216t/V3PvMfx9VsFE7hruHwZvkWAW/pFKci9QvCOU5W2976kShbdKQvhrK8zIcDVnjJD4V//jtmFagVJhB4gcA6WpLJA/BEZAYaNfMxhguQ0jpP7lieuc3dKVBUirmRvU+sYcngZmNlUbRqQybrKReJYSth7FVXQUUe2qsSSHG6/48zqNQWIpqcuXUNLyAGaMBdLBI/Le3HN0Rdk5UKj54HNaksu8+5WYkhl90UkodeJberDVY+TcY6kbqcYFN1tCcLPp7TgiKJATD5BPK6xSk/VhJwP73blbekZImFTAlNc/JDU3RzVqDDmKdf3EMfGZo5K06EZzEUa8FheMXpCdYS5Rrwws4qunCuTu6qqKSzQRWgKHw9/W9HD+F1hw81FiZ20Stvv4OOG9gZZ4=
X-OriginatorOrg: virtuozzo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2fe27f93-bfc3-4d12-d248-08d828272d90
X-MS-Exchange-CrossTenant-AuthSource: AM6PR08MB5141.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2020 18:53:20.7805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /fE70o2WfdHHw0Jbm1PuiKijXYcgmndNcDkG1I8u2/gAMCEJjgUvD4SY2W3w8KIk7IJnNrOke3q3JMhbmWPSBw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1940
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 7/14/20 3:24 PM, Miklos Szeredi wrote:
> On Thu, Jun 25, 2020 at 11:30 AM Vasily Averin <vvs@virtuozzo.com> wrote:
>>
>> fuse_writepages_fill uses following construction:
>> if (wpa && ap->num_pages &&
>>     (A || B || C)) {
>>         action;
>> } else if (wpa && D) {
>>         if (E) {
>>                 the same action;
>>         }
>> }
>>
>> - ap->num_pages check is always true and can be removed
>> - "if" and "else if" calls the same action and can be merged.
> 
> Makes sense.  Attached patch goes further and moves checking the
> conditions to a separate helper for clarity.

This looks perfect for me, thank you
	Vasily Averin