Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1971104ybh; Tue, 14 Jul 2020 11:59:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNSXzR6a0gT4qHOSxqqO3DfaTsq3YHGPmgQcIu5gCoJVPKz/P6Si9BzDEvFlTEbzPsbVbb X-Received: by 2002:a50:bf09:: with SMTP id f9mr5818341edk.249.1594753141554; Tue, 14 Jul 2020 11:59:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594753141; cv=none; d=google.com; s=arc-20160816; b=B2ON7Te+Ayh6BKvFiPCIAOBPu52khMIuWHP/gHsfD3uBxrVXU6AZosuEyBx9AUJ/AE x5woAVj0uG51/ONf90UEZYw+t9tQV+q31LHL1nmguQP7sBfciYOjxooAo15ARyxcbXY3 tGhNnyqTIA/v8qHYkRAOyja3Ge1oQmajI2lNhg70tp2djVLLGa+LsaFyvkRVw+CV4pGV nrqr+fQbwgwMd6+ZOUY+ieatNSP8pENxan5B5jkJ7eL4zpIq60agwo6jJ2hDusbxkuJn 7FBQINDcxEKsuisQLwM5xcBzadokRxgs/DFbNfZ7AdazVwvt1DhBe0q+y9gwAPpGAev3 LL3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=3SaYdRB+k33q8yq185+PNaqbd8wtf+CKROPAkTovhnc=; b=JKiZbSyHiyGK46gnfOo8HgacwI5EaHT9oTP/A+bU+I/EbtmpHfNWudF803IBN8pd97 1APp3C2LlsAOGHYHciFRJQwCD7qcMLApgYINcvPzxbf+MzLNmjpvC6VCR5Eq+w3DjrQ8 EWjA97DKVN/f1Xiu6ZFwkMkgqy8Bq5Kdy/MCRRX/b8o+ilplFk3LByDOTKDCMoDvS307 tSVKKUqLXscaB1xydHqP4FTyiGKhkqSmKbkXPw47EKOHg9oAUp9TQBk7IgT59NB7ffhq 5LIEg3/c0NMtCdXBgOSlKUG/nE//OpneID9/5K3Ormt5ZcmI9egWpZWBQA1UfWdHg4by SD4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CEB1saT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si11965398edr.168.2020.07.14.11.58.37; Tue, 14 Jul 2020 11:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CEB1saT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730507AbgGNSzh (ORCPT + 99 others); Tue, 14 Jul 2020 14:55:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:53276 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730879AbgGNSzc (ORCPT ); Tue, 14 Jul 2020 14:55:32 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D936222507; Tue, 14 Jul 2020 18:55:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594752932; bh=lFGMtysz5U3UgWxk8qAbvF8pcn57l+N6BjIQ7eXaho0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CEB1saT5dS+iRiifJs96KCeI4aCXl3K2tN+oKS+UNZvPeQCgtvaxTRwpJt5IrsXIb z3M0LnwSsF6hQ2jKrcCZ5O5FDIkw93SAhx1PyTSgp6zZPm3Fzqwgt7AuSQKFARvzRb 0qIKjEOkHQij6CABuWt+u9zoWwhVvR4p8Uo7zHtY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Seevalamuthu Mariappan , Johannes Berg , Sasha Levin Subject: [PATCH 5.7 054/166] mac80211: Fix dropping broadcast packets in 802.11 encap Date: Tue, 14 Jul 2020 20:43:39 +0200 Message-Id: <20200714184118.463503899@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200714184115.844176932@linuxfoundation.org> References: <20200714184115.844176932@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Seevalamuthu Mariappan [ Upstream commit 78fb5b541b7ae57ac39187ccb3097e606004cf9b ] Broadcast pkts like arp are getting dropped in 'ieee80211_8023_xmit'. Fix this by replacing is_valid_ether_addr api with is_zero_ether_addr. Fixes: 50ff477a8639 ("mac80211: add 802.11 encapsulation offloading support") Signed-off-by: Seevalamuthu Mariappan Link: https://lore.kernel.org/r/1591697754-4975-1-git-send-email-seevalam@codeaurora.org Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- net/mac80211/tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c index 82846aca86d96..6ab33d9904eec 100644 --- a/net/mac80211/tx.c +++ b/net/mac80211/tx.c @@ -4192,7 +4192,7 @@ static void ieee80211_8023_xmit(struct ieee80211_sub_if_data *sdata, (!sta || !test_sta_flag(sta, WLAN_STA_TDLS_PEER))) ra = sdata->u.mgd.bssid; - if (!is_valid_ether_addr(ra)) + if (is_zero_ether_addr(ra)) goto out_free; multicast = is_multicast_ether_addr(ra); -- 2.25.1