Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Jul 2020 00:36:02 +0530
From:   Suraj Upadhyay <usuraj35@gmail.com>
To:     Joe Perches <joe@perches.com>
Cc:     Dan Carpenter <dan.carpenter@oracle.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset.
Message-ID: <20200714190602.GA14742@blackclown>
References: <cover.1594642213.git.usuraj35@gmail.com>
 <b5eb87576cef4bf1b968481d6341013e6c7e9650.1594642213.git.usuraj35@gmail.com>
 <20200713141749.GU2549@kadam>
 <a323c1e47e8de871ff7bb72289740cb0bc2d27f8.camel@perches.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="gKMricLos+KVdGMg"
Content-Disposition: inline
In-Reply-To: <a323c1e47e8de871ff7bb72289740cb0bc2d27f8.camel@perches.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--gKMricLos+KVdGMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 14, 2020 at 11:57:23AM -0700, Joe Perches wrote:
> On Mon, 2020-07-13 at 17:17 +0300, Dan Carpenter wrote:
> > On Mon, Jul 13, 2020 at 05:52:22PM +0530, Suraj Upadhyay wrote:
> > > Use direct assignment instead of using memset with just one byte as an
> > > argument.
> > > Issue found by checkpatch.pl.
> > >=20
> > > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com>
> > > ---
> > > Hii Maintainers,
> > > 	Please correct me if I am wrong here.
> > > ---
> > >=20
> > >  drivers/staging/qlge/qlge_ethtool.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > >=20
> > > diff --git a/drivers/staging/qlge/qlge_ethtool.c b/drivers/staging/ql=
ge/qlge_ethtool.c
> > > index 16fcdefa9687..d44b2dae9213 100644
> > > --- a/drivers/staging/qlge/qlge_ethtool.c
> > > +++ b/drivers/staging/qlge/qlge_ethtool.c
> > > @@ -516,8 +516,8 @@ static void ql_create_lb_frame(struct sk_buff *sk=
b,
> > >  	memset(skb->data, 0xFF, frame_size);
> > >  	frame_size &=3D ~1;
> > >  	memset(&skb->data[frame_size / 2], 0xAA, frame_size / 2 - 1);
> > > -	memset(&skb->data[frame_size / 2 + 10], 0xBE, 1);
> > > -	memset(&skb->data[frame_size / 2 + 12], 0xAF, 1);
> > > +	skb->data[frame_size / 2 + 10] =3D (unsigned char)0xBE;
> > > +	skb->data[frame_size / 2 + 12] =3D (unsigned char)0xAF;
> >=20
> > Remove the casting.
> >=20
> > I guess this is better than the original because now it looks like
> > ql_check_lb_frame().  It's still really weird looking though.
>=20
> There are several of these in the intel drivers too:
>=20
> drivers/net/ethernet/intel/e1000/e1000_ethtool.c:       memset(&skb->data=
[frame_size / 2 + 10], 0xBE, 1);
> drivers/net/ethernet/intel/e1000/e1000_ethtool.c:       memset(&skb->data=
[frame_size / 2 + 12], 0xAF, 1);
> drivers/net/ethernet/intel/e1000e/ethtool.c:    memset(&skb->data[frame_s=
ize / 2 + 10], 0xBE, 1);
> drivers/net/ethernet/intel/e1000e/ethtool.c:    memset(&skb->data[frame_s=
ize / 2 + 12], 0xAF, 1);
> drivers/net/ethernet/intel/igb/igb_ethtool.c:   memset(&skb->data[frame_s=
ize + 10], 0xBE, 1);
> drivers/net/ethernet/intel/igb/igb_ethtool.c:   memset(&skb->data[frame_s=
ize + 12], 0xAF, 1);
> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:       memset(&skb->data=
[frame_size + 10], 0xBE, 1);
> drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:       memset(&skb->data=
[frame_size + 12], 0xAF, 1);
> drivers/staging/qlge/qlge_ethtool.c:    memset(&skb->data[frame_size / 2 =
+ 10], 0xBE, 1);
> drivers/staging/qlge/qlge_ethtool.c:    memset(&skb->data[frame_size / 2 =
+ 12], 0xAF, 1);

Thanks to point this out,
	I will be sending a patchset for that soon.

Thanks,

Suraj Upadhyay.


--gKMricLos+KVdGMg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE7AbCa0kOsMJ4cx0j+gRsbIfe744FAl8OAhIACgkQ+gRsbIfe
747ELBAAs7FgNTJ7W3h+3hC9u3/hxXbKnaUFn2p3NN9jueyMmRLgluBEOL2QrAg0
N7P6fqH88bOdPlD/j0qWnQphByOOc2/9JybZX3SSO/3xW8EikjguS51TAvL9KqII
rq4j9p1YbTkldB/Tv45oi3d1XRG49yKZJVufuMj8IFs7KGaiLpoZORIEeCprPrto
XGGch3crDCjqqDWf5Fb1EAVpDVvhlvLrBN2N25ZBklJ+45mS0/LlxapYcRX7uuDr
tqrXRNCjjOmwgBunvdgnmFEtXpcPevtCuSVjOmxH+r416yATcd9aGA1nii6OV1xo
p+vuoxeKxH0XMuQHkp+dY1pYyQTXrHpag4WnU8kZfVaml1sapsl87EYWM947iRR2
wILTcwjeTTGfwuVcNCLJx4NbuoEU7NbDJTkfu1FViQjInjBFSd4+jeTiFDxHKwQ+
J2JnJDRH/qTABra3zFpm4fTcMg6FxkF7MRZvCqtYhX18rVSWT6e8cWxmXiMelAlw
7RASpBrGF06kcLch/ML9kLdPrcvDMNYUHqPYlQPIfnv2KW2PWOalw1SvvTwwYL86
JE+AIa8cMVStylKFoEyNdfIadSjBRp5TtZcJpKBBL2A4eUlyF2P0KopArMgEdjVb
vHZhqJ1Gx3SlYewwRCNo31gxrGy83ol+/+6UsJY/j18ooV3AnQs=
=ZTrI
-----END PGP SIGNATURE-----

--gKMricLos+KVdGMg--