Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp2023086ybh;
        Tue, 14 Jul 2020 13:30:28 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJxgI+/U6MJnu4HCb7zTf36CJLyz2+3DxBMIGgztlqVN7DYAab5LREbPbexnCnoXt2hHcUl0
X-Received: by 2002:a17:906:4b16:: with SMTP id y22mr6328710eju.4.1594758627909;
        Tue, 14 Jul 2020 13:30:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1594758627; cv=none;
        d=google.com; s=arc-20160816;
        b=mMDonvY1Zgf9hoCpPMSTsrHTcCRzQLdE9Nd9AlM07LLHs89n9W6tZri+jQNE91ZAIX
         Jlh5gbqD8Q48dHKBi6oOM9rSoMmRrMl8ijnvarEQEZg1EVAxlzY6mLiuHwZu5SCfOQeg
         /H3soXu/ZDtytPG47bBlHheVNKe+iscj8uLQvAfp3elW+Twp4LG16DPSGKUlW/Wopx5l
         mpFHo0XE9FKHL9A1hwBeOpvHBQG/wcbfAtW9w3GMrfH6BqyZxP3wVvMYlJuuTICT+MID
         NjO9iBVNXKFF/DqgRh+XOgQEErmeqqY23xLpOI46vVbZbzVMVH9SYc4Mu8JhPuNuR6P8
         YsHg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=V82J4NLHhDwXwmVxfgZQjdNjgwO8IleYbrxrmPKLDLY=;
        b=FrpMM2CI6cdcBbNBFgAxHbQpIQwFtqe1s2v8U0nag0bY0eQRwSHVXhT/TRgRWqeFjJ
         SWKkBn65leB5D6N75AQ7TUFd9OIMsmtX78UjlzunpWLq8S9bobrSemT0myroqTCBg4HN
         RSaaZBJPeENfQmyqXeh6qhYrKYJvhn+Owzey2Hwj0lY4RVSdJpZwNZb/CNWcdmHgEgrq
         y0keIDTsZ7uJ86gAYo2G6wAkLRsIz6+CWyt6mN7r9hJ8dnFmoYUOJGfCDUKJyoJUK6De
         N1v33WfoPpIb49a/w9gDiCLpwvlVQD5FlPy0n8LV1AklSa3fyBCrHatTdJoZjhpNaXce
         wbUg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r20si11463019edy.598.2020.07.14.13.30.05;
        Tue, 14 Jul 2020 13:30:27 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726546AbgGNUYB (ORCPT <rfc822;1990.zhangzhen@gmail.com>
        + 99 others); Tue, 14 Jul 2020 16:24:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53676 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725877AbgGNUYA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 14 Jul 2020 16:24:00 -0400
Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0F71C061794;
        Tue, 14 Jul 2020 13:24:00 -0700 (PDT)
Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 1E96115E18275;
        Tue, 14 Jul 2020 13:23:58 -0700 (PDT)
Date:   Tue, 14 Jul 2020 13:23:55 -0700 (PDT)
Message-Id: <20200714.132355.1352071851569568246.davem@davemloft.net>
To:     dalon.westergreen@intel.com
Cc:     kuba@kernel.org, mkubecek@suse.cz, ley.foon.tan@intel.com,
        chin.liang.see@intel.com, dinh.nguyen@intel.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        joyce.ooi@intel.com, thor.thayer@linux.intel.com
Subject: Re: [PATCH v4 09/10] net: eth: altera: add msgdma prefetcher
From:   David Miller <davem@davemloft.net>
In-Reply-To: <9a8ba2616f72fb44cdc3b45fabfb4d7bdf961fd0.camel@intel.com>
References: <3bcb9020f0a3836f41036ddc3c8034b96e183197.camel@intel.com>
        <20200714092903.38581b74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
        <9a8ba2616f72fb44cdc3b45fabfb4d7bdf961fd0.camel@intel.com>
X-Mailer: Mew version 6.8 on Emacs 26.3
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 14 Jul 2020 13:23:58 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: "Westergreen, Dalon" <dalon.westergreen@intel.com>
Date: Tue, 14 Jul 2020 18:51:15 +0000

> I don't think this is necessary, i think just having a module parameter
> meets our needs.  I don't see a need for the value to change on a per
> interface basis.  This was primarily used during testing / bringup.

Please no module parameters...