Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 14 Jul 2020 15:08:16 -0600
From:   Rob Herring <robh@kernel.org>
To:     Iskren Chernev <iskren.chernev@gmail.com>
Cc:     Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht,
        Jonathan Bakker <xc-racer2@live.ca>,
        Vladimir Barinov <vladimir.barinov@cogentembedded.com>
Subject: Re: [PATCH v3 2/6] dt-bindings: power: supply: Extend max17040
 compatibility
Message-ID: <20200714210816.GA2918005@bogus>
References: <20200624155633.3557401-1-iskren.chernev@gmail.com>
 <20200624155633.3557401-3-iskren.chernev@gmail.com>
 <20200713190310.GA546410@bogus>
 <c4dc5045-48ee-a27b-98a8-22fdb37d6ba9@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c4dc5045-48ee-a27b-98a8-22fdb37d6ba9@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jul 14, 2020 at 11:49:44AM +0300, Iskren Chernev wrote:
> 
> On 7/13/20 10:03 PM, Rob Herring wrote:
> > On Wed, Jun 24, 2020 at 06:56:29PM +0300, Iskren Chernev wrote:
> >> Maxim max17040 is a fuel gauge from a larger family utilising the Model
> >> Gauge technology. Document all different compatible strings that the
> >> max17040 driver recognizes.
> >>
> >> Some devices in the wild report double the capacity. The
> >> maxim,double-soc (from State-Of-Charge) property fixes that.
> >>
> >> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> >> ---
> >>? .../bindings/power/supply/max17040_battery.txt??? | 15 ++++++++++++++-
> >>? 1 file changed, 14 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> index 4e0186b8380fa..554bce82a08e6 100644
> >> --- a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt
> >> @@ -2,7 +2,9 @@ max17040_battery
> >>? ~~~~~~~~~~~~~~~~
> >>
> >>? Required properties :
> >> - - compatible : "maxim,max17040" or "maxim,max77836-battery"
> >> + - compatible : "maxim,max17040", "maxim,max17041", "maxim,max17043",
> >> + ?? ??? ?"maxim,max17044", "maxim,max17048", "maxim,max17049",
> >> +?? ??? ?"maxim,max17058", "maxim,max17059" or "maxim,max77836-battery"
> >>?? - reg: i2c slave address
> >>
> >>? Optional properties :
> >> @@ -11,6 +13,10 @@ Optional properties :
> >> ??? ??? ??? ??? ?generated. Can be configured from 1 up to 32
> >> ??? ??? ??? ??? ?(%). If skipped the power up default value of
> >> ??? ??? ??? ??? ?4 (%) will be used.
> >> +- maxim,double-soc : ?? ??? ?Certain devices return double the capacity.
> >> +?? ??? ??? ??? ?Specify this boolean property to divide the
> >> +?? ??? ??? ??? ?reported value in 2 and thus normalize it.
> >> +?? ??? ??? ??? ?SOC == State of Charge == Capacity.
> >
> > This can't be implied by the compatible string?
> >
> 
> >From what I can tell - no. Here are multiple examples of downstream code:

Okay,

Reviewed-by: Rob Herring <robh@kernel.org>