Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200713144930.1034632-1-lee.jones@linaro.org> <20200713144930.1034632-11-lee.jones@linaro.org>
In-Reply-To: <20200713144930.1034632-11-lee.jones@linaro.org>
From:   Sean Wang <sean.wang@kernel.org>
Date:   Tue, 14 Jul 2020 14:21:54 -0700
Message-ID: <CAGp9LzoQVPPPgoBVYeLTuTsWjS_Ug48wjTDh=Pk3KWdpFrLiaQ@mail.gmail.com>
Subject: Re: [PATCH 10/25] pinctrl: mediatek: pinctrl-mtk-common-v2: Mark
 'mtk_default_register_base_names' as __maybe_unused
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 13, 2020 at 7:49 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> Not all sourcefiles which end up including pinctrl-mtk-common-v2.h make u=
se
> of 'mtk_default_register_base_names' and there is nowhere we can place th=
e
> definition to void the need for __maybe_unused except its own headerfile,
> which seems like overkill.  So instead we tell the compiler that it's oka=
y
> for it to be unused by some of the consumers.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  In file included from drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c:1=
9:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/pinctrl/mediatek/pinctrl-moore.h:25,
>  from drivers/pinctrl/mediatek/pinctrl-moore.c:12:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
>  from drivers/pinctrl/mediatek/pinctrl-paris.c:15:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
>  from drivers/pinctrl/mediatek/pinctrl-mtk-mt6797.h:15,
>  from drivers/pinctrl/mediatek/pinctrl-mt6797.c:13:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
>  from drivers/pinctrl/mediatek/pinctrl-mtk-mt8183.h:12,
>  from drivers/pinctrl/mediatek/pinctrl-mt8183.c:9:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>  In file included from drivers/pinctrl/mediatek/pinctrl-paris.h:27,
>  from drivers/pinctrl/mediatek/pinctrl-mtk-mt6765.h:12,
>  from drivers/pinctrl/mediatek/pinctrl-mt6765.c:10:
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h:83:27: warning: =E2=80=
=98mtk_default_register_base_names=E2=80=99 defined but not used [-Wunused-=
const-variable=3D]
>  83 | static const char const mtk_default_register_base_names[] =3D {
>  | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> Cc: Sean Wang <sean.wang@kernel.org>
> Cc: Matthias Brugger <matthias.bgg@gmail.com>
> Cc: linux-mediatek@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Those MediaTek SoCs with multiple register bases wouldn't refer to the arra=
y
Acked-by: Sean Wang <sean.wang@kernel.org>

> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.h | 2 +-