Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Kor1lgqUM0jUOBz+UG6tioKzLUwd4GjAae0IGxK2pLvovYJ3yAUtIOywfCJDPXXl4WJGlLN1Ly
 ZWJoISx4Vzfw==
IronPort-SDR: Go80DYoOa+jgCvzUJ8c8qVgmU4RYBMo5yNdEeYJXx1Q0+44kELwwdx2JGTitw+q18rqebtLFFK
 S5ELISaY54uQ==
Subject: Re: [PATCH v2 3/4] x86: Expose SERIALIZE for supported cpuid
To:     hpa@zytor.com,
        Sean Christopherson <sean.j.christopherson@intel.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org,
        pbonzini@redhat.com, vkuznets@redhat.com, wanpengli@tencent.com,
        jmattson@google.com, joro@8bytes.org, tglx@linutronix.de,
        mingo@redhat.com, bp@alien8.de,
        ricardo.neri-calderon@linux.intel.com, kyung.min.park@intel.com,
        jpoimboe@redhat.com, gregkh@linuxfoundation.org,
        ak@linux.intel.com, dave.hansen@intel.com, tony.luck@intel.com,
        ravi.v.shankar@intel.com
References: <1594088183-7187-1-git-send-email-cathy.zhang@intel.com>
 <1594088183-7187-4-git-send-email-cathy.zhang@intel.com>
 <20200714030047.GA12592@linux.intel.com>
 <80d91e21-6509-ff70-fb5a-5c042f6ea588@intel.com>
 <3EFFDE4B-7844-4BB3-A824-487EE8359376@zytor.com>
From:   "Zhang, Cathy" <cathy.zhang@intel.com>
Message-ID: <e24f5802-5187-956c-80ad-a4cc8f66a261@intel.com>
Date:   Wed, 15 Jul 2020 08:03:31 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <3EFFDE4B-7844-4BB3-A824-487EE8359376@zytor.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/15/2020 7:05 AM, hpa@zytor.com wrote:
> On July 14, 2020 3:42:08 PM PDT, "Zhang, Cathy" <cathy.zhang@intel.com> wrote:
>> On 7/14/2020 11:00 AM, Sean Christopherson wrote:
>>> On Tue, Jul 07, 2020 at 10:16:22AM +0800, Cathy Zhang wrote:
>>>> SERIALIZE instruction is supported by intel processors,
>>>> like Sapphire Rapids. Expose it in KVM supported cpuid.
>>> Providing at least a rough overview of the instruction, e.g. its
>> enumeration,
>>> usage, fault rules, controls, etc... would be nice.  In isolation,
>> the
>>> changelog isn't remotely helpful in understanding the correctness of
>> the
>>> patch.
>> Thanks Sean! Add it in the next version.
>>>> Signed-off-by: Cathy Zhang <cathy.zhang@intel.com>
>>>> ---
>>>>    arch/x86/kvm/cpuid.c | 3 ++-
>>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/x86/kvm/cpuid.c b/arch/x86/kvm/cpuid.c
>>>> index 8a294f9..e603aeb 100644
>>>> --- a/arch/x86/kvm/cpuid.c
>>>> +++ b/arch/x86/kvm/cpuid.c
>>>> @@ -341,7 +341,8 @@ void kvm_set_cpu_caps(void)
>>>>    	kvm_cpu_cap_mask(CPUID_7_EDX,
>>>>    		F(AVX512_4VNNIW) | F(AVX512_4FMAPS) | F(SPEC_CTRL) |
>>>>    		F(SPEC_CTRL_SSBD) | F(ARCH_CAPABILITIES) | F(INTEL_STIBP) |
>>>> -		F(MD_CLEAR) | F(AVX512_VP2INTERSECT) | F(FSRM)
>>>> +		F(MD_CLEAR) | F(AVX512_VP2INTERSECT) | F(FSRM) |
>>>> +		F(SERIALIZE)
>>>>    	);
>>>>    
>>>>    	/* TSC_ADJUST and ARCH_CAPABILITIES are emulated in software. */
>>>> -- 
>>>> 1.8.3.1
>>>>
> At least that one is easy: SERIALIZE is architecturally a NOP, but with hard serialization, like CPUID or IRET.
SERIALIZE does not modify registers, arithmetic flags or memory, which 
is different with CPUID.