Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317AbWEDPfv (ORCPT ); Thu, 4 May 2006 11:35:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932335AbWEDPfv (ORCPT ); Thu, 4 May 2006 11:35:51 -0400 Received: from mx2.suse.de ([195.135.220.15]:18127 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S932317AbWEDPfu (ORCPT ); Thu, 4 May 2006 11:35:50 -0400 Date: Thu, 4 May 2006 08:34:11 -0700 From: Greg KH To: Michael Holzheu Cc: Andrew Morton , ioe-lkml@rameria.de, joern@wohnheim.fh-wedel.de, linux-kernel@vger.kernel.org, mschwid2@de.ibm.com, penberg@cs.helsinki.fi Subject: Re: [PATCH] s390: Hypervisor File System Message-ID: <20060504153411.GA27485@kroah.com> References: <20060504144259.GA26668@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1251 Lines: 38 On Thu, May 04, 2006 at 05:01:07PM +0200, Michael Holzheu wrote: > Hi Greg, > > Greg KH wrote on 05/04/2006 04:42:59 PM: > > > I would suggest do do it like /sys/kernel and put the code > > > into kernel/ksysfs.c and include/linux/kobject.h > > > > No, if you do that then every kernel gets that mount point, when almost > > no one really wants it :) > > > > If you leave it as a separate file, then the build system can just > > include the file as needed. > > > > So you want a new config option CONFIG_HYPERVISOR? Sure. But don't make it a user selectable config option, but rather, one your S390 option sets. That way the Xen and other groups can also set it when they need it. > When no one except for us wants it, wouldn't it be best > then to create /sys/hypervisor first in the hypfs code? > > If someone else needs it in the future, we still can move > it common code. The Xen people need it too. Now who knows when their code will ever hit mainline... thanks, greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/