Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp213205ybh; Tue, 14 Jul 2020 23:23:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyT21PxIcJXvYzx/xdxP6nuLUfNq1D60JvwRV+z/9cgNDBCjJdwZ4VSCHt51Oeaw/tx8z0h X-Received: by 2002:aa7:c2d7:: with SMTP id m23mr8069249edp.216.1594794228933; Tue, 14 Jul 2020 23:23:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594794228; cv=none; d=google.com; s=arc-20160816; b=i7iMvyUS4xv2AkBCIsraeDKG30XAEzCCFPF+rEbhzsnd2igvSWdZTUlKtv3ccrtKQg a4KdLe01NhuwSRc3gWXlzYm20jgmSv2hcOV+nNqR7Hc7bO5hykkEZLHuQ1ESLiYJvaXm he2y4sohxAlhlKIg+2LBl+M17zrlaY9pWGeJg9doMoSbhQriaLhPui8sVF706XnZr+jg MkWeB2yiPmOu/5lfSkmA4O7NK/HbUEbLuipB29BSEUvOVh0h8RnHrPuH30PvZ3EjeHTu Nu0MyKGOw/+s3IWoTq+22Jj4bZqfIh5r2Y/5EXwWYrk0CgAVHh/ZFR5JD7MY/906XAff ypgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=AflODhx1YbztB70bPT5qv25eeiW4vfNm1U/V5HJuZPQ=; b=B/uVhbxFWqfdRNrZ4PmojSOMVZsHo4Z8sEBwI97P5yIZRGsgRvr0OpAndPJ/YNCzi7 Xrusbqi7fAMrZKMOHGMF3j3fhHFY4QZsluuQvy2shmPbBL0mb+CFv3KuygNgCSJmETeA NqHnqVTxuLEOXe+ytTkgl4vlLJg1N+1TUZ9UfPMh514CxEulzHCp1FnCzSSaCpoz80ne ox9BM//kJdJep+4+O7AAKvt5NNxwcQ9j+R+4HNMYd16Td+/2NChwH8XE6Zq0CXnFg7bD R9HxlfUF82slZ7FaSMVUr0El+2nnk1zTZx+WNicGG8NmHX1x1nAqJIQZm1Wlwvc3urdd JXxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ccBKPEH3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v14si684563eje.123.2020.07.14.23.23.25; Tue, 14 Jul 2020 23:23:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ccBKPEH3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbgGOF5Q (ORCPT + 99 others); Wed, 15 Jul 2020 01:57:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:54408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbgGOF5P (ORCPT ); Wed, 15 Jul 2020 01:57:15 -0400 Received: from localhost (unknown [122.171.202.192]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 062C220663; Wed, 15 Jul 2020 05:57:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594792635; bh=sh/y6Tv58ZbvejAQoIQ7VjPDPdiVI5suGLxy8ixlw/o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ccBKPEH3rQXWo6yxYXS2I2Zlg2bQpnTixf+T723Cut6K23obwSGs8LC/tGlIcQMhh tRvVtjy4pdNc9vNYYLz3mV77xwIpzia10DvfB0RHR5uP/CP2ZPcyWHVDuB2iSvoR1u OJ0W3dyzkgKGrnKDO4/kalcaLUs9xZJFNlP/+B/A= Date: Wed, 15 Jul 2020 11:27:11 +0530 From: Vinod Koul To: Robin Gong Cc: mark.rutland@arm.com, broonie@kernel.org, robh+dt@kernel.org, catalin.marinas@arm.com, will.deacon@arm.com, shawnguo@kernel.org, festevam@gmail.com, s.hauer@pengutronix.de, martin.fuzzey@flowbird.group, u.kleine-koenig@pengutronix.de, dan.j.williams@intel.com, matthias.schiffer@ew.tq-group.com, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, dmaengine@vger.kernel.org, linux-imx@nxp.com Subject: Re: [PATCH v10 05/12] dmaengine: dma: imx-sdma: add fw_loaded and is_ram_script Message-ID: <20200715055711.GW34333@vkoul-mobl> References: <1593523876-22387-1-git-send-email-yibin.gong@nxp.com> <1593523876-22387-6-git-send-email-yibin.gong@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1593523876-22387-6-git-send-email-yibin.gong@nxp.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30-06-20, 21:31, Robin Gong wrote: > Add 'fw_loaded' and 'is_ram_script' to check if the script used by channel > is ram script and it's loaded or not, so that could prevent meaningless > following malloc dma descriptor and bd allocate in sdma_transfer_init(), > otherwise memory may be consumed out potentially without free in case > that spi fallback into pio while dma transfer failed by sdma firmware not > ready(next ERR009165 patch depends on sdma RAM scripts/firmware). Acked-By: Vinod Koul -- ~Vinod