Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp219925ybh; Tue, 14 Jul 2020 23:37:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYmAMsd7oVAC3Pti4FfuaL0y6Chnv9no5awbNsiYv1aDLAoBfhPwqIaBK1striDin72Gii X-Received: by 2002:a17:906:4356:: with SMTP id z22mr8123514ejm.414.1594795057627; Tue, 14 Jul 2020 23:37:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594795057; cv=none; d=google.com; s=arc-20160816; b=gKIy5xd25+HdXmHhKYmT1xnPus8lAchY2+Ql6hmjO9eKHnFKnZbmFDeBTRj+fp971x QTeyRab/Q+SMrrPCFpky7cNjKIOHFKxtO484+NTlWTxKjBigqMtv8atodS1lIRikhenq C/q4YKDZx4LSsejqBijNsePySnxC6wkOkpkDbxvCzqMG1GMLO6try0ikc73xc4acp6y1 Yndz/+mRlm5mqwEHk0kMNaRfMkdJ/bWPZOygsRcxILH6VX/9oIGjXGh7IowtIT16lT4r WGWwPhpL0eZlFugCdvg4nz1QW+2wHYjw6qMRlhSmVSbhPnFhJWBHDJxSty2Wt29dSiIx DmVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=7/7YlCQQS4NfdI2cjoTLRwj8KZpvs8wrGSrY0FMkPh0=; b=SdU8DWNIDbit71NkBxAJ/ee7+kgMlWQqNJOHEsMkN7NTXG1T+NMY07S2WLx8hBSqU7 YAPEhd4djl/iW9BDSgfQX4HqGL/KRpFmoldK5+3v3dYGsOJjKgah85p6+zRoY8QK2B2V 6MfjxfVHRlvR/fBnKuWkDC/aRDQdLa33dascRyap0cRUypyXZOEpmEmJPhA4UKVk5ewU zejShsqSgt5vsJVFGI4EhzUt51IqRZ6lWqxUcuh25/OpbdYCcf/FOvCHvFWhlT77XtK6 aRC+UmHSFyKdCcNqszjjkci5QVhQrYf/LDPx+z8+LiFmQBOgjekd4vrJkD2JA/8j6Vh4 C3uQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n5si719135ejc.171.2020.07.14.23.37.13; Tue, 14 Jul 2020 23:37:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728781AbgGOGgo (ORCPT + 99 others); Wed, 15 Jul 2020 02:36:44 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:54119 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728170AbgGOGgn (ORCPT ); Wed, 15 Jul 2020 02:36:43 -0400 Received: by mail-wm1-f67.google.com with SMTP id j18so4154447wmi.3 for ; Tue, 14 Jul 2020 23:36:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7/7YlCQQS4NfdI2cjoTLRwj8KZpvs8wrGSrY0FMkPh0=; b=auYB1ZrHE+hLA2QLYSMZCKP28XdnqsbplFy86fYIxJRVCIBanEKafGrrMGjI+iSzyU nPKmMReFyEoOIo/IDz3Slmj92b1n4eBTRZukc81zSw8pgOwmfRZbKWkB8blPniiZSksq QRwx45UBfyZx/EPQ3mSAadhAUc3MCdeSCzYrYMyjf4gll3aZLgm1PHBrlijoRzwsWd67 SV9PZjCSN2vVQwx3moQx5P77ZgfkRme8jlA23aM0LWi4ncb1jA6ovxHWOacMzkhEvrbf Qkb26bVeeHXWM7tSzrFlLXBCHGnar2bQ034bYsS76Z9c+/oeuoj/7CC1hPHR9r1LmWRC Fqug== X-Gm-Message-State: AOAM533XIZuLu6qAenkeL6OaaxiCM7WSl0E84LsQ/p9l4dH35aigkY6r Zp+3Gz/JmH1+S0+Po5E20Og= X-Received: by 2002:a7b:cf18:: with SMTP id l24mr7024055wmg.116.1594795001964; Tue, 14 Jul 2020 23:36:41 -0700 (PDT) Received: from localhost (ip-37-188-169-187.eurotel.cz. [37.188.169.187]) by smtp.gmail.com with ESMTPSA id u16sm1896668wmn.11.2020.07.14.23.36.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jul 2020 23:36:41 -0700 (PDT) Date: Wed, 15 Jul 2020 08:36:39 +0200 From: Michal Hocko To: Suren Baghdasaryan Cc: Todd Kjos , Hridya Valsaraju , Hillf Danton , Eric Biggers , syzbot , Andrew Morton , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Christian Brauner , "open list:ANDROID DRIVERS" , Greg Kroah-Hartman , Hugh Dickins , "Joel Fernandes (Google)" , LKML , Linux-MM , Martijn Coenen , syzkaller-bugs , Todd Kjos , Markus Elfring Subject: Re: possible deadlock in shmem_fallocate (4) Message-ID: <20200715063639.GA5451@dhcp22.suse.cz> References: <0000000000000b5f9d059aa2037f@google.com> <20200714033252.8748-1-hdanton@sina.com> <20200714053205.15240-1-hdanton@sina.com> <20200714140859.15156-1-hdanton@sina.com> <20200714141815.GP24642@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 14-07-20 10:32:20, Suren Baghdasaryan wrote: [...] > I'm not sure how we can annotate the fact that the inode_lock in > generic_file_write_iter and in shmem_fallocate always operate on > different inodes. Ideas? I believe that the standard way is to use lockdep_set_class on your backing inode. But asking lockdep experts would be better than relying on my vague recollection -- Michal Hocko SUSE Labs