Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Jul 2020 09:22:42 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rob Herring <robh+dt@kernel.org>
Cc:     Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch.pl: Allow '+' in compatible strings
Message-ID: <20200715072242.GA321038@ulmo>
References: <20200714094141.147418-1-thierry.reding@gmail.com>
 <CAL_Jsq+c5+QFpdiNK4K=ROPAhxp=SMYS6iRFuJKooin=NbCiXw@mail.gmail.com>
 <8d7ebe02cfbff19f31f6ac1ce098f98d8ba1850a.camel@perches.com>
 <CAL_Jsq+HUUXRVoLN1OH3YXNYG=z4jyBJu_Z9qMb6L3K6vwXZiA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2"
Content-Disposition: inline
In-Reply-To: <CAL_Jsq+HUUXRVoLN1OH3YXNYG=z4jyBJu_Z9qMb6L3K6vwXZiA@mail.gmail.com>
User-Agent: Mutt/1.14.4 (2020-06-18)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--UlVJffcvxoiEqYs2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 14, 2020 at 11:42:15AM -0600, Rob Herring wrote:
> On Tue, Jul 14, 2020 at 11:12 AM Joe Perches <joe@perches.com> wrote:
> >
> > On Tue, 2020-07-14 at 10:21 -0600, Rob Herring wrote:
> > > On Tue, Jul 14, 2020 at 3:41 AM Thierry Reding <thierry.reding@gmail.=
com> wrote:
> > > > From: Thierry Reding <treding@nvidia.com>
> > > >
> > > > The current checks will interpret a '+' character as special because
> > > > they use regular expression matching. Escape the '+' character if it
> > > > appears in a compatible string.
> > >
> > > Ugg, looks like c6x really liked using '+'. Might need to be added in
> > > schema checks, too. Not sure offhand.
> >
> > These are the non alphanumeric characters used in .dts and .dtsi files
> > with 'compatible=3D' strings
> >
> > - 44115
> > , 32035
> > . 1131
> > _ 259
> > + 46
> > / 18
> > ) 5
> > ( 5
> >
> > So it looks like
> >
> >         "("
> >         ")"
> >
> > need to be added and escaped too
> >
> > ?
>=20
> No, those are 'regulator-compatible' AFAICT which is something else
> and deprecated.

Looks like we do need to escape the '.' character as well, although it
should be mostly harmless if we don't since '.' in the regex would also
match a literal '.' in the compatible string.

Thierry

--UlVJffcvxoiEqYs2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl8Orr8ACgkQ3SOs138+
s6GTIQ/8D7AQ4ufdVorOZaawWFBkZehfkNBtNxxl8hk/80pZILMLHcqPLhlx2cfa
erlVP2/W4vdfd3DpJZ9NBnTu+1PpKMkYrhhF257v1crv/6Y1qro+TXzfOFDNqS7m
US0ed6NUZM1Jeo0DR/n0oj5+uvaVCSLNth1llL7dzGab+SNaJKYYisj/NbPNw/9W
7SgfEOg0uwY/3A2gvfFRteymaRdGs/iPpd0fXYlr+SEnw5akjwL4IS8/WLmRGfpC
9GcnUJCBhtSyy1jmZqc0wg46K1SDqHGh5sb8vKeaYGpUScZJGiXd4EdLDB3qFhjA
WOLSdDPV/nmmhC7TJ5dQ3iV2oxfQ/HBUnFZ82+lxD+2zQfDNUGsx3VI3nHtF9/e+
jhe1oJxYtsIs8p3mddFvAK44s2logaIfD3dQF0RlgX2q7PreqdhTxXTvT1Pgh0IN
mqCr6ZoeHVdZHaQF+6ntoXna1Mb/D9eDw6mPnJq9xP0qKOG4gJB136EorP/g58xy
kTRHArzFqVTw0cQvu15g/rgapwUjcmktUMcxWHueDImXX3utSUG02pu0eC8Nd9fJ
fpqTPoj96ycxbdA1EB0hfiXxdWPgRpt30KNvFfhOI+nQuT4VlP4Fk1GQi9jNzH4S
sOQqYQdEadtjheWZIKWMYG+tCmGV9K1ATAhyVN2AhAOEYbIImYQ=
=Irhq
-----END PGP SIGNATURE-----

--UlVJffcvxoiEqYs2--