Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp251798ybh; Wed, 15 Jul 2020 00:41:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1y3MjZIdae8mvay5rx/QQToS5mgwDTMWYJpsi8n8rUp9+W0gACv3RBq65eS4BmdAjF3sB X-Received: by 2002:a05:6402:174e:: with SMTP id v14mr8320136edx.153.1594798865604; Wed, 15 Jul 2020 00:41:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594798865; cv=none; d=google.com; s=arc-20160816; b=j4sDdBEEWMcUx2ZeLTWbulQkksW/e+BvqKUAD05JAO5y5oQZFx4OZCrmExfSPTeXgk PmB7YFw9/7aDXiLZd/9mnTv2Yyk5TFmcAT1vjUBXJUQhB3bFNg6IekAaSDuW6tsev92V 9UnMPEzk+idsaKKIlBi1qmsLbQzfFmSGLtqhwYVrjSvBglMJlnCtsUxHskOzbDAB/0Us E1OTzcYE3F+wn6Ql+qRnRQeRoRsuVYTYXSL0tN3UJ+cCfr8h5qGrBTi451rwtplEhr9W QnlFJZqZdqboink44byg7PT/RYVsf/AtYSfD2lpqqqU7ivA6tlMh8NAONnfju1kRRvJm a/Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject; bh=x+SWyx+4l1u0xYz2/ndCwYSq2g5E/ecFsJdrQCyqCe0=; b=FSj6WcVgetoetTYHZP3gkyMvK45QgtXASoILBt2ONg89Y2jsi1v50U4jpmbWTacasO 1yDvcvNJpoQo8/mZfIov25RvadILxUhTbi3zG1YTQuL9zzTSrnX0GB6AV14vwEKmb3jD wI+3xHVF41ufBoaQuNLphucnWrjnrFyMPVtJq5Qak7UziVdJxapJ7XlILssfjGbaOuBu G8eDsgsCgtkUOvO8WrOnXj7uxDAd6gG85M5xIeLreWdV+8EQbbeaTyEPmv7nYX4ikivs Lj9rnpt3IuFpYABRw8wUb5hbgKfHsQh40i+d8EsrCUrR8bGcAmrqPspZxL4WmYRhCw4s fJGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g4si767317edq.459.2020.07.15.00.40.42; Wed, 15 Jul 2020 00:41:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729402AbgGOHhb (ORCPT + 99 others); Wed, 15 Jul 2020 03:37:31 -0400 Received: from outpost1.zedat.fu-berlin.de ([130.133.4.66]:53775 "EHLO outpost1.zedat.fu-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729336AbgGOHha (ORCPT ); Wed, 15 Jul 2020 03:37:30 -0400 Received: from inpost2.zedat.fu-berlin.de ([130.133.4.69]) by outpost.zedat.fu-berlin.de (Exim 4.93) with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (envelope-from ) id 1jvbyp-003UhP-LS; Wed, 15 Jul 2020 09:37:27 +0200 Received: from p57bd93f9.dip0.t-ipconnect.de ([87.189.147.249] helo=[192.168.178.139]) by inpost2.zedat.fu-berlin.de (Exim 4.93) with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (envelope-from ) id 1jvbyp-0018lO-E8; Wed, 15 Jul 2020 09:37:27 +0200 Subject: Re: ioremap and dma cleanups and fixes for superh (2nd resend) To: Geert Uytterhoeven Cc: Rich Felker , Christoph Hellwig , Yoshinori Sato , Linux-sh list , Linux Kernel Mailing List References: <20200714121856.955680-1-hch@lst.de> <20200714155914.GA24404@brightrain.aerifal.cx> <8cbf2963-d0e4-0ca8-4ffe-c2057694447f@physik.fu-berlin.de> <011f29e6-ad71-366e-dbff-bc8471f3da60@physik.fu-berlin.de> From: John Paul Adrian Glaubitz Autocrypt: addr=glaubitz@physik.fu-berlin.de; keydata= mQINBE3JE9wBEADMrYGNfz3oz6XLw9XcWvuIxIlPWoTyw9BxTicfGAv0d87wngs9U+d52t/R EggPePf34gb7/k8FBY1IgyxnZEB5NxUb1WtW0M3GUxpPx6gBZqOm7SK1ZW3oSORw+T7Aezl3 Zq4Nr4Nptqx7fnLpXfRDs5iYO/GX8WuL8fkGS/gIXtxKewd0LkTlb6jq9KKq8qn8/BN5YEKq JlM7jsENyA5PIe2npN3MjEg6p+qFrmrzJRuFjjdf5vvGfzskrXCAKGlNjMMA4TgZvugOFmBI /iSyV0IOaj0uKhes0ZNX+lQFrOB4j6I5fTBy7L/T3W/pCWo3wVkknNYa8TDYT73oIZ7Aimv+ k7OzRfnxsSOAZT8Re1Yt8mvzr6FHVFjr/VdyTtO5JgQZ6LEmvo4Ro+2ByBmCHORCQ0NJhD1U 3avjGfvfslG999W0WEZLTeaGkBAN1yG/1bgGAytQQkD9NsVXqBy7S3LVv9bB844ysW5Aj1nv tgIz14E2WL8rbpfjJMXi7B5ha6Lxf3rFOgxpr6ZoEn+bGG4hmrO+/ReA4SerfMqwSTnjZsZv xMJsx2B9c8DaZE8GsA4I6lsihbJmXhw8i7Cta8Dx418wtEbXhL6m/UEk60O7QD1VBgGqDMnJ DFSlvKa9D+tZde/kHSNmQmLLzxtDbNgBgmR0jUlmxirijnm8bwARAQABtFRKb2huIFBhdWwg QWRyaWFuIEdsYXViaXR6IChGcmVpZSBVbml2ZXJzaXRhZXQgQmVybGluKSA8Z2xhdWJpdHpA cGh5c2lrLmZ1LWJlcmxpbi5kZT6JAlEEEwEIADsCGwMFCwkIBwMFFQoJCAsFFgIDAQACHgEC F4AWIQRi/4p1hOApVpVGAAZ0Jjs39bX5EwUCWhQoUgIZAQAKCRB0Jjs39bX5Ez/ID/98r9c4 WUSgOHVPSMVcOVziMOi+zPWfF1OhOXW+atpTM4LSSp66196xOlDFHOdNNmO6kxckXAX9ptvp Bc0mRxa7OrC168fKzqR7P75eTsJnVaOu+uI/vvgsbUIosYdkkekCxDAbYCUwmzNotIspnFbx iSPMNrpw7Ud/yQkS9TDYeXnrZDhBp7p5+naWCD/yMvh7yVCA4Ea8+xDVoX+kjv6EHJrwVupO pMa39cGs2rKYZbWTazcflKH+bXG3FHBrwh9XRjA6A1CTeC/zTVNgGF6wvw/qT2x9tS7WeeZ1 jvBCJub2cb07qIfuvxXiGcYGr+W4z9GuLCiWsMmoff/Gmo1aeMZDRYKLAZLGlEr6zkYh1Abt iz0YLqIYVbZAnf8dCjmYhuwPq77IeqSjqUqI2Cb0oOOlwRKVWDlqAeo0Bh8DrvZvBAojJf4H nQZ/pSz0yaRed/0FAmkVfV+1yR6BtRXhkRF6NCmguSITC96IzE26C6n5DBb43MR7Ga/mof4M UufnKADNG4qz57CBwENHyx6ftWJeWZNdRZq10o0NXuCJZf/iulHCWS/hFOM5ygfONq1Vsj2Z DSWvVpSLj+Ufd2QnmsnrCr1ZGcl72OC24AmqFWJY+IyReHWpuABEVZVeVDQooJ0K4yqucmrF R7HyH7oZGgR0CgYHCI+9yhrXHrQpyLkCDQRNyRQuARAArCaWhVbMXw9iHmMH0BN/TuSmeKtV h/+QOT5C5Uw+XJ3A+OHr9rB+SpndJEcDIhv70gLrpEuloXhZI9VYazfTv6lrkCZObXq/NgDQ Mnu+9E/E/PE9irqnZZOMWpurQRh41MibRii0iSr+AH2IhRL6CN2egZID6f93Cdu7US53ZqIx bXoguqGB2CK115bcnsswMW9YiVegFA5J9dAMsCI9/6M8li+CSYICi9gq0LdpODdsVfaxmo4+ xYFdXoDN33b8Yyzhbh/I5gtVIRpfL+Yjfk8xAsfz78wzifSDckSB3NGPAXvs6HxKc50bvf+P 6t2tLpmB/KrpozlZazq16iktY97QulyEY9JWCiEgDs6EKb4wTx+lUe4yS9eo95cBV+YlL+BX kJSAMyxgSOy35BeBaeUSIrYqfHpbNn6/nidwDhg/nxyJs8mPlBvHiCLwotje2AhtYndDEhGQ KEtEaMQEhDi9MsCGHe+00QegCv3FRveHwzGphY1YlRItLjF4TcFz1SsHn30e7uLTDe/pUMZU Kd1xU73WWr0NlWG1g49ITyaBpwdv/cs/RQ5laYYeivnag81TcPCDbTm7zXiwo53aLQOZj4u3 gSQvAUhgYTQUstMdkOMOn0PSIpyVAq3zrEFEYf7bNSTcdGrgwCuCBe4DgI3Vu4LOoAeI428t 2dj1K1EAEQEAAYkCHwQYAQgACQUCTckULgIbDAAKCRB0Jjs39bX5E683EAC1huywL4BlxTj7 FTm7FiKd5/KEH5/oaxLQN26mn8yRkP/L3xwiqXxdd0hnrPyUe8mUOrSg7KLMul+pSRxPgaHA xt1I1hQZ30cJ1j/SkDIV2ImSf75Yzz5v72fPiYLq9+H3qKZwrgof9yM/s0bfsSX/GWyFatvo Koo+TgrE0rmtQw82vv7/cbDAYceQm1bRB8Nr8agPyGXYcjohAj7NJcra4hnu1wUw3yD05p/B Rntv7NvPWV3Oo7DKCWIS4RpEd6I6E+tN3GCePqROeK1nDv+FJWLkyvwLigfNaCLro6/292YK VMdBISNYN4s6IGPrXGGvoDwo9RVo6kBhlYEfg6+2eaPCwq40IVfKbYNwLLB2MR2ssL4yzmDo OR3rQFDPj+QcDvH4/0gCQ+qRpYATIegS8zU5xQ8nPL8lba9YNejaOMzw8RB80g+2oPOJ3Wzx oMsmw8taUmd9TIw/bJ2VO1HniiJUGUXCqoeg8homvBOQ0PmWAWIwjC6nf6CIuIM4Egu2I5Kl jEF9ImTPcYZpw5vhdyPwBdXW2lSjV3EAqknWujRgcsm84nycuJnImwJptR481EWmtuH6ysj5 YhRVGbQPfdsjVUQfZdRdkEv4CZ90pdscBi1nRqcqANtzC+WQFwekDzk2lGqNRDg56s+q0KtY scOkTAZQGVpD/8AaLH4v1w== Message-ID: <47673a8f-cda1-4915-df20-068acfc49892@physik.fu-berlin.de> Date: Wed, 15 Jul 2020 09:37:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Original-Sender: glaubitz@physik.fu-berlin.de X-Originating-IP: 87.189.147.249 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert! On 7/15/20 9:27 AM, Geert Uytterhoeven wrote: > Hi Adrian, > > On Wed, Jul 15, 2020 at 1:14 AM John Paul Adrian Glaubitz > wrote: >> However, independent of Christoph's series, the kernels throws two backtraces during >> boot which I think should require a git bisect (unless I missed a configuration option >> as I trimmed down the kernel a bit to make sure it's not too big). >> >> See the traces below and let me know what you think. > >> [ 1.560000] sh-sci.1: ttySC1 at MMIO 0xffeb0000 (irq = 44, base_baud = 0) is a scif >> [ 1.560000] BUG: spinlock bad magic on CPU#0, swapper/1 >> [ 1.560000] lock: sci_ports+0x1d8/0xb10, .magic: 00000000, .owner: /-1, .owner_cpu: 0 > > [PATCH v1] serial: core: Initialise spin lock before use in > uart_configure_port() > https://lore.kernel.org/r/20200706140036.75524-1-andriy.shevchenko@linux.intel.com Yes, this patch fixes this particular problem. There is just a typo in the code which causes a build problem but it's fixed by replacing "uport" with "port": CC kernel/module.o drivers/tty/serial/serial_core.c: In function ‘uart_configure_port’: drivers/tty/serial/serial_core.c:2385:33: error: ‘uport’ undeclared (first use in this function); did you mean ‘port’? 2385 | uart_any_port_spin_lock_init(uport); | ^~~~~ | port drivers/tty/serial/serial_core.c:2385:33: note: each undeclared identifier is reported only once for each function it appears in make[3]: *** [scripts/Makefile.build:280: drivers/tty/serial/serial_core.o] Error 1 make[2]: *** [scripts/Makefile.build:497: drivers/tty/serial] Error 2 make[1]: *** [scripts/Makefile.build:497: drivers/tty] Error 2 make[1]: *** Waiting for unfinished jobs.... AR drivers/base/firmware_loader/built-in.a Will test the other changes in a minute. Can we include the serial fix? Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913