Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Jul 2020 09:30:17 +0100
From:   Will Deacon <will@kernel.org>
To:     John Garry <john.garry@huawei.com>
Cc:     zhangshaokun@hisilicon.com, mark.rutland@arm.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        qiangqing.zhang@nxp.com, jolsa@redhat.com, linuxarm@huawei.com
Subject: Re: [PATCH] drivers/perf: hisi: Add identifier sysfs file
Message-ID: <20200715083016.GB5683@willie-the-truck>
References: <1592399111-134786-1-git-send-email-john.garry@huawei.com>
 <20200714083216.GD4516@willie-the-truck>
 <67db3c30-5aaf-ac17-0256-950494f5ba88@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <67db3c30-5aaf-ac17-0256-950494f5ba88@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,

On Wed, Jul 15, 2020 at 09:23:19AM +0100, John Garry wrote:
> > On Wed, Jun 17, 2020 at 09:05:11PM +0800, John Garry wrote:
> > > To allow userspace to identify the specific implementation of the device,
> > > add an "identifier" sysfs file.
> > > 
> > > Encoding is as follows:
> > > hi1620: 0x0	(aka hip08)
> > > hi1630: 0x30
> > > 
> > > Signed-off-by: John Garry <john.garry@huawei.com>
> > 
> > I'm struggling a bit to track this. If you still think it's worth pursuing,
> > please could you post a series with a cover-letter describing what this is
> > for, a link to the userspace changes and then patches for all the PMU
> > drivers that need updating?
> 
> There is no hi1630 userspace support yet.
> 
> So what I can do is post updated userspace support (including hi1630), and
> then post kernel parts together for all drivers we could initially support.
> 
> @Joakim, I'll pick your imx driver changes here, if you don't mind.
> 
> There was an RFC from you for the SMMUv3 PMU as
> > well, and also some other "arm64" changes.
> > 
> 
> I hope to drop that RFC if an updated SMMUv3 spec helps us out.

Thanks, John. That should be a tonne easier to review.

Will