Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Jul 2020 10:49:40 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Qing Zhang <zhangqing@loongson.cn>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] spi: coldfire-qspi: Use clk_prepare_enable and
 clk_disable_unprepare
Message-ID: <20200715094940.GB5431@sirena.org.uk>
References: <1594790807-32319-1-git-send-email-zhangqing@loongson.cn>
 <1594790807-32319-2-git-send-email-zhangqing@loongson.cn>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="tjCHc7DPkfUGtrlw"
Content-Disposition: inline
In-Reply-To: <1594790807-32319-2-git-send-email-zhangqing@loongson.cn>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--tjCHc7DPkfUGtrlw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 15, 2020 at 01:26:47PM +0800, Qing Zhang wrote:
> Convert clk_enable() to clk_prepare_enable() and clk_disable() to
> clk_disable_unprepare() respectively in the spi-coldfire-qspi.c.

Like I said on the previous version are you sure that ColdFire uses the
common clock framework and has the prepare calls?

--tjCHc7DPkfUGtrlw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8O0TQACgkQJNaLcl1U
h9A/dgf/aLQzZJxJjJtHkv0PkrYiFHMKt2j85g9+O2DYaRsaX7NqkYxlg7mdzgaC
m/+BgYLwuUMzGHtkk10454Sdixed6OMIARbGbX6SfzUOIgkeqMOmStuTlVh1ShcL
TLB6EBDXUaVXvozf5NTIfQg2HYoB/4eUILY8jI56JJwhn034883Eu429EGbOQWCs
TO9ndf1B6klLdBJ+u7Arl20jUHmiCYPLIuhPHdaKSzsV8FMMP4TdmeMhi1SX0fVO
uiTbBXXsucV3+d7KUxLzCUR+h4plV0R5ckyucfTZE3luKrg3PYHL5VXUE3S9UVlz
rHHfbNqENQMR5G8iyTkI8IjSiqnF8w==
=How3
-----END PGP SIGNATURE-----

--tjCHc7DPkfUGtrlw--