Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp374762ybh; Wed, 15 Jul 2020 04:26:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxjktelpTC36tj5O2JcYOFeq5IQoyW2LCrE/VtmebBed7S7v+WvfYrFTpW1RmQbSrce6OKk X-Received: by 2002:a17:906:8588:: with SMTP id v8mr9089058ejx.211.1594812380926; Wed, 15 Jul 2020 04:26:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594812380; cv=none; d=google.com; s=arc-20160816; b=MO9wQClm6v6TX5Azh0ZpGg/Cz0uOIe41kGYoAF1yMu0GxkWXwOJ89KfyAl1v6b/a9O byeerpOU7n8xMt5jP5BhjNrpSvXyS4ML33j/GtGdkhjL2aeDwAoS8+e8x68Ylhe9xm9H m2GsZgyfGo40WEpcuAe7HBhPn/Vf8wGcowQ9qCgnl/+oUdJ06SRvSPtq2ScquVaEWG14 J0ycs+Hdm8emz5EDvtoD3NjmTp8kMAduxEjebMAfpAHH+CobmUBC6V6i3MP34sfEc2Ch vesk2U/YzVwsIigocxol+wSh2wI7+6IbThL601WQo2e5jtDzkDF7I0b+gp+1BRsmgqii IWNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature; bh=lAvnqX/ZVMt/mESdc2pgjD3f4/qNilQWsHcdnTWed+w=; b=HY8gSKzD6MjCWLQ/MRkKYqzDZyH2oV7GI9pNstUf2u/DmkRISmfKK06MkoxZqn95A3 LlNiEfNgk+j2WYJgrQH4wq1fyxd7FTAO0Jm8jZ+UMhrTRKQ3xPDdQT4pbMFPPOMrKguV zqD0diXy0u6BRB7IFd2xMm/bZoHeINcuzGpgdiWWHEwH3MwMrQ8XRCBpGsDtGeK2gJ6s Ht652OkLsmAW/afwXFR991ecBDA4ZE5rpwiFfLmPdXjFkGd5w0Lpsxd31I179s2Gfs91 hDwnIsWpnfsSHKxZZXGZtsvTe+tK021Ys+lVMPIG/Z9eQjbHWKuqbJ02DK6yScbwA69A FMpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=uOVzAsDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si1076528eje.121.2020.07.15.04.25.55; Wed, 15 Jul 2020 04:26:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=uOVzAsDJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731240AbgGOKjS (ORCPT + 99 others); Wed, 15 Jul 2020 06:39:18 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:40723 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728430AbgGOKjS (ORCPT ); Wed, 15 Jul 2020 06:39:18 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594809558; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=lAvnqX/ZVMt/mESdc2pgjD3f4/qNilQWsHcdnTWed+w=; b=uOVzAsDJ4qMdUU0/U/35LkW9Qt3aN35eNwrwUJs6Lhwo1YU8E12iCyiPxLElcGSSJHksTL/G +9OmHuKK6oQc+8E4HcRPx1G9o6PNg7OHL5Ho8cBbUoWiKqs4/jo4QEwYgdigXtkPRCqCxcxa CFl3a5HfnbEHp6xuvqoeOZepaNM= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n17.prod.us-east-1.postgun.com with SMTP id 5f0edcd3d3d65084226d1d07 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 15 Jul 2020 10:39:15 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B89A0C433A0; Wed, 15 Jul 2020 10:39:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=2.0 tests=ALL_TRUSTED,MISSING_DATE, MISSING_MID,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9C855C433C6; Wed, 15 Jul 2020 10:39:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9C855C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v1] adm8211: use generic power management From: Kalle Valo In-Reply-To: <20200629035031.169670-1-vaibhavgupta40@gmail.com> References: <20200629035031.169670-1-vaibhavgupta40@gmail.com> To: Vaibhav Gupta Cc: Bjorn Helgaas , Bjorn Helgaas , bjorn@helgaas.com, Vaibhav Gupta , "David S. Miller" , Jakub Kicinski , Vaibhav Gupta , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, linux-wireless@vger.kernel.org User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20200715103913.B89A0C433A0@smtp.codeaurora.org> Date: Wed, 15 Jul 2020 10:39:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vaibhav Gupta wrote: > With legacy PM, drivers themselves were responsible for managing the > device's power states and takes care of register states. > > After upgrading to the generic structure, PCI core will take care of > required tasks and drivers should do only device-specific operations. > > In the case of adm8211, after removing PCI helper functions, .suspend() > and .resume() became empty-body functions. Hence, define them NULL and > use dev_pm_ops. > > Compile-tested only. > > Signed-off-by: Vaibhav Gupta Patch applied to wireless-drivers-next.git, thanks. 04bceecdf1e8 adm8211: use generic power management -- https://patchwork.kernel.org/patch/11632321/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches