Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp447097ybh; Wed, 15 Jul 2020 06:21:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJziuWJM58Olz8MFtOQmztHHrVUJA/V4KqOea++UgqOVwTEo6DLY680wZs1lTdyZkr/kRqk9 X-Received: by 2002:a05:6402:1614:: with SMTP id f20mr9201353edv.129.1594819278751; Wed, 15 Jul 2020 06:21:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594819278; cv=none; d=google.com; s=arc-20160816; b=ay6eTwgSSfTHXopk4Ol0O+iYpb6LbPHBxMQeLgHUq9GDLy5rYB7a/iOBfhuIlFcWrk rb5Up5hDUl0gvKJ1z0ri7UeG8zYRj7xV+TKHhPV6OZZR1kX//mcm6shleAkXdXlc7gt+ lCbT608pxAZIzATvboEgVb3k3gUeO4hogm19QWK9E9vAoI9G6hjMnN8MvbHC+mkPYW3Y C3nmYkCE1+XBmT+D6cbfaaq0KhN92wdm9Y8G1IJb4Pv73w+w89NRIsvMMFmpQ2L4KzDB inLMpB2p2OHgrSPlrT095kHxgfM4JOqTWK5nP6ojVRvevapngWoxzyWudoFzjZYHtbH6 kkhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1UprE3twSbDjJ8UOg8Ylixxck9YxnnK/B3xSsBH5EXA=; b=d8ducQxW1TxJuJ9a0SsguZh0REHY6/5fxstrpVDjEwtdF443C1tZQZThJx4fGdqoT7 iYWZVlIVaEvdDtJpkp77QQ18JQu2lGXClCt43oXnz9BQbEhESGZA+7S/apIldeQAAdlf Z/LXzCUaqI5du73GO3KOE6iVGEZcaddd+kBExQ9yo+yitNMkfQoVN/KITzxjeKDUL9UG qHDGvpcT9VWors2cLXb5io1QxxDNKu8uzn3Q8jLX7gtjqrnUE9p/bSDxr3QgqNz6TtL0 OGCwnypKrHh0SvKNleaM9+hqXiKUimCZtvzXApBP2jnV+R4d2QE7Z1lmq+dtNSv5i3VA q+Lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TMzCsrRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce19si1167769ejc.304.2020.07.15.06.20.54; Wed, 15 Jul 2020 06:21:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TMzCsrRE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731703AbgGONUQ (ORCPT + 99 others); Wed, 15 Jul 2020 09:20:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:34730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729900AbgGONUQ (ORCPT ); Wed, 15 Jul 2020 09:20:16 -0400 Received: from localhost (lfbn-ncy-1-317-216.w83-196.abo.wanadoo.fr [83.196.152.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 96B3F20578; Wed, 15 Jul 2020 13:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594819216; bh=GSpr6UASAlStOTqKkZNRWIGI2XEGUU7o/VqNPRA9ZGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TMzCsrREac3xi0lBCtQKKs5hLraFo47JH9tU4OQSUIP3qyOn17RhiZ3D2IB3cWgEK GGgwnW50CraCwBnJhIQZzI6u0G2bnnp3G+Pwbfk6gclH2qqF6ahzAzZdRgvu6U+31J JvLVbM72Nod4Dx4RJg7HtxESW/0XX59dQYmlKeK8= Date: Wed, 15 Jul 2020 15:20:14 +0200 From: Frederic Weisbecker To: Anna-Maria Behnsen Cc: Thomas Gleixner , LKML , Peter Zijlstra , Juri Lelli Subject: Re: [PATCH 1/9] timer: Move trigger_dyntick_cpu() to enqueue_timer() Message-ID: <20200715132010.GB16227@lenoir> References: <20200707013253.26770-1-frederic@kernel.org> <20200707013253.26770-2-frederic@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 09, 2020 at 02:17:35PM +0200, Anna-Maria Behnsen wrote: > Hi Frederic, > > On Tue, 7 Jul 2020, Frederic Weisbecker wrote: > > > Consolidate the code by calling trigger_dyntick_cpu() from > > enqueue_timer() instead of calling it from all its callers. > > Looks good, but maybe you could also update the comments in the code (see > remarks below)? Ok, fixing that, thanks!