Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200629114927.17379-1-bruno.thomsen@gmail.com>
 <20200629114927.17379-2-bruno.thomsen@gmail.com> <20200713025246.GY21277@dragon>
 <CAH+2xPAHKY6YfhO-jXfKN+TRN5LDT1Kkn8a8HUj_EOqFt=75nQ@mail.gmail.com> <CAOMZO5DsyqRgD8n-w=6OmnXuMX+1T2DDOjQLNK133=FaqtWXVQ@mail.gmail.com>
In-Reply-To: <CAOMZO5DsyqRgD8n-w=6OmnXuMX+1T2DDOjQLNK133=FaqtWXVQ@mail.gmail.com>
From:   Bruno Thomsen <bruno.thomsen@gmail.com>
Date:   Wed, 15 Jul 2020 16:21:55 +0200
Message-ID: <CAH+2xPD31bdb_ZjAi6qo5n25K469Ak-qt2GJCcppHk4FZChdeg@mail.gmail.com>
Subject: Re: [PATCH 2/3] ARM: dts: imx7: add support for kamstrup flex concentrator
To:     Fabio Estevam <festevam@gmail.com>
Cc:     Shawn Guo <shawnguo@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Bruno Thomsen <bth@kamstrup.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Den tir. 14. jul. 2020 kl. 13.54 skrev Fabio Estevam <festevam@gmail.com>:
>
> Hi Bruno,
>
> On Tue, Jul 14, 2020 at 7:03 AM Bruno Thomsen <bruno.thomsen@gmail.com> wrote:
>
> > I have not yet been successful in converting the deprecated properties
> > to generic phy properties, so hoping I could get a hit.
> >
> > Kernel error messages:
> > mdio_bus 30be0000.ethernet-1: MDIO device at address 1 is missing.
>
> Please double-check whether 1 is the correct address for the KSZ8051
> Ethernet PHY as per your schematics.

Hi Fabio,

Thanks for the hints.

Yes, the address is correct and configured with external resistors,
but just realised that I wrote the wrong device name in the comment,
it's actually KSZ8081RNB.

Ethernet has been working with multiple mainline kernel versions
(latest being 5.7.8)
for the last year or so when using the DTS in patch. So I am pretty sure
hardware and setup of mux is correct'ish.

Kernel trace from patch version:
kernel: Micrel KSZ8081 or KSZ8091 30be0000.ethernet-1:01: attached PHY driver
 [Micrel KSZ8081 or KSZ8091] (mii_bus:phy_addr=30be0000.ethernet-1:01, irq=POLL)

Error first occurs when switching from fec phy reset to mdio phy reset
code path,
I understand that the fec phy reset is obsolete as phy properties was wrongly
added to the mac and of course should be part of the phy (separate chip).

When debugging it I end up with the get_phy_device() call not working
inside of_mdiobus_register_phy().

Workaround at the moment seems to be extending compatible with
"ethernet-phy-id0022.1560" to disable auto detection of phy type,
and then Ethernet works again. At least the same PHY driver trace
can be found and full transmission speed can be used without packet
errors/loss.

> Are there external pull-up/pull-down resistors for strapping the
> various configuration pins for the PHY? Or are the pull-up/pull-down
> provided by the i.MX7D pins?

Config strapping is done with external resistors.

> If there are no external pull-ups, please make sure to configure the
> pinctrl_enet1 accordingly, so that the Ethernet PHY address can be
> properly configured and then mdio_bus driver can find it at the
> correct address.
>
> Please check in arch/arm/boot/dts/imx6qdl-sr-som.dtsi for an example
> on how to configure the Ethernet PHY pin strapping via iMX IOMUX.

Thanks, good examples can be hard to find.

/Bruno