Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp588138ybh; Wed, 15 Jul 2020 09:48:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcDb6RvmEgt35PRMKzB53YFhxK8OfeY3McabYmtsCmj7lp4ngWSaTZoIshUYnt96zQXXIC X-Received: by 2002:aa7:dacb:: with SMTP id x11mr471002eds.280.1594831686203; Wed, 15 Jul 2020 09:48:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594831686; cv=none; d=google.com; s=arc-20160816; b=ixKSFXl7pa39zBg9Y2zBxe8GRyx5AEyoKQloXTa5CpVrMnkU1Mxs527EpwlGTJssJn e3rZ3aOFWxiCLuCrlUy5/WZJvcM6PtJNS5DzbMhUQOC/9u7lZTAuEOAiwgcLXrq8VJHO oE6yM+rvRh/GiKNx3TjOOTvq6JNXVJV/R8IURlAXTWvGvzTwMHS6aRh79uM1qitFNBp9 srLtumCAEmd48onugGO19Tt7gyW8hR5zWVPKHUsE7pCIIjok1DPSjYvwR0CzRT+JEjMK CxYHGiKV1muK6CTARrEkA+4cuPD0Lf6CipJuN8fPh0Q/iokjLWtPOqe98+b57lteM1Un GgNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=CYYaM7nLH2uBsf76rm+eIrc4ZB7bxdif3Z9op5W0Z7Q=; b=pzetYkGWEgYs9uWyCdRvTKkt+e+Qv4miQvSXsLThFKFhmwoTCVtczrz2UtFLclHKwD hlIqGKJXCN6MblrGofwFYfmXof3wYOEQkDnwOa8bLVyu54PntOf6ifwCiuoUJGErvFe9 YIxEibN+2NWl1yrJ/DmbehYzbRcjyjCLCcvCQEDLwZ9K706qGUSutz4+VAawd5oZ5VcU 1d2aed3pONrGNeIeHhykEYY/bHeC5+exTHB2JpJzcXbF68hRwWCZzXndueAMvQs0clqV n5q3Z2YATJc0e65ksP4MxgfX29mNEMYHPlqjYXclZ3aHyoTCuWOr+/pjap3Io/apX4lK yyFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l9si1671198ejq.76.2020.07.15.09.47.42; Wed, 15 Jul 2020 09:48:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728126AbgGOQqF (ORCPT + 99 others); Wed, 15 Jul 2020 12:46:05 -0400 Received: from foss.arm.com ([217.140.110.172]:57722 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726916AbgGOQqE (ORCPT ); Wed, 15 Jul 2020 12:46:04 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 04E9931B; Wed, 15 Jul 2020 09:46:03 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 39EA53F718; Wed, 15 Jul 2020 09:46:02 -0700 (PDT) Date: Wed, 15 Jul 2020 17:45:59 +0100 From: Lorenzo Pieralisi To: Dejin Zheng Cc: Rob Herring , "Chocron, Jonathan" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [PATCH v1] PCI: controller: Remove duplicate error message Message-ID: <20200715164559.GC3432@e121166-lin.cambridge.arm.com> References: <20200526150954.4729-1-zhengdejin5@gmail.com> <1d7703d5c29dc9371ace3645377d0ddd9c89be30.camel@amazon.com> <20200527132005.GA7143@nuc8i5> <1b54c08f759c101a8db162f4f62c6b6a8a455d3f.camel@amazon.com> <20200706155847.GA32050@e121166-lin.cambridge.arm.com> <20200711074733.GD3112@nuc8i5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200711074733.GD3112@nuc8i5> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 11, 2020 at 03:47:33PM +0800, Dejin Zheng wrote: > On Mon, Jul 06, 2020 at 04:58:47PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Jun 02, 2020 at 09:01:13AM -0600, Rob Herring wrote: > > > > [...] > > > > > > The other 2 error cases as well don't print the resource name as far as > > > > I recall (they will at least print the resource start/end). > > > > > > Start/end are what are important for why either of these functions > > > failed. > > > > > > But sure, we could add 'name' here. That's a separate patch IMO. > > Hi Lorenzo, Bob and Jonathan: > > Thank you very much for helping me review this patch, I merge this patch in pci/misc, thanks. > I sent a new patch for print the resource name when the request memory > region or remapping of configuration space fails. and it is here: > https://patchwork.kernel.org/patch/11657801/ We will get to it soon. Lorenzo